You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/10 08:54:03 UTC

[GitHub] [flink] knaufk commented on issue #9030: [FLINK-13123] Align Stop/Cancel Commands in CLI and REST Interface and Improve Documentation

knaufk commented on issue #9030: [FLINK-13123] Align Stop/Cancel Commands in CLI and REST Interface and Improve Documentation
URL: https://github.com/apache/flink/pull/9030#issuecomment-509973798
 
 
    @zentol Thanks for the review!
   
   @carp84 I think, the problem is that the old `stop` command never really worked. The only two sources implementing the `StoppableFunction` interface were the `NiFiSource` and the `TwitterSource`. Of course, custom sources might have implemented it. Personally, I would be ok with changing this and adding a warning to the release notes and mention to use `cancel` for a quick ungraceful shutdown.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services