You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "wsjz (via GitHub)" <gi...@apache.org> on 2023/04/23 01:51:33 UTC
[GitHub] [doris] wsjz opened a new pull request, #18938: [refact](multi-catalog)storage rafactor 1
wsjz opened a new pull request, #18938:
URL: https://github.com/apache/doris/pull/18938
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] wsjz commented on a diff in pull request #18938: [refactor](fs)(step1) add new storage file system
Posted by "wsjz (via GitHub)" <gi...@apache.org>.
wsjz commented on code in PR #18938:
URL: https://github.com/apache/doris/pull/18938#discussion_r1174587812
##########
fe/fe-core/src/main/java/org/apache/doris/fs/obj/HdfsStorage.java:
##########
@@ -15,9 +15,11 @@
// specific language governing permissions and limitations
// under the License.
-package org.apache.doris.backup;
Review Comment:
I will remove it in PR2 as it is a deprecated class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18938: [refactor](fs)(step1) add new storage file system
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18938:
URL: https://github.com/apache/doris/pull/18938#issuecomment-1519297092
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] wsjz commented on pull request #18938: [refact](multi-catalog)storage rafactor 1
Posted by "wsjz (via GitHub)" <gi...@apache.org>.
wsjz commented on PR #18938:
URL: https://github.com/apache/doris/pull/18938#issuecomment-1518970631
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] wsjz commented on a diff in pull request #18938: [refactor](fs)(step1) add new storage file system
Posted by "wsjz (via GitHub)" <gi...@apache.org>.
wsjz commented on code in PR #18938:
URL: https://github.com/apache/doris/pull/18938#discussion_r1174587812
##########
fe/fe-core/src/main/java/org/apache/doris/fs/obj/HdfsStorage.java:
##########
@@ -15,9 +15,11 @@
// specific language governing permissions and limitations
// under the License.
-package org.apache.doris.backup;
Review Comment:
I will remove this class in PR2 as it is a deprecated class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #18938: [refactor](fs)(step1) add new storage file system
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #18938:
URL: https://github.com/apache/doris/pull/18938
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18938: [refactor](fs)(step1) add new storage file system
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18938:
URL: https://github.com/apache/doris/pull/18938#issuecomment-1519297125
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] wsjz commented on pull request #18938: [refact](multi-catalog)storage rafactor 1
Posted by "wsjz (via GitHub)" <gi...@apache.org>.
wsjz commented on PR #18938:
URL: https://github.com/apache/doris/pull/18938#issuecomment-1518921225
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] wsjz commented on pull request #18938: [refact](multi-catalog)storage rafactor 1
Posted by "wsjz (via GitHub)" <gi...@apache.org>.
wsjz commented on PR #18938:
URL: https://github.com/apache/doris/pull/18938#issuecomment-1518978425
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] wsjz commented on pull request #18938: [refactor](fs)(step1) add new storage file system
Posted by "wsjz (via GitHub)" <gi...@apache.org>.
wsjz commented on PR #18938:
URL: https://github.com/apache/doris/pull/18938#issuecomment-1519076632
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #18938: [refactor](fs)(step1) add new storage file system
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #18938:
URL: https://github.com/apache/doris/pull/18938#discussion_r1174571031
##########
fe/fe-core/src/main/java/org/apache/doris/fs/obj/HdfsStorage.java:
##########
@@ -15,9 +15,11 @@
// specific language governing permissions and limitations
// under the License.
-package org.apache.doris.backup;
Review Comment:
Why moving `hdfs` to `fs/obj`? hdfs is not a object storage system
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org