[GitHub] [airflow] SamWheating commented on a change in pull request #15137: Adding retries when starting kubernetes pods

[GitBox <gi...@apache.org>]

SamWheating commented on a change in pull request #15137:
URL: https://github.com/apache/airflow/pull/15137#discussion_r605870761



##########
File path: airflow/kubernetes/pod_launcher.py
##########
@@ -98,6 +98,12 @@ def delete_pod(self, pod: V1Pod):
             if e.status != 404:
                 raise
 
+    @tenacity.retry(
+        stop=tenacity.stop_after_attempt(3),
+        wait=tenacity.wait_random_exponential(),
+        reraise=True,
+        retry=tenacity.retry_if_exception_type(ApiException),

Review comment:
       I believe so, I think it would also cover 5xx errors due to invalid credentials in which case there definitely isn't any point to retrying. 
   
   With this in mind, should we scope this retry down to only cover 409 errors? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org