You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "ahlag (via GitHub)" <gi...@apache.org> on 2026/10/17 07:33:56 UTC
[PR] fix(arrow-array): use the field's type id in dense union logical_nulls [arrow-rs]
ahlag opened a new pull request, #11643:
URL: https://github.com/apache/arrow-rs/pull/11643
# Which issue does this PR close?
- Closes #11595.
# Rationale for this change
A dense union with a single field whose type id is not 0 reported no logical nulls, so `logical_null_count`, `is_null` and `is_not_null` were wrong for it.
# What changes are included in this PR?
The single-field path of `UnionArray::logical_nulls` passed the child nulls to `gather_nulls` under type id 0. It now passes the field's own type id, enumerating `self.fields` the same way `fields_logical_nulls` does.
# Are these changes tested?
Yes, `test_dense_union_one_field_nonzero_type_id_logical_nulls`. It fails without the fix.
# Are there any significant user-facing changes?
No.
AI use: I used Claude Code to find the cause and write the fix and test. I reviewed the change and checked that the test fails without the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(arrow-array): use the field's type id in dense union logical_nulls [arrow-rs]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey merged PR #11643:
URL: https://github.com/apache/arrow-rs/pull/11643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org