You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2019/09/17 20:46:37 UTC

[GitHub] [helix] jiajunwang commented on a change in pull request #478: Add the remaining implementation of ConstraintBasedAlgorithmFactory

jiajunwang commented on a change in pull request #478: Add the remaining implementation of ConstraintBasedAlgorithmFactory
URL: https://github.com/apache/helix/pull/478#discussion_r325376537
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
 ##########
 @@ -79,13 +79,12 @@
   private final RebalanceAlgorithm _rebalanceAlgorithm;
   // ------------------------------------------------------------------------------------//
 
-  public WagedRebalancer(HelixManager helixManager) {
+  public WagedRebalancer(HelixManager helixManager, ClusterConfig clusterConfig) {
 
 Review comment:
   Let's pass the map only, Map<GlobalRebalancePreferenceKey, Integer>.
   ClusterConfig is too much for the rebalancer.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org