You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2023/10/04 06:23:07 UTC

Re: [PR] [SPARK-45357][CONNECT][TESTS] Normalize `dataframeId` when comparing `CollectMetrics` in `SparkConnectProtoSuite` [spark]

zhengruifeng commented on PR #43155:
URL: https://github.com/apache/spark/pull/43155#issuecomment-1746211815

   In `PlanGenerationTestSuite`, the `planId` was reset before each test
   
   https://github.com/apache/spark/blob/4863dec91f1cd596e60b42f1cbef9f6df327e562/connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/PlanGenerationTestSuite.scala#L119-L121
   
   IIRC, the `dataframeId` in `CollectMetrics` is also the `planId`, so is it possible to simply reset the `planId` before problematic test suites?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org