You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Hervé BOUTEMY <he...@free.fr> on 2016/07/04 14:57:13 UTC
Maven color status
Hi,
To me, color is now feature complete: configuration has been added in r1751085
(thanks Sébastian), for those wanting to customize their own personal color
scheme.
There is now only one issue: where to put the code?
It is currently in maven-shared-utils, but maven-shared-utils depends on
maven-core (for toolchains): see MSHARED-567
Should we remove the dependency? Should we move the code to another place?
It would be nice to be able to release Maven 3.4.0 :)
Regards,
Hervé
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven color status
Posted by Hervé BOUTEMY <he...@free.fr>.
because the code has to be available for plugins without requiring Maven 3.4
(even if color won't be enabled when run with older Maven versions)
Regards,
Hervé
Le lundi 4 juillet 2016 17:21:57 Arnaud Héritier a écrit :
> What was the reason to not have it in core ?
>
> On Mon, Jul 4, 2016 at 4:57 PM, Hervé BOUTEMY <he...@free.fr> wrote:
> > Hi,
> >
> > To me, color is now feature complete: configuration has been added in
> > r1751085
> > (thanks Sébastian), for those wanting to customize their own personal
> > color
> > scheme.
> >
> > There is now only one issue: where to put the code?
> > It is currently in maven-shared-utils, but maven-shared-utils depends on
> > maven-core (for toolchains): see MSHARED-567
> >
> > Should we remove the dependency? Should we move the code to another place?
> >
> > It would be nice to be able to release Maven 3.4.0 :)
> >
> > Regards,
> >
> > Hervé
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven color status
Posted by Arnaud Héritier <ah...@gmail.com>.
What was the reason to not have it in core ?
On Mon, Jul 4, 2016 at 4:57 PM, Hervé BOUTEMY <he...@free.fr> wrote:
> Hi,
>
> To me, color is now feature complete: configuration has been added in
> r1751085
> (thanks Sébastian), for those wanting to customize their own personal color
> scheme.
>
> There is now only one issue: where to put the code?
> It is currently in maven-shared-utils, but maven-shared-utils depends on
> maven-core (for toolchains): see MSHARED-567
>
> Should we remove the dependency? Should we move the code to another place?
>
> It would be nice to be able to release Maven 3.4.0 :)
>
> Regards,
>
> Hervé
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
--
-----
Arnaud Héritier
http://aheritier.net
Mail/GTalk: aheritier AT gmail DOT com
Twitter/Skype : aheritier
Re: Maven color status
Posted by Robert Scholte <rf...@apache.org>.
On Mon, 04 Jul 2016 19:55:27 +0200, Christian Schulte <cs...@schulte.it>
wrote:
> Am 07/04/16 um 19:42 schrieb Manfred Moser:
>> To be honest I dont think it would be a problem if it were in core.
>> Easier to understand for plugin developers potentially
>> and a good motivation for users to upgrade as well as plugin developers
>> to move forward..
>
> Move everything depending on toolchains from maven-shared-utils into
> maven-core? Sounds strange that maven-shared-utils depends on
> maven-core. Either something in maven-core should not be part of
> maven-core or something in maven-shared-utils should not be part of
> maven-shared-utils.
>
> Regards,
I was wondering why Toolchain was required by maven-shared-utils. There's
a JavaTool wrapper for easy usage of Toolchain. Every plugin wrapping
something in the jdk/bin or jre/bin might want to use this, so yes it is
shared.
However, IMO it is too Java specific and I still see Maven as a language
independent tool.
I have this idea of language-extensions, and this would be something to
move to such extension.
The logic of MavenProject.classpath should move to this extension too,
since it is Java specific. And we have a location were we can specify the
Java9 modulePaths as well.
Now back to the Messaging-Utils. The question is: do we want to say to all
maven-plugin developers that if they want colors in their output, set the
Maven prerequisite to 3.4.0? Plugin development will be easy, but Maven
users are required to install a newer version of Maven.
If we want to please the users more compared to developers AND we want to
let Maven core use the same code, then I'd go for the separate,
single-class (?) jar. It is the most flexible solution.
thanks,
Robert
ps. can we get rid of the argument-less methods? With the
logWithStyle(Object) you can do exactly the same things, right?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven color status
Posted by Manfred Moser <ma...@simpligility.com>.
Not to that extreme obviously. But I am just saying the colorization might not need a separate new component. It should fit somewhere in the existing components. And if the choice means that you only get colorization with 3.4.0 and plugins that depends on that latest component... so be it ..
Manfred
Christian Schulte wrote on 2016-07-04 10:55:
> Am 07/04/16 um 19:42 schrieb Manfred Moser:
>> To be honest I dont think it would be a problem if it were in core. Easier to
>> understand for plugin developers potentially
>> and a good motivation for users to upgrade as well as plugin developers to
>> move forward..
>
> Move everything depending on toolchains from maven-shared-utils into
> maven-core? Sounds strange that maven-shared-utils depends on
> maven-core. Either something in maven-core should not be part of
> maven-core or something in maven-shared-utils should not be part of
> maven-shared-utils.
>
> Regards,
> --
> Christian
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven color status
Posted by Christian Schulte <cs...@schulte.it>.
Am 07/04/16 um 19:42 schrieb Manfred Moser:
> To be honest I dont think it would be a problem if it were in core. Easier to understand for plugin developers potentially
> and a good motivation for users to upgrade as well as plugin developers to move forward..
Move everything depending on toolchains from maven-shared-utils into
maven-core? Sounds strange that maven-shared-utils depends on
maven-core. Either something in maven-core should not be part of
maven-core or something in maven-shared-utils should not be part of
maven-shared-utils.
Regards,
--
Christian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven color status
Posted by Manfred Moser <ma...@simpligility.com>.
To be honest I dont think it would be a problem if it were in core. Easier to understand for plugin developers potentially
and a good motivation for users to upgrade as well as plugin developers to move forward..
Manfred
Karl Heinz Marbaise wrote on 2016-07-04 10:38:
> Hi,
>
> On 7/4/16 6:52 PM, Christian Schulte wrote:
>> Am 07/04/16 um 16:57 schrieb Herv BOUTEMY:
>>> Hi,
>>>
>>> To me, color is now feature complete: configuration has been added in
>>> r1751085
>>> (thanks Sbastian), for those wanting to customize their own personal color
>>> scheme.
>>>
>>> There is now only one issue: where to put the code?
>>> It is currently in maven-shared-utils, but maven-shared-utils depends on
>>> maven-core (for toolchains): see MSHARED-567
>>>
>>> Should we remove the dependency? Should we move the code to another place?
>>
>> We have
>>
>> maven-model
>> maven-model-builder
>> maven-settings
>> maven-settings-builder
>>
>> Would
>>
>> maven-toolchains
>> maven-toolchains-builder
>>
>> or something like this solve the issue or would it be the same as
>> depending on maven-core? So the issue is that toolchains is located
>> somewhere inappropriately, correct? Maybe move toolchains into
>> maven-shared-utils or make it something standalone @shared? We can
>> deprecate toolchains in maven-core 3.4 easily and move it somewhere else.
>>
>> Regards,
>>
>
>
> I think the idea to make a separate shared component
> maven-shared-toolchains ...and deprecated it in Maven Core...putting
> into maven-shared-utils sounds wrong...
>
> Kind regards
> Karl Heinz Marbaise
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven color status
Posted by Karl Heinz Marbaise <kh...@gmx.de>.
Hi,
On 7/4/16 6:52 PM, Christian Schulte wrote:
> Am 07/04/16 um 16:57 schrieb Herv� BOUTEMY:
>> Hi,
>>
>> To me, color is now feature complete: configuration has been added in r1751085
>> (thanks S�bastian), for those wanting to customize their own personal color
>> scheme.
>>
>> There is now only one issue: where to put the code?
>> It is currently in maven-shared-utils, but maven-shared-utils depends on
>> maven-core (for toolchains): see MSHARED-567
>>
>> Should we remove the dependency? Should we move the code to another place?
>
> We have
>
> maven-model
> maven-model-builder
> maven-settings
> maven-settings-builder
>
> Would
>
> maven-toolchains
> maven-toolchains-builder
>
> or something like this solve the issue or would it be the same as
> depending on maven-core? So the issue is that toolchains is located
> somewhere inappropriately, correct? Maybe move toolchains into
> maven-shared-utils or make it something standalone @shared? We can
> deprecate toolchains in maven-core 3.4 easily and move it somewhere else.
>
> Regards,
>
I think the idea to make a separate shared component
maven-shared-toolchains ...and deprecated it in Maven Core...putting
into maven-shared-utils sounds wrong...
Kind regards
Karl Heinz Marbaise
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Maven color status
Posted by Christian Schulte <cs...@schulte.it>.
Am 07/04/16 um 16:57 schrieb Herv BOUTEMY:
> Hi,
>
> To me, color is now feature complete: configuration has been added in r1751085
> (thanks Sbastian), for those wanting to customize their own personal color
> scheme.
>
> There is now only one issue: where to put the code?
> It is currently in maven-shared-utils, but maven-shared-utils depends on
> maven-core (for toolchains): see MSHARED-567
>
> Should we remove the dependency? Should we move the code to another place?
We have
maven-model
maven-model-builder
maven-settings
maven-settings-builder
Would
maven-toolchains
maven-toolchains-builder
or something like this solve the issue or would it be the same as
depending on maven-core? So the issue is that toolchains is located
somewhere inappropriately, correct? Maybe move toolchains into
maven-shared-utils or make it something standalone @shared? We can
deprecate toolchains in maven-core 3.4 easily and move it somewhere else.
Regards,
--
Christian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org