You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Sahil Takiar (Code Review)" <ge...@cloudera.org> on 2020/07/09 01:25:14 UTC

[Impala-ASF-CR] IMPALA-5534: Fix and enable experimental failure tests 

Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16157


Change subject: IMPALA-5534: Fix and enable experimental failure tests
......................................................................

IMPALA-5534: Fix and enable experimental failure tests

Moves the test_catalog_hms_failures.py and test_process_failures.py from
the experimental tests to custom cluster tests.
catalog_service/test_hms_failure.py is combined with
custom_cluster/test_catalog_hms_failure.py as well in order to unify all
tests for HMS failures. Several modifications to the tests were
necessary to get them working again, but for the most part, the logic of
the tests remained the same. A few additional fault tolerance tests
(e.g. TestHiveMetaStoreFailure::test_hms_client_retries) were added as
well. The overall goal is to increase the process failure test coverage
for all components: impalads, statestore, catalogd, HMS, etc.

test_restart_catalogd in test_process_failures.py fails due to
IMPALA-9848, so it is skipped for now.

Testing:
* Ran new tests locally

Change-Id: I9dbb98017fb6c40cea349e7c63a35c325cbbc288
---
M fe/src/main/java/org/apache/impala/service/Frontend.java
D tests/catalog_service/test_hms_failure.py
M tests/common/impala_service.py
A tests/custom_cluster/test_catalog_hms_failures.py
A tests/custom_cluster/test_process_failures.py
D tests/experiments/test_catalog_hms_failures.py
D tests/experiments/test_process_failures.py
7 files changed, 485 insertions(+), 466 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/16157/1
-- 
To view, visit http://gerrit.cloudera.org:8080/16157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9dbb98017fb6c40cea349e7c63a35c325cbbc288
Gerrit-Change-Number: 16157
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>

[Impala-ASF-CR] IMPALA-5534: Fix and enable experimental failure tests

Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Hello Thomas Tauber-Marshall, Vihang Karajgaonkar, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16157

to look at the new patch set (#4).

Change subject: IMPALA-5534: Fix and enable experimental failure tests
......................................................................

IMPALA-5534: Fix and enable experimental failure tests

Moves the test_catalog_hms_failures.py and test_process_failures.py from
the experimental tests to custom cluster tests.
catalog_service/test_hms_failure.py is combined with
custom_cluster/test_catalog_hms_failure.py as well in order to unify all
tests for HMS failures. Several modifications to the tests were
necessary to get them working again, but for the most part, the logic of
the tests remained the same. A few additional fault tolerance tests
(e.g. TestHiveMetaStoreFailure::test_hms_client_retries) were added as
well. The overall goal is to increase the process failure test coverage
for all components: impalads, statestore, catalogd, HMS, etc.

test_restart_catalogd in test_process_failures.py fails due to
IMPALA-9848, so it is skipped for now.

Testing:
* Ran new tests locally

Change-Id: I9dbb98017fb6c40cea349e7c63a35c325cbbc288
---
M fe/src/main/java/org/apache/impala/service/Frontend.java
D tests/catalog_service/test_hms_failure.py
M tests/common/impala_service.py
A tests/custom_cluster/test_catalog_hms_failures.py
A tests/custom_cluster/test_process_failures.py
D tests/experiments/test_catalog_hms_failures.py
D tests/experiments/test_process_failures.py
7 files changed, 485 insertions(+), 466 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/16157/4
-- 
To view, visit http://gerrit.cloudera.org:8080/16157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9dbb98017fb6c40cea349e7c63a35c325cbbc288
Gerrit-Change-Number: 16157
Gerrit-PatchSet: 4
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>

[Impala-ASF-CR] IMPALA-5534: Fix and enable experimental failure tests

Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16157 )

Change subject: IMPALA-5534: Fix and enable experimental failure tests
......................................................................


Patch Set 3: Code-Review+2

Carrying +2.


-- 
To view, visit http://gerrit.cloudera.org:8080/16157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbb98017fb6c40cea349e7c63a35c325cbbc288
Gerrit-Change-Number: 16157
Gerrit-PatchSet: 3
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Jul 2020 18:46:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5534: Fix and enable experimental failure tests

Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16157 )

Change subject: IMPALA-5534: Fix and enable experimental failure tests
......................................................................


Patch Set 4: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/16157/3/tests/custom_cluster/test_catalog_hms_failures.py
File tests/custom_cluster/test_catalog_hms_failures.py:

http://gerrit.cloudera.org:8080/#/c/16157/3/tests/custom_cluster/test_catalog_hms_failures.py@136
PS3, Line 136: e
> flake8: E722 do not use bare except'
Done


http://gerrit.cloudera.org:8080/#/c/16157/3/tests/custom_cluster/test_catalog_hms_failures.py@140
PS3, Line 140: e
> flake8: E722 do not use bare except'
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/16157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbb98017fb6c40cea349e7c63a35c325cbbc288
Gerrit-Change-Number: 16157
Gerrit-PatchSet: 4
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Jul 2020 18:50:59 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5534: Fix and enable experimental failure tests

Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16157

to look at the new patch set (#2).

Change subject: IMPALA-5534: Fix and enable experimental failure tests
......................................................................

IMPALA-5534: Fix and enable experimental failure tests

Moves the test_catalog_hms_failures.py and test_process_failures.py from
the experimental tests to custom cluster tests.
catalog_service/test_hms_failure.py is combined with
custom_cluster/test_catalog_hms_failure.py as well in order to unify all
tests for HMS failures. Several modifications to the tests were
necessary to get them working again, but for the most part, the logic of
the tests remained the same. A few additional fault tolerance tests
(e.g. TestHiveMetaStoreFailure::test_hms_client_retries) were added as
well. The overall goal is to increase the process failure test coverage
for all components: impalads, statestore, catalogd, HMS, etc.

test_restart_catalogd in test_process_failures.py fails due to
IMPALA-9848, so it is skipped for now.

Testing:
* Ran new tests locally

Change-Id: I9dbb98017fb6c40cea349e7c63a35c325cbbc288
---
M fe/src/main/java/org/apache/impala/service/Frontend.java
D tests/catalog_service/test_hms_failure.py
M tests/common/impala_service.py
A tests/custom_cluster/test_catalog_hms_failures.py
A tests/custom_cluster/test_process_failures.py
D tests/experiments/test_catalog_hms_failures.py
D tests/experiments/test_process_failures.py
7 files changed, 485 insertions(+), 466 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/16157/2
-- 
To view, visit http://gerrit.cloudera.org:8080/16157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9dbb98017fb6c40cea349e7c63a35c325cbbc288
Gerrit-Change-Number: 16157
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-5534: Fix and enable experimental failure tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16157 )

Change subject: IMPALA-5534: Fix and enable experimental failure tests
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6536/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/16157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbb98017fb6c40cea349e7c63a35c325cbbc288
Gerrit-Change-Number: 16157
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Jul 2020 03:02:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5534: Fix and enable experimental failure tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16157 )

Change subject: IMPALA-5534: Fix and enable experimental failure tests
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6122/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/16157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbb98017fb6c40cea349e7c63a35c325cbbc288
Gerrit-Change-Number: 16157
Gerrit-PatchSet: 3
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Jul 2020 18:46:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5534: Fix and enable experimental failure tests

Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16157 )

Change subject: IMPALA-5534: Fix and enable experimental failure tests
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/16157/2/tests/custom_cluster/test_catalog_hms_failures.py
File tests/custom_cluster/test_catalog_hms_failures.py:

http://gerrit.cloudera.org:8080/#/c/16157/2/tests/custom_cluster/test_catalog_hms_failures.py@17
PS2, Line 17: import pytest
> nit, May be move this line to the python way of documentation on line 36 as
Done


http://gerrit.cloudera.org:8080/#/c/16157/2/tests/custom_cluster/test_process_failures.py
File tests/custom_cluster/test_process_failures.py:

http://gerrit.cloudera.org:8080/#/c/16157/2/tests/custom_cluster/test_process_failures.py@143
PS2, Line 143: IMPALA-9848
> Thanks for writing a test case and creating a JIRA for this. I will try to 
Sounds good thanks. I think Anurag has been looking into this as well.



-- 
To view, visit http://gerrit.cloudera.org:8080/16157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbb98017fb6c40cea349e7c63a35c325cbbc288
Gerrit-Change-Number: 16157
Gerrit-PatchSet: 3
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Jul 2020 18:46:30 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5534: Fix and enable experimental failure tests

Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16157 )

Change subject: IMPALA-5534: Fix and enable experimental failure tests
......................................................................


Patch Set 2: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/16157/2/tests/custom_cluster/test_catalog_hms_failures.py
File tests/custom_cluster/test_catalog_hms_failures.py:

http://gerrit.cloudera.org:8080/#/c/16157/2/tests/custom_cluster/test_catalog_hms_failures.py@17
PS2, Line 17: # Tests to validate the Catalog Service continues to function even if the HMS fails.
nit, May be move this line to the python way of documentation on line 36 as well?


http://gerrit.cloudera.org:8080/#/c/16157/2/tests/custom_cluster/test_process_failures.py
File tests/custom_cluster/test_process_failures.py:

http://gerrit.cloudera.org:8080/#/c/16157/2/tests/custom_cluster/test_process_failures.py@143
PS2, Line 143: IMPALA-9848
Thanks for writing a test case and creating a JIRA for this. I will try to look into whats happening there.



-- 
To view, visit http://gerrit.cloudera.org:8080/16157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbb98017fb6c40cea349e7c63a35c325cbbc288
Gerrit-Change-Number: 16157
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Jul 2020 17:48:55 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5534: Fix and enable experimental failure tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16157 )

Change subject: IMPALA-5534: Fix and enable experimental failure tests
......................................................................

IMPALA-5534: Fix and enable experimental failure tests

Moves the test_catalog_hms_failures.py and test_process_failures.py from
the experimental tests to custom cluster tests.
catalog_service/test_hms_failure.py is combined with
custom_cluster/test_catalog_hms_failure.py as well in order to unify all
tests for HMS failures. Several modifications to the tests were
necessary to get them working again, but for the most part, the logic of
the tests remained the same. A few additional fault tolerance tests
(e.g. TestHiveMetaStoreFailure::test_hms_client_retries) were added as
well. The overall goal is to increase the process failure test coverage
for all components: impalads, statestore, catalogd, HMS, etc.

test_restart_catalogd in test_process_failures.py fails due to
IMPALA-9848, so it is skipped for now.

Testing:
* Ran new tests locally

Change-Id: I9dbb98017fb6c40cea349e7c63a35c325cbbc288
Reviewed-on: http://gerrit.cloudera.org:8080/16157
Reviewed-by: Sahil Takiar <st...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/service/Frontend.java
D tests/catalog_service/test_hms_failure.py
M tests/common/impala_service.py
A tests/custom_cluster/test_catalog_hms_failures.py
A tests/custom_cluster/test_process_failures.py
D tests/experiments/test_catalog_hms_failures.py
D tests/experiments/test_process_failures.py
7 files changed, 485 insertions(+), 466 deletions(-)

Approvals:
  Sahil Takiar: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/16157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9dbb98017fb6c40cea349e7c63a35c325cbbc288
Gerrit-Change-Number: 16157
Gerrit-PatchSet: 5
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>

[Impala-ASF-CR] IMPALA-5534: Fix and enable experimental failure tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16157 )

Change subject: IMPALA-5534: Fix and enable experimental failure tests
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6578/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/16157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbb98017fb6c40cea349e7c63a35c325cbbc288
Gerrit-Change-Number: 16157
Gerrit-PatchSet: 3
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Jul 2020 19:07:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5534: Fix and enable experimental failure tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16157 )

Change subject: IMPALA-5534: Fix and enable experimental failure tests
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/16157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbb98017fb6c40cea349e7c63a35c325cbbc288
Gerrit-Change-Number: 16157
Gerrit-PatchSet: 4
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jul 2020 00:03:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5534: Fix and enable experimental failure tests

Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Hello Thomas Tauber-Marshall, Vihang Karajgaonkar, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16157

to look at the new patch set (#3).

Change subject: IMPALA-5534: Fix and enable experimental failure tests
......................................................................

IMPALA-5534: Fix and enable experimental failure tests

Moves the test_catalog_hms_failures.py and test_process_failures.py from
the experimental tests to custom cluster tests.
catalog_service/test_hms_failure.py is combined with
custom_cluster/test_catalog_hms_failure.py as well in order to unify all
tests for HMS failures. Several modifications to the tests were
necessary to get them working again, but for the most part, the logic of
the tests remained the same. A few additional fault tolerance tests
(e.g. TestHiveMetaStoreFailure::test_hms_client_retries) were added as
well. The overall goal is to increase the process failure test coverage
for all components: impalads, statestore, catalogd, HMS, etc.

test_restart_catalogd in test_process_failures.py fails due to
IMPALA-9848, so it is skipped for now.

Testing:
* Ran new tests locally

Change-Id: I9dbb98017fb6c40cea349e7c63a35c325cbbc288
---
M fe/src/main/java/org/apache/impala/service/Frontend.java
D tests/catalog_service/test_hms_failure.py
M tests/common/impala_service.py
A tests/custom_cluster/test_catalog_hms_failures.py
A tests/custom_cluster/test_process_failures.py
D tests/experiments/test_catalog_hms_failures.py
D tests/experiments/test_process_failures.py
7 files changed, 485 insertions(+), 466 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/16157/3
-- 
To view, visit http://gerrit.cloudera.org:8080/16157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9dbb98017fb6c40cea349e7c63a35c325cbbc288
Gerrit-Change-Number: 16157
Gerrit-PatchSet: 3
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>

[Impala-ASF-CR] IMPALA-5534: Fix and enable experimental failure tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16157 )

Change subject: IMPALA-5534: Fix and enable experimental failure tests
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/16157/1/tests/custom_cluster/test_catalog_hms_failures.py
File tests/custom_cluster/test_catalog_hms_failures.py:

http://gerrit.cloudera.org:8080/#/c/16157/1/tests/custom_cluster/test_catalog_hms_failures.py@136
PS1, Line 136: e
flake8: E722 do not use bare except'


http://gerrit.cloudera.org:8080/#/c/16157/1/tests/custom_cluster/test_catalog_hms_failures.py@140
PS1, Line 140: e
flake8: E722 do not use bare except'



-- 
To view, visit http://gerrit.cloudera.org:8080/16157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbb98017fb6c40cea349e7c63a35c325cbbc288
Gerrit-Change-Number: 16157
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Jul 2020 01:26:13 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5534: Fix and enable experimental failure tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16157 )

Change subject: IMPALA-5534: Fix and enable experimental failure tests
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6535/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/16157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbb98017fb6c40cea349e7c63a35c325cbbc288
Gerrit-Change-Number: 16157
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Jul 2020 01:52:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5534: Fix and enable experimental failure tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16157 )

Change subject: IMPALA-5534: Fix and enable experimental failure tests
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6580/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/16157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbb98017fb6c40cea349e7c63a35c325cbbc288
Gerrit-Change-Number: 16157
Gerrit-PatchSet: 4
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Jul 2020 19:30:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5534: Fix and enable experimental failure tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16157 )

Change subject: IMPALA-5534: Fix and enable experimental failure tests
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6124/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/16157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbb98017fb6c40cea349e7c63a35c325cbbc288
Gerrit-Change-Number: 16157
Gerrit-PatchSet: 4
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Jul 2020 18:51:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5534: Fix and enable experimental failure tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16157 )

Change subject: IMPALA-5534: Fix and enable experimental failure tests
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/16157/3/tests/custom_cluster/test_catalog_hms_failures.py
File tests/custom_cluster/test_catalog_hms_failures.py:

http://gerrit.cloudera.org:8080/#/c/16157/3/tests/custom_cluster/test_catalog_hms_failures.py@136
PS3, Line 136: e
flake8: E722 do not use bare except'


http://gerrit.cloudera.org:8080/#/c/16157/3/tests/custom_cluster/test_catalog_hms_failures.py@140
PS3, Line 140: e
flake8: E722 do not use bare except'



-- 
To view, visit http://gerrit.cloudera.org:8080/16157
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9dbb98017fb6c40cea349e7c63a35c325cbbc288
Gerrit-Change-Number: 16157
Gerrit-PatchSet: 3
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Jul 2020 18:47:25 +0000
Gerrit-HasComments: Yes