You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by PommeVerte <gi...@git.apache.org> on 2015/09/30 11:05:23 UTC

[GitHub] incubator-tinkerpop pull request: Made correction to fix TINKERPOP...

GitHub user PommeVerte opened a pull request:

    https://github.com/apache/incubator-tinkerpop/pull/98

    Made correction to fix TINKERPOP3-855.

    This fixes the issue with Json submitted sasl arguments not being in `byte[]` format.
    It is not BC breaking. Tests seem to pass though I wouldn't mind confirmation here.
    
    I also added changes to the documentation to reflect the new functionality.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/PommeVerte/incubator-tinkerpop TINKERPOP3-855-json-auth

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tinkerpop/pull/98.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #98
    
----
commit 39cb42ddde538a33bd7b3b3a0b27428aae2a2276
Author: Dylan Millikin <dy...@brightzone.fr>
Date:   2015-09-30T08:52:56Z

    Made correction to fix TINKERPOP3-855. Added Test and changed documentation.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: Made correction to fix TINKERPOP...

Posted by PommeVerte <gi...@git.apache.org>.
Github user PommeVerte commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/98#issuecomment-144334190
  
    It's worth going through the issue as I've made an arbitrary decision on the JSON input type and this needs to be reviewed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: Made correction to fix TINKERPOP...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-tinkerpop/pull/98


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---