You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/04 13:40:10 UTC
[GitHub] [flink] JingGe opened a new pull request, #21241: [hotfix][doc] add `INTERVAL` subtraction into the example and update the related description
JingGe opened a new pull request, #21241:
URL: https://github.com/apache/flink/pull/21241
## What is the purpose of the change
update example code and description of event time temporal join.
## Brief change log
- add `INTERVAL` subtraction into the example code
- update the description
## Verifying this change
This change is a trivial doc update without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #21241: [hotfix][doc] add `INTERVAL` subtraction into the example and update the related description
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21241:
URL: https://github.com/apache/flink/pull/21241#issuecomment-1303558976
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "35c07559bc639f4fa30169c96da649148c19709c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "35c07559bc639f4fa30169c96da649148c19709c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 35c07559bc639f4fa30169c96da649148c19709c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] leonardBang commented on a diff in pull request #21241: [hotfix][doc] add `INTERVAL` subtraction into the example and update the related description
Posted by GitBox <gi...@apache.org>.
leonardBang commented on code in PR #21241:
URL: https://github.com/apache/flink/pull/21241#discussion_r1014556699
##########
docs/content/docs/dev/table/sql/queries/joins.md:
##########
@@ -154,7 +154,7 @@ CREATE TABLE currency_rates (
currency STRING,
conversion_rate DECIMAL(32, 2),
update_time TIMESTAMP(3) METADATA FROM `values.source.timestamp` VIRTUAL,
- WATERMARK FOR update_time AS update_time,
+ WATERMARK FOR update_time AS update_time - INTERVAL '15' SECONDS,
Review Comment:
```suggestion
WATERMARK FOR update_time AS update_time - INTERVAL '15' SECOND,
```
##########
docs/content/docs/dev/table/sql/queries/joins.md:
##########
@@ -143,7 +143,7 @@ CREATE TABLE orders (
price DECIMAL(32,2),
currency STRING,
order_time TIMESTAMP(3),
- WATERMARK FOR order_time AS order_time
+ WATERMARK FOR order_time AS order_time - INTERVAL '15' SECONDS
Review Comment:
```suggestion
WATERMARK FOR order_time AS order_time - INTERVAL '15' SECOND
```
##########
docs/content.zh/docs/dev/table/sql/queries/joins.md:
##########
@@ -143,7 +143,7 @@ CREATE TABLE orders (
price DECIMAL(32,2),
currency STRING,
order_time TIMESTAMP(3),
- WATERMARK FOR order_time AS order_time
+ WATERMARK FOR order_time AS order_time - INTERVAL '15' SECONDS
Review Comment:
```suggestion
WATERMARK FOR order_time AS order_time - INTERVAL '15' SECOND
```
##########
docs/content.zh/docs/dev/table/sql/queries/joins.md:
##########
@@ -154,7 +154,7 @@ CREATE TABLE currency_rates (
currency STRING,
conversion_rate DECIMAL(32, 2),
update_time TIMESTAMP(3) METADATA FROM `values.source.timestamp` VIRTUAL,
- WATERMARK FOR update_time AS update_time,
+ WATERMARK FOR update_time AS update_time - INTERVAL '15' SECONDS,
Review Comment:
```suggestion
WATERMARK FOR update_time AS update_time - INTERVAL '15' SECOND,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] leonardBang merged pull request #21241: [hotfix][doc] add `INTERVAL` subtraction into the example and update the related description
Posted by GitBox <gi...@apache.org>.
leonardBang merged PR #21241:
URL: https://github.com/apache/flink/pull/21241
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org