You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/19 15:22:05 UTC
[GitHub] [spark] MrDLontheway opened a new pull request #27961:
[SPARK-31193][CORE] set spark.master and spark.app.name conf default value
MrDLontheway opened a new pull request #27961: [SPARK-31193][CORE] set spark.master and spark.app.name conf default value
URL: https://github.com/apache/spark/pull/27961
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
set spark.master and spark.app.name default config
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Optimize the development process
### Does this PR introduce any user-facing change?
no
### How was this patch tested?
do not set config test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27961:
[SPARK-31193][CORE] set spark.master and spark.app.name conf default value
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27961: [SPARK-31193][CORE] set spark.master and spark.app.name conf default value
URL: https://github.com/apache/spark/pull/27961#issuecomment-601545192
Thank you for making a PR, @MrDLontheway . However, could you close this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27961:
[SPARK-31193][CORE] set spark.master and spark.app.name conf default value
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27961: [SPARK-31193][CORE] set spark.master and spark.app.name conf default value
URL: https://github.com/apache/spark/pull/27961#issuecomment-601547225
Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MrDLontheway closed pull request #27961:
[SPARK-31193][CORE] set spark.master and spark.app.name conf default value
Posted by GitBox <gi...@apache.org>.
MrDLontheway closed pull request #27961: [SPARK-31193][CORE] set spark.master and spark.app.name conf default value
URL: https://github.com/apache/spark/pull/27961
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MrDLontheway commented on issue #27961: [SPARK-31193][CORE]
set spark.master and spark.app.name conf default value
Posted by GitBox <gi...@apache.org>.
MrDLontheway commented on issue #27961: [SPARK-31193][CORE] set spark.master and spark.app.name conf default value
URL: https://github.com/apache/spark/pull/27961#issuecomment-601269748
> Your code shouldn't set a master; it should be set when you submit your code. It does have to be set, and already defaults in the submit client code, yes. I don't think we should duplicate the logic.
> If you did for some reason want to do this directly, yes, you have to set a master.
In most cases, we will choose to submit to the cluster after the local debugging is completed, but because we manually set the master in the code, the attribute of the submit client will be overwritten during the submission process. because the local development process is separate from the submit, why not assigning default values when Context initialization?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27961:
[SPARK-31193][CORE] set spark.master and spark.app.name conf default value
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27961: [SPARK-31193][CORE] set spark.master and spark.app.name conf default value
URL: https://github.com/apache/spark/pull/27961#issuecomment-601243228
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on issue #27961: [SPARK-31193][CORE] set
spark.master and spark.app.name conf default value
Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27961: [SPARK-31193][CORE] set spark.master and spark.app.name conf default value
URL: https://github.com/apache/spark/pull/27961#issuecomment-601460494
> Simply do not set it in your code? That is the intended usage here.
Yea, I think so, too...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27961:
[SPARK-31193][CORE] set spark.master and spark.app.name conf default value
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27961: [SPARK-31193][CORE] set spark.master and spark.app.name conf default value
URL: https://github.com/apache/spark/pull/27961#issuecomment-601243871
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on issue #27961: [SPARK-31193][CORE] set
spark.master and spark.app.name conf default value
Posted by GitBox <gi...@apache.org>.
srowen commented on issue #27961: [SPARK-31193][CORE] set spark.master and spark.app.name conf default value
URL: https://github.com/apache/spark/pull/27961#issuecomment-601271998
Simply do not set it in your code? That is the intended usage here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on issue #27961: [SPARK-31193][CORE] set
spark.master and spark.app.name conf default value
Posted by GitBox <gi...@apache.org>.
srowen commented on issue #27961: [SPARK-31193][CORE] set spark.master and spark.app.name conf default value
URL: https://github.com/apache/spark/pull/27961#issuecomment-601259352
Your code shouldn't set a master; it should be set when you submit your code. It does have to be set, and already defaults in the submit client code, yes. I don't think we should duplicate the logic.
If you did for some reason want to do this directly, yes, you have to set a master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27961:
[SPARK-31193][CORE] set spark.master and spark.app.name conf default value
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27961: [SPARK-31193][CORE] set spark.master and spark.app.name conf default value
URL: https://github.com/apache/spark/pull/27961#issuecomment-601243228
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MrDLontheway commented on issue #27961: [SPARK-31193][CORE]
set spark.master and spark.app.name conf default value
Posted by GitBox <gi...@apache.org>.
MrDLontheway commented on issue #27961: [SPARK-31193][CORE] set spark.master and spark.app.name conf default value
URL: https://github.com/apache/spark/pull/27961#issuecomment-601251302
cc @maropu @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MrDLontheway commented on issue #27961: [SPARK-31193][CORE]
set spark.master and spark.app.name conf default value
Posted by GitBox <gi...@apache.org>.
MrDLontheway commented on issue #27961: [SPARK-31193][CORE] set spark.master and spark.app.name conf default value
URL: https://github.com/apache/spark/pull/27961#issuecomment-601545628
ok thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org