You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by mm...@apache.org on 2018/05/01 16:34:56 UTC
[incubator-pulsar] branch master updated: Fix Trigger functionality
for non Java Functions (#1701)
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 2dd158e Fix Trigger functionality for non Java Functions (#1701)
2dd158e is described below
commit 2dd158e9514b89ec545169f4fd8fa863f9c099de
Author: Sanjeev Kulkarni <sa...@gmail.com>
AuthorDate: Tue May 1 09:34:53 2018 -0700
Fix Trigger functionality for non Java Functions (#1701)
---
.../apache/pulsar/functions/worker/rest/api/FunctionsImpl.java | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/FunctionsImpl.java b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/FunctionsImpl.java
index 513443e..49c652f 100644
--- a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/FunctionsImpl.java
+++ b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/FunctionsImpl.java
@@ -480,10 +480,6 @@ public class FunctionsImpl {
FunctionMetaData functionMetaData = functionMetaDataManager.getFunctionMetaData(tenant, namespace, functionName);
String inputTopicToWrite;
- // only if the source is PulsarSource and if the function consumes only one topic
- if (!functionMetaData.getFunctionDetails().getSource().getClassName().equals(PulsarSource.class.getName())) {
- return Response.status(Status.BAD_REQUEST).build();
- }
if (topic != null) {
inputTopicToWrite = topic;
} else if (functionMetaData.getFunctionDetails().getSource().getTopicsToSerDeClassNameMap().size() == 1) {
@@ -492,6 +488,10 @@ public class FunctionsImpl {
} else {
return Response.status(Status.BAD_REQUEST).build();
}
+ if (functionMetaData.getFunctionDetails().getSource().getTopicsToSerDeClassNameMap() == null
+ || !functionMetaData.getFunctionDetails().getSource().getTopicsToSerDeClassNameMap().containsKey(inputTopicToWrite)) {
+ return Response.status(Status.BAD_REQUEST).build();
+ }
String outputTopic = functionMetaData.getFunctionDetails().getSink().getTopic();
Reader reader = null;
Producer producer = null;
--
To stop receiving notification emails like this one, please contact
mmerli@apache.org.