[GitHub] wido commented on a change in pull request #3197: Fix XenServer Security Groups 'vmops' script

[GitBox <gi...@apache.org>]

wido commented on a change in pull request #3197: Fix XenServer Security Groups 'vmops' script
URL: https://github.com/apache/cloudstack/pull/3197#discussion_r261101107
 
 

 ##########
 File path: scripts/vm/hypervisor/xenserver/vmops
 ##########
 @@ -1517,7 +1550,8 @@ def network_rules(session, args):
 
     return 'true'
   except:
-    logging.debug("Failed to network rule !")
+    e = sys.exc_info()[0]
+    logging.error("Failed to network rule. Error: %s" % e)
 
 Review comment:
   Might want to use logging.exception here as you catch an Exception.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services