[GitHub] [activemq-artemis] gtully commented on pull request #4484: ARTEMIS-4285 Disable persistent redelivery on new brokers

["gtully (via GitHub)" <gi...@apache.org>]

gtully commented on PR #4484:
URL: https://github.com/apache/activemq-artemis/pull/4484#issuecomment-1554269382

   there may be a middle ground here. in 5.x the feature is around depending on the redeliveryFlag, or jms.isRedelivered which is set if redeliveryCount > 0
   the persisting is only done on the transition from 0->1 rather than on each increment. This is sufficient for the flag, if the redelivery flag is false, then you know this is the first dispatch, otherwise you may need to check for duplicates.
   There may be some value in supporting the redelivery flag being persisted, but not persisting every redelivery to keep the count up to date.
   see: https://github.com/apache/activemq/blob/cfbea60d6d4f934e7fbe85915183a2f211414b82/activemq-broker/src/main/java/org/apache/activemq/broker/region/RegionBroker.java#L637
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org