You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Alessandro Benedetti (Jira)" <ji...@apache.org> on 2019/10/03 14:21:00 UTC
[jira] [Commented] (SOLR-11155) /analysis/field and
/analysis/document requests should support points fields
[ https://issues.apache.org/jira/browse/SOLR-11155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16943631#comment-16943631 ]
Alessandro Benedetti commented on SOLR-11155:
---------------------------------------------
{code:java}
/** Given the readable value, return the term value that will match it. */
public String readableToIndexed(String val) {
return toInternal(val);
}
{code}
In case of PointField this will fail, inviting to use the toInternalByteRef, shouldn't this be fixed as well?
> /analysis/field and /analysis/document requests should support points fields
> ----------------------------------------------------------------------------
>
> Key: SOLR-11155
> URL: https://issues.apache.org/jira/browse/SOLR-11155
> Project: Solr
> Issue Type: Bug
> Reporter: Steven Rowe
> Assignee: Steven Rowe
> Priority: Blocker
> Labels: numeric-tries-to-points
> Fix For: 7.0, 7.1, 8.0
>
> Attachments: SOLR-11155.patch, SOLR-11155.patch, SOLR-11155.patch
>
>
> The following added to FieldAnalysisRequestHandlerTest currently fails:
> {code:java}
> @Test
> public void testIntPoint() throws Exception {
> FieldAnalysisRequest request = new FieldAnalysisRequest();
> request.addFieldType("pint");
> request.setFieldValue("5");
> handler.handleAnalysisRequest(request, h.getCore().getLatestSchema());
> }
> {code}
> as follows:
> {noformat}
> [junit4] 2> NOTE: reproduce with: ant test -Dtestcase=FieldAnalysisRequestHandlerTest -Dtests.method=testIntPoint -Dtests.seed=167CC259812871FB -Dtests.slow=true -Dtests.locale=fi-FI -Dtests.timezone=Asia/Hebron -Dtests.asserts=true -Dtests.file.encoding=US-ASCII
> [junit4] ERROR 0.01s | FieldAnalysisRequestHandlerTest.testIntPoint <<<
> [junit4] > Throwable #1: java.lang.UnsupportedOperationException: Can't generate internal string in PointField. use PointField.toInternalByteRef
> [junit4] > at __randomizedtesting.SeedInfo.seed([167CC259812871FB:6BF651CEF8FF5B04]:0)
> [junit4] > at org.apache.solr.schema.PointField.toInternal(PointField.java:187)
> [junit4] > at org.apache.solr.schema.FieldType$DefaultAnalyzer$1.incrementToken(FieldType.java:488)
> [junit4] > at org.apache.solr.handler.AnalysisRequestHandlerBase.analyzeTokenStream(AnalysisRequestHandlerBase.java:188)
> [junit4] > at org.apache.solr.handler.AnalysisRequestHandlerBase.analyzeValue(AnalysisRequestHandlerBase.java:102)
> [junit4] > at org.apache.solr.handler.FieldAnalysisRequestHandler.analyzeValues(FieldAnalysisRequestHandler.java:225)
> [junit4] > at org.apache.solr.handler.FieldAnalysisRequestHandler.handleAnalysisRequest(FieldAnalysisRequestHandler.java:186)
> [junit4] > at org.apache.solr.handler.FieldAnalysisRequestHandlerTest.testIntPoint(FieldAnalysisRequestHandlerTest.java:435)
> {noformat}
> If points fields aren't supported by the FieldAnalysisRequestHandler, then this should be directly stated in the error message, which should be a 4XX error rather than a 5XX error.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org