You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by ba...@apache.org on 2024/04/27 12:54:58 UTC
(pulsar) branch branch-3.0 updated: [fix][test] Flaky-test: ManagedLedgerTest.testTimestampOnWorkingLedger (#22600)
This is an automated email from the ASF dual-hosted git repository.
baodi pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/branch-3.0 by this push:
new de7f05175d6 [fix][test] Flaky-test: ManagedLedgerTest.testTimestampOnWorkingLedger (#22600)
de7f05175d6 is described below
commit de7f05175d607706b731eab2ef35436e888ca23a
Author: Baodi Shi <ba...@apache.org>
AuthorDate: Sat Apr 27 19:16:31 2024 +0800
[fix][test] Flaky-test: ManagedLedgerTest.testTimestampOnWorkingLedger (#22600)
(cherry picked from commit 5d9ccd48520e0a0aa0aeb7c918f7b8ee6c866471)
---
.../bookkeeper/mledger/impl/ManagedLedgerTest.java | 25 +++++++++++-----------
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerTest.java b/managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerTest.java
index c16c31a7e96..7a34947a6b7 100644
--- a/managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerTest.java
+++ b/managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerTest.java
@@ -2445,7 +2445,7 @@ public class ManagedLedgerTest extends MockedBookKeeperTestCase {
});
}
- @Test(groups = "flaky")
+ @Test
public void testTimestampOnWorkingLedger() throws Exception {
ManagedLedgerConfig conf = new ManagedLedgerConfig();
conf.setMaxEntriesPerLedger(1);
@@ -2472,19 +2472,18 @@ public class ManagedLedgerTest extends MockedBookKeeperTestCase {
ml.addEntry("msg02".getBytes());
+ // reopen a new ml2
ml.close();
- // Thread.sleep(1000);
- iter = ml.getLedgersInfoAsList().iterator();
- ts = -1;
- while (iter.hasNext()) {
- LedgerInfo i = iter.next();
- if (iter.hasNext()) {
- assertTrue(ts <= i.getTimestamp(), i.toString());
- ts = i.getTimestamp();
- } else {
- assertTrue(i.getTimestamp() > 0, "well closed LedgerInfo should set a timestamp > 0");
- }
- }
+ ManagedLedgerImpl ml2 = (ManagedLedgerImpl) factory.open("my_test_ledger", conf);
+
+ List<LedgerInfo> ledgers = ml2.getLedgersInfoAsList();
+ // after reopen ledgers will be 2 + 1(new open, not contain any entries)
+ assertEquals(ledgers.size(), 3);
+
+ // the last closed ledger should be the penultimate one.
+ LedgerInfo lastClosedLeger = ledgers.get(ledgers.size() - 2);
+ assertTrue(lastClosedLeger.getTimestamp() > 0, "well closed LedgerInfo should set a timestamp > 0");
+ ml2.close();
}
@Test