You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2017/01/08 23:53:07 UTC
Review Request 55328: Windows: Added passing GC tests to the build.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55328/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
Bugs: MESOS-6707
https://issues.apache.org/jira/browse/MESOS-6707
Repository: mesos
Description
-------
This issue resolves MESOS-6707. See #55327 for the resolution that
allows us to light up the tests; essentially, we resolved a bug in the
Windows implementation of `os::rmdir` that causes the Agent sandbox
deletion to error out instead of completing successfully.
Diffs
-----
src/tests/gc_tests.cpp c4841e85f785189681e218df714cac2038d77803
Diff: https://reviews.apache.org/r/55328/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 55328: Windows: Added passing GC tests to the
build.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55328/#review162204
-----------------------------------------------------------
Ship it!
src/tests/gc_tests.cpp (lines 376 - 378)
<https://reviews.apache.org/r/55328/#comment233469>
Spacing here. I can fix this up.
- Joseph Wu
On Jan. 8, 2017, 3:53 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55328/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2017, 3:53 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
>
>
> Bugs: MESOS-6707
> https://issues.apache.org/jira/browse/MESOS-6707
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This issue resolves MESOS-6707. See #55327 for the resolution that
> allows us to light up the tests; essentially, we resolved a bug in the
> Windows implementation of `os::rmdir` that causes the Agent sandbox
> deletion to error out instead of completing successfully.
>
>
> Diffs
> -----
>
> src/tests/gc_tests.cpp c4841e85f785189681e218df714cac2038d77803
>
> Diff: https://reviews.apache.org/r/55328/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>