You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/01/18 06:51:40 UTC
[GitHub] [netbeans] mbien opened a new pull request #3472: Hint/Inspection panel and dialog layout fixes
mbien opened a new pull request #3472:
URL: https://github.com/apache/netbeans/pull/3472
- `source -> inspect` dialog did not resize properly
- `refactor -> inspect and refactor` dialog had no separation between row two and three (very similar dialog to the one above but uses a different layout manager :) )
- layout fixes to HintPanel as used in `options -> editor -> hints` or from various configuration dialogs
- description resizes now vertically, required updates to many customizer components so that they only take as much space as they need
- made dialogs which use the HintPanel a little larger
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #3472: Hint/Inspection panel and dialog layout fixes
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #3472:
URL: https://github.com/apache/netbeans/pull/3472#issuecomment-1016409372
@mbien thanks.
@matthiasblaesing yes, rebasing was more a turn of phrase around changing the PR base branch. Mind you, still prefer using git rebase for this task myself, but don't mind how anyone wants to clean up their PR unless they need help with it. Now, as long as we don't get cherry-picking from upstream master I'm happy ... :smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3472: Hint/Inspection panel and dialog layout fixes
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3472:
URL: https://github.com/apache/netbeans/pull/3472#issuecomment-1015700286
@neilcsmith-net done
@matthiasblaesing yeah that is correct. Although I did cherry pick to delivery, I still refer to it as "rebasing the two commits to delivery" myself - I probably shouldn't since it could be taken literally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net merged pull request #3472: Hint/Inspection panel and dialog layout fixes
Posted by GitBox <gi...@apache.org>.
neilcsmith-net merged pull request #3472:
URL: https://github.com/apache/netbeans/pull/3472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #3472: Hint/Inspection panel and dialog layout fixes
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #3472:
URL: https://github.com/apache/netbeans/pull/3472#issuecomment-1015304163
@mbien need to rebase on delivery if you want this in NB13 - picking up commits from master we don't want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #3472: Hint/Inspection panel and dialog layout fixes
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #3472:
URL: https://github.com/apache/netbeans/pull/3472#issuecomment-1015664350
In this case we don't want a rebase, but a cherry-pick. The difference is, that rebase will carry all commits from the base branch, that are not in the target branch, while cherry-picking only uses the referenced commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists