You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/08/23 00:31:10 UTC

[Impala-ASF-CR] IMPALA-8885: Improve Parquet version metadata error 

Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14126


Change subject: IMPALA-8885: Improve Parquet version metadata error
......................................................................

IMPALA-8885: Improve Parquet version metadata error

Update the error message to make it more obvious that
the error could occur by trying to parse a non-Parquet
file as Parquet

Updated tests that depended on the error test.

Change-Id: I2b36586dba14a31a613d79a0e28efc9a5173e75d
---
M common/thrift/generate_error_codes.py
M testdata/workloads/functional-query/queries/QueryTest/parquet-error-propagation-race.test
M testdata/workloads/functional-query/queries/QueryTest/parquet.test
M tests/metadata/test_stale_metadata.py
4 files changed, 11 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/14126/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14126
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2b36586dba14a31a613d79a0e28efc9a5173e75d
Gerrit-Change-Number: 14126
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-8885: Improve Parquet version metadata error

Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14126 )

Change subject: IMPALA-8885: Improve Parquet version metadata error
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14126
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b36586dba14a31a613d79a0e28efc9a5173e75d
Gerrit-Change-Number: 14126
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Aug 2019 20:22:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8885: Improve Parquet version metadata error

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14126 )

Change subject: IMPALA-8885: Improve Parquet version metadata error
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14126/1/tests/metadata/test_stale_metadata.py
File tests/metadata/test_stale_metadata.py:

http://gerrit.cloudera.org:8080/#/c/14126/1/tests/metadata/test_stale_metadata.py@94
PS1, Line 94: .
flake8: E501 line too long (93 > 90 characters)



-- 
To view, visit http://gerrit.cloudera.org:8080/14126
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b36586dba14a31a613d79a0e28efc9a5173e75d
Gerrit-Change-Number: 14126
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Aug 2019 00:32:01 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8885: Improve Parquet version metadata error

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14126 )

Change subject: IMPALA-8885: Improve Parquet version metadata error
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/14126
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b36586dba14a31a613d79a0e28efc9a5173e75d
Gerrit-Change-Number: 14126
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Aug 2019 04:39:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8885: Improve Parquet version metadata error

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14126 )

Change subject: IMPALA-8885: Improve Parquet version metadata error
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4835/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/14126
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b36586dba14a31a613d79a0e28efc9a5173e75d
Gerrit-Change-Number: 14126
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Aug 2019 00:31:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8885: Improve Parquet version metadata error

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14126 )

Change subject: IMPALA-8885: Improve Parquet version metadata error
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4838/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/14126
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b36586dba14a31a613d79a0e28efc9a5173e75d
Gerrit-Change-Number: 14126
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Aug 2019 20:26:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8885: Improve Parquet version metadata error

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14126

to look at the new patch set (#2).

Change subject: IMPALA-8885: Improve Parquet version metadata error
......................................................................

IMPALA-8885: Improve Parquet version metadata error

Update the error message to make it more obvious that
the error could occur by trying to parse a non-Parquet
file as Parquet

Updated tests that depended on the error test.

Change-Id: I2b36586dba14a31a613d79a0e28efc9a5173e75d
---
M common/thrift/generate_error_codes.py
M testdata/workloads/functional-query/queries/QueryTest/parquet-error-propagation-race.test
M testdata/workloads/functional-query/queries/QueryTest/parquet.test
M tests/metadata/test_stale_metadata.py
4 files changed, 12 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/14126/2
-- 
To view, visit http://gerrit.cloudera.org:8080/14126
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2b36586dba14a31a613d79a0e28efc9a5173e75d
Gerrit-Change-Number: 14126
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-8885: Improve Parquet version metadata error

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14126 )

Change subject: IMPALA-8885: Improve Parquet version metadata error
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/4340/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/14126
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b36586dba14a31a613d79a0e28efc9a5173e75d
Gerrit-Change-Number: 14126
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Aug 2019 01:18:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8885: Improve Parquet version metadata error

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14126 )

Change subject: IMPALA-8885: Improve Parquet version metadata error
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/14126
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b36586dba14a31a613d79a0e28efc9a5173e75d
Gerrit-Change-Number: 14126
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Sat, 24 Aug 2019 00:32:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8885: Improve Parquet version metadata error

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14126 )

Change subject: IMPALA-8885: Improve Parquet version metadata error
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/4339/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/14126
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b36586dba14a31a613d79a0e28efc9a5173e75d
Gerrit-Change-Number: 14126
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Aug 2019 01:11:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8885: Improve Parquet version metadata error

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14126 )

Change subject: IMPALA-8885: Improve Parquet version metadata error
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4837/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/14126
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b36586dba14a31a613d79a0e28efc9a5173e75d
Gerrit-Change-Number: 14126
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Aug 2019 20:25:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8885: Improve Parquet version metadata error

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14126 )

Change subject: IMPALA-8885: Improve Parquet version metadata error
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14126
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b36586dba14a31a613d79a0e28efc9a5173e75d
Gerrit-Change-Number: 14126
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Aug 2019 20:25:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8885: Improve Parquet version metadata error

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14126 )

Change subject: IMPALA-8885: Improve Parquet version metadata error
......................................................................

IMPALA-8885: Improve Parquet version metadata error

Update the error message to make it more obvious that
the error could occur by trying to parse a non-Parquet
file as Parquet

Updated tests that depended on the error test.

Change-Id: I2b36586dba14a31a613d79a0e28efc9a5173e75d
Reviewed-on: http://gerrit.cloudera.org:8080/14126
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M common/thrift/generate_error_codes.py
M testdata/workloads/functional-query/queries/QueryTest/parquet-error-propagation-race.test
M testdata/workloads/functional-query/queries/QueryTest/parquet.test
M tests/metadata/test_stale_metadata.py
4 files changed, 12 insertions(+), 8 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/14126
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2b36586dba14a31a613d79a0e28efc9a5173e75d
Gerrit-Change-Number: 14126
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>