You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Andrew Gaul <no...@github.com> on 2014/05/28 04:21:52 UTC
[jclouds] Remove BlobBuilder and Payloads.calculateMD5 (#381)
Callers should instead explicitly set contentMD5, usually with the
results from Guava Hashing.md5(). This narrows the API and removes a
strange IOException from callers. Further it removes a dangerous
rebuffering of arbitrarily-large non-repeatable Payloads.
You can merge this Pull Request by running:
git pull https://github.com/andrewgaul/jclouds remove-calculate-md5
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/381
-- Commit Summary --
* Remove BlobBuilder and Payloads.calculateMD5
-- File Changes --
M apis/atmos/src/test/java/org/jclouds/atmos/AtmosClientLiveTest.java (23)
M apis/filesystem/src/main/java/org/jclouds/filesystem/strategy/internal/FilesystemStorageStrategyImpl.java (5)
M apis/swift/src/test/java/org/jclouds/openstack/swift/CommonSwiftClientLiveTest.java (4)
M blobstore/src/main/clojure/org/jclouds/blobstore2.clj (12)
M blobstore/src/main/java/org/jclouds/blobstore/TransientStorageStrategy.java (10)
M blobstore/src/main/java/org/jclouds/blobstore/domain/BlobBuilder.java (9)
M blobstore/src/main/java/org/jclouds/blobstore/domain/internal/BlobBuilderImpl.java (10)
M blobstore/src/test/clojure/org/jclouds/blobstore2_test.clj (9)
M blobstore/src/test/java/org/jclouds/blobstore/TransientBlobRequestSignerTest.java (11)
M blobstore/src/test/java/org/jclouds/blobstore/integration/internal/BaseBlobIntegrationTest.java (7)
M blobstore/src/test/java/org/jclouds/blobstore/integration/internal/BaseContainerIntegrationTest.java (4)
M core/src/main/java/org/jclouds/io/Payloads.java (40)
M core/src/test/java/org/jclouds/rest/internal/RestAnnotationProcessorTest.java (26)
M providers/azureblob/src/test/java/org/jclouds/azureblob/AzureBlobClientLiveTest.java (4)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/381.patch
https://github.com/jclouds/jclouds/pull/381.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/381
Re: [jclouds] Remove BlobBuilder and Payloads.calculateMD5 (#381)
Posted by Andrew Gaul <no...@github.com>.
Closed #381.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/381#event-125726594
Re: [jclouds] Remove BlobBuilder and Payloads.calculateMD5 (#381)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #839](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/839/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/381#issuecomment-44369655
Re: [jclouds] Remove BlobBuilder and Payloads.calculateMD5 (#381)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1310](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1310/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/381#issuecomment-44370017
Re: [jclouds] Remove BlobBuilder and Payloads.calculateMD5 (#381)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1156](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1156/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/381#issuecomment-44361434
Re: [jclouds] Remove BlobBuilder and Payloads.calculateMD5 (#381)
Posted by Andrew Gaul <no...@github.com>.
Failures due to tests relying on rebuffering to a ByteArrayPayload implicitly setting content length. Also removed some unnecessary edits to TransientStorageStrategy. Pushed to master.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/381#issuecomment-44456193
Re: [jclouds] Remove BlobBuilder and Payloads.calculateMD5 (#381)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1159](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1159/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/381#issuecomment-44368481
Re: [jclouds] Remove BlobBuilder and Payloads.calculateMD5 (#381)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1307](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1307/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/381#issuecomment-44362836
Re: [jclouds] Remove BlobBuilder and Payloads.calculateMD5 (#381)
Posted by Andrew Phillips <no...@github.com>.
> jclouds » jclouds #1156 UNSTABLE
Some real [test failures](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/org.apache.jclouds$jclouds-core/1156/testReport/) here, it seems.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/381#issuecomment-44362034
Re: [jclouds] Remove BlobBuilder and Payloads.calculateMD5 (#381)
Posted by Andrew Phillips <no...@github.com>.
+1 - looks good to me (pending PR builders, if they're running). Thanks, @andrewgaul!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/381#issuecomment-44360205
Re: [jclouds] Remove BlobBuilder and Payloads.calculateMD5 (#381)
Posted by Andrew Phillips <no...@github.com>.
> Pushed to master.
See [here](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=186f052022cc1ce611fffb809497e22daaaa8d14). Thanks, @andrewgaul!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/381#issuecomment-44613995
Re: [jclouds] Remove BlobBuilder and Payloads.calculateMD5 (#381)
Posted by Andrew Gaul <no...@github.com>.
Added a missing calls to ```setContentLength```.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/381#issuecomment-44366023
Re: [jclouds] Remove BlobBuilder and Payloads.calculateMD5 (#381)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #836](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/836/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/381#issuecomment-44362556