You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "mymeiyi (via GitHub)" <gi...@apache.org> on 2024/10/16 03:45:17 UTC
[PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
mymeiyi opened a new pull request, #41932:
URL: https://github.com/apache/doris/pull/41932
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2416738364
TeamCity be ut coverage result:
Function Coverage: 37.46% (9710/25921)
Line Coverage: 28.72% (80609/280685)
Region Coverage: 28.16% (41713/148116)
Branch Coverage: 24.74% (21211/85722)
Coverage Report: http://coverage.selectdb-in.cc/coverage/885bbe4188d8e9d3c9a01c8da95c7674d6d2505e_885bbe4188d8e9d3c9a01c8da95c7674d6d2505e/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2499901950
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2421224734
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #41932:
URL: https://github.com/apache/doris/pull/41932#discussion_r1816148218
##########
be/src/olap/base_tablet.cpp:
##########
@@ -1344,7 +1356,10 @@ Status BaseTablet::check_delete_bitmap_correctness(DeleteBitmapPtr delete_bitmap
}
Status BaseTablet::update_delete_bitmap(const BaseTabletSPtr& self, TabletTxnInfo* txn_info,
Review Comment:
warning: function 'update_delete_bitmap' has cognitive complexity of 86 (threshold 50) [readability-function-cognitive-complexity]
```cpp
Status BaseTablet::update_delete_bitmap(const BaseTabletSPtr& self, TabletTxnInfo* txn_info,
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/base_tablet.cpp:1372:** +1
```cpp
txn_info->partial_update_info && txn_info->partial_update_info->is_partial_update();
^
```
**be/src/olap/base_tablet.cpp:1373:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (is_partial_update) {
^
```
**be/src/olap/base_tablet.cpp:1374:** nesting level increased to 2
```cpp
transient_rs_writer = DORIS_TRY(self->create_transient_rowset_writer(
^
```
**be/src/common/status.h:708:** expanded from macro 'DORIS_TRY'
```cpp
({ \
^
```
**be/src/olap/base_tablet.cpp:1374:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
transient_rs_writer = DORIS_TRY(self->create_transient_rowset_writer(
^
```
**be/src/common/status.h:711:** expanded from macro 'DORIS_TRY'
```cpp
if (!res.has_value()) [[unlikely]] { \
^
```
**be/src/olap/base_tablet.cpp:1386:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(std::dynamic_pointer_cast<BetaRowset>(rowset)->load_segments(&segments));
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1386:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(std::dynamic_pointer_cast<BetaRowset>(rowset)->load_segments(&segments));
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1392:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (self->tablet_state() == TABLET_NOTREADY) {
^
```
**be/src/olap/base_tablet.cpp:1397:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(self->get_all_rs_id_unlocked(next_visible_version - 1, &cur_rowset_ids));
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1397:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(self->get_all_rs_id_unlocked(next_visible_version - 1, &cur_rowset_ids));
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1412:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (non_visible_rowsets != nullptr) {
^
```
**be/src/olap/base_tablet.cpp:1417:** nesting level increased to 2
```cpp
[](RowsetSharedPtr& lhs, RowsetSharedPtr& rhs) {
^
```
**be/src/olap/base_tablet.cpp:1428:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (is_partial_update) {
^
```
**be/src/olap/base_tablet.cpp:1441:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
if (!rowsets_skip_alignment.empty()) {
^
```
**be/src/olap/base_tablet.cpp:1446:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
DBUG_EXECUTE_IF("BaseTablet::update_delete_bitmap.enable_spin_wait", {
^
```
**be/src/util/debug_points.h:36:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (UNLIKELY(config::enable_debug_points)) { \
^
```
**be/src/olap/base_tablet.cpp:1446:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
DBUG_EXECUTE_IF("BaseTablet::update_delete_bitmap.enable_spin_wait", {
^
```
**be/src/util/debug_points.h:38:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (dp) { \
^
```
**be/src/olap/base_tablet.cpp:1448:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
while (DebugPoints::instance()->is_enable("BaseTablet::update_delete_bitmap.block")) {
^
```
**be/src/olap/base_tablet.cpp:1451:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
if (block_dp) {
^
```
**be/src/olap/base_tablet.cpp:1453:** +5, including nesting penalty of 4, nesting level increased to 5
```cpp
if (wait_token != token) {
^
```
**be/src/olap/base_tablet.cpp:1461:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (!rowsets_skip_alignment.empty()) {
^
```
**be/src/olap/base_tablet.cpp:1464:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(calc_delete_bitmap(self, rowset, segments, rowsets_skip_alignment,
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1464:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(calc_delete_bitmap(self, rowset, segments, rowsets_skip_alignment,
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1467:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(token->wait());
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1467:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(token->wait());
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1472:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (segments.size() <= 1) {
^
```
**be/src/olap/base_tablet.cpp:1473:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(calc_delete_bitmap(self, rowset, segments, specified_rowsets, delete_bitmap,
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1473:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(calc_delete_bitmap(self, rowset, segments, specified_rowsets, delete_bitmap,
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1477:** +1, nesting level increased to 1
```cpp
} else {
^
```
**be/src/olap/base_tablet.cpp:1479:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(calc_delete_bitmap(self, rowset, segments, specified_rowsets, delete_bitmap,
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1479:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(calc_delete_bitmap(self, rowset, segments, specified_rowsets, delete_bitmap,
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1482:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(token->wait());
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1482:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(token->wait());
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1490:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (config::enable_merge_on_write_correctness_check && rowset->num_rows() != 0) {
^
```
**be/src/olap/base_tablet.cpp:1490:** +1
```cpp
if (config::enable_merge_on_write_correctness_check && rowset->num_rows() != 0) {
^
```
**be/src/olap/base_tablet.cpp:1495:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
if (!st.ok()) {
^
```
**be/src/olap/base_tablet.cpp:1500:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (transient_rs_writer) {
^
```
**be/src/olap/base_tablet.cpp:1502:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
DBUG_EXECUTE_IF("Tablet.update_delete_bitmap.partial_update_write_rowset_fail", {
^
```
**be/src/util/debug_points.h:36:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (UNLIKELY(config::enable_debug_points)) { \
^
```
**be/src/olap/base_tablet.cpp:1502:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
DBUG_EXECUTE_IF("Tablet.update_delete_bitmap.partial_update_write_rowset_fail", {
^
```
**be/src/util/debug_points.h:38:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (dp) { \
^
```
**be/src/olap/base_tablet.cpp:1503:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
if (rand() % 100 < (100 * dp->param("percent", 0.5))) {
^
```
**be/src/olap/base_tablet.cpp:1511:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(transient_rs_writer->flush());
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1511:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(transient_rs_writer->flush());
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1513:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(transient_rs_writer->build(transient_rowset));
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1513:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(transient_rs_writer->build(transient_rowset));
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1530:** nesting level increased to 1
```cpp
[](size_t sum, const segment_v2::SegmentSharedPtr& s) { return sum += s->num_rows(); });
^
```
**be/src/olap/base_tablet.cpp:1532:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(self->save_delete_bitmap(txn_info, txn_id, delete_bitmap,
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1532:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(self->save_delete_bitmap(txn_info, txn_id, delete_bitmap,
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2415666743
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "zhannngchen (via GitHub)" <gi...@apache.org>.
zhannngchen commented on code in PR #41932:
URL: https://github.com/apache/doris/pull/41932#discussion_r1853185227
##########
be/src/olap/base_tablet.h:
##########
@@ -236,10 +239,21 @@ class BaseTablet {
static Status update_delete_bitmap(const BaseTabletSPtr& self, TabletTxnInfo* txn_info,
int64_t txn_id, int64_t txn_expiration = 0);
+ // The {invisible_rowsets} and {base_txn_id} is set in transaction load. In transaction load:
+ // * the {txn_id} is sub_txn_id
+ // * the {invisible_rowsets} is used to calculate delete bitmap
+ // * the {base_txn_id} is used as lock id in cloud mode
+ // * the {next_visible_version} is the next version of the partition visible version
+ static Status update_delete_bitmap(const BaseTabletSPtr& self, TabletTxnInfo* txn_info,
+ int64_t txn_id, int64_t txn_expiration,
+ std::vector<RowsetSharedPtr>* invisible_rowsets,
+ int64_t base_txn_id, int64_t next_visible_version,
Review Comment:
change `base_txn_id` to `lock_id`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2500863053
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2454009338
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2425543559
TeamCity be ut coverage result:
Function Coverage: 37.47% (9710/25914)
Line Coverage: 28.74% (80661/280609)
Region Coverage: 28.17% (41723/148086)
Branch Coverage: 24.75% (21210/85686)
Coverage Report: http://coverage.selectdb-in.cc/coverage/69be38d179357da8b7cee819e061a7465145fa21_69be38d179357da8b7cee819e061a7465145fa21/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2415688992
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2484834653
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2440438743
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2500144453
TeamCity be ut coverage result:
Function Coverage: 38.36% (9979/26015)
Line Coverage: 29.46% (83533/283583)
Region Coverage: 28.60% (42995/150324)
Branch Coverage: 25.19% (21833/86658)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b1664e217b4485e4d5a423690b634a76456a1521_b1664e217b4485e4d5a423690b634a76456a1521/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2469814253
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2473472372
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "zhannngchen (via GitHub)" <gi...@apache.org>.
zhannngchen commented on code in PR #41932:
URL: https://github.com/apache/doris/pull/41932#discussion_r1853184624
##########
be/src/olap/base_tablet.h:
##########
@@ -236,10 +239,21 @@ class BaseTablet {
static Status update_delete_bitmap(const BaseTabletSPtr& self, TabletTxnInfo* txn_info,
int64_t txn_id, int64_t txn_expiration = 0);
+ // The {invisible_rowsets} and {base_txn_id} is set in transaction load. In transaction load:
+ // * the {txn_id} is sub_txn_id
+ // * the {invisible_rowsets} is used to calculate delete bitmap
+ // * the {base_txn_id} is used as lock id in cloud mode
+ // * the {next_visible_version} is the next version of the partition visible version
+ static Status update_delete_bitmap(const BaseTabletSPtr& self, TabletTxnInfo* txn_info,
+ int64_t txn_id, int64_t txn_expiration,
Review Comment:
consider to add an additional struct like `SubTxnInfo` in `TabletTxnInfo`, pass sub txns through parameter `txn_info`.
Current modification will make this method signature look confusing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2425427974
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2478478517
TeamCity be ut coverage result:
Function Coverage: 38.00% (9903/26061)
Line Coverage: 29.17% (82728/283614)
Region Coverage: 28.30% (42495/150140)
Branch Coverage: 24.88% (21546/86616)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4553bc3375ff3b59a0b2425b988b8a9bc83d6cad_4553bc3375ff3b59a0b2425b988b8a9bc83d6cad/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2437088866
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2437292621
TeamCity be ut coverage result:
Function Coverage: 37.46% (9714/25935)
Line Coverage: 28.71% (80563/280642)
Region Coverage: 28.13% (41656/148060)
Branch Coverage: 24.70% (21169/85718)
Coverage Report: http://coverage.selectdb-in.cc/coverage/0a8d05a141846170d7dd3f5c233504cfae608120_0a8d05a141846170d7dd3f5c233504cfae608120/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2449978624
TeamCity be ut coverage result:
Function Coverage: 37.94% (9853/25973)
Line Coverage: 29.17% (82114/281504)
Region Coverage: 28.43% (42361/149001)
Branch Coverage: 25.00% (21527/86094)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7019c054d9d6e1e47464acc8422e4cc75d6d5621_7019c054d9d6e1e47464acc8422e4cc75d6d5621/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2421217456
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2415806839
TeamCity be ut coverage result:
Function Coverage: 37.46% (9708/25916)
Line Coverage: 28.73% (80617/280589)
Region Coverage: 28.17% (41699/148045)
Branch Coverage: 24.75% (21207/85680)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7ef30a6b67d0f29e90321d373b159892927c2262_7ef30a6b67d0f29e90321d373b159892927c2262/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on code in PR #41932:
URL: https://github.com/apache/doris/pull/41932#discussion_r1819065146
##########
fe/fe-common/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -3114,6 +3114,9 @@ public static int metaServiceRpcRetryTimes() {
@ConfField(mutable = true, description = {"存算分离模式下calculate delete bitmap task 超时时间,默认15s"})
public static int calculate_delete_bitmap_task_timeout_seconds = 15;
+ @ConfField(mutable = true, description = {"存算分离模式下事务导入calculate delete bitmap task 超时时间,默认300s"})
+ public static int calculate_delete_bitmap_task_timeout_seconds_for_transaction_load = 300;
Review Comment:
What about using calculate_delete_bitmap_task_timeout_seconds and adjust calculate_delete_bitmap_task_timeout_seconds to a larger number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2478258696
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2418811629
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2440545629
TeamCity be ut coverage result:
Function Coverage: 37.46% (9717/25939)
Line Coverage: 28.72% (80592/280571)
Region Coverage: 28.16% (41680/148036)
Branch Coverage: 24.71% (21175/85690)
Coverage Report: http://coverage.selectdb-in.cc/coverage/41ddebd583d1ba8b948ebccd7eabca2f3e866405_41ddebd583d1ba8b948ebccd7eabca2f3e866405/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2449732596
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2449058717
TeamCity be ut coverage result:
Function Coverage: 37.92% (9851/25976)
Line Coverage: 29.18% (82066/281247)
Region Coverage: 28.45% (42359/148898)
Branch Coverage: 25.02% (21523/86008)
Coverage Report: http://coverage.selectdb-in.cc/coverage/8035c344f4b832ba0d3efe209fecdd8700947603_8035c344f4b832ba0d3efe209fecdd8700947603/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #41932:
URL: https://github.com/apache/doris/pull/41932#discussion_r1802306841
##########
be/src/olap/base_tablet.cpp:
##########
@@ -1344,7 +1344,9 @@ Status BaseTablet::check_delete_bitmap_correctness(DeleteBitmapPtr delete_bitmap
}
Status BaseTablet::update_delete_bitmap(const BaseTabletSPtr& self, TabletTxnInfo* txn_info,
Review Comment:
warning: function 'update_delete_bitmap' has cognitive complexity of 86 (threshold 50) [readability-function-cognitive-complexity]
```cpp
Status BaseTablet::update_delete_bitmap(const BaseTabletSPtr& self, TabletTxnInfo* txn_info,
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/base_tablet.cpp:1359:** +1
```cpp
txn_info->partial_update_info && txn_info->partial_update_info->is_partial_update();
^
```
**be/src/olap/base_tablet.cpp:1360:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (is_partial_update) {
^
```
**be/src/olap/base_tablet.cpp:1361:** nesting level increased to 2
```cpp
transient_rs_writer = DORIS_TRY(self->create_transient_rowset_writer(
^
```
**be/src/common/status.h:708:** expanded from macro 'DORIS_TRY'
```cpp
({ \
^
```
**be/src/olap/base_tablet.cpp:1361:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
transient_rs_writer = DORIS_TRY(self->create_transient_rowset_writer(
^
```
**be/src/common/status.h:711:** expanded from macro 'DORIS_TRY'
```cpp
if (!res.has_value()) [[unlikely]] { \
^
```
**be/src/olap/base_tablet.cpp:1373:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(std::dynamic_pointer_cast<BetaRowset>(rowset)->load_segments(&segments));
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1373:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(std::dynamic_pointer_cast<BetaRowset>(rowset)->load_segments(&segments));
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1379:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (self->tablet_state() == TABLET_NOTREADY) {
^
```
**be/src/olap/base_tablet.cpp:1384:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(self->get_all_rs_id_unlocked(next_visible_version - 1, &cur_rowset_ids));
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1384:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(self->get_all_rs_id_unlocked(next_visible_version - 1, &cur_rowset_ids));
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1399:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (non_visible_rowsets != nullptr) {
^
```
**be/src/olap/base_tablet.cpp:1411:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (is_partial_update) {
^
```
**be/src/olap/base_tablet.cpp:1424:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
if (!rowsets_skip_alignment.empty()) {
^
```
**be/src/olap/base_tablet.cpp:1429:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
DBUG_EXECUTE_IF("BaseTablet::update_delete_bitmap.enable_spin_wait", {
^
```
**be/src/util/debug_points.h:36:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (UNLIKELY(config::enable_debug_points)) { \
^
```
**be/src/olap/base_tablet.cpp:1429:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
DBUG_EXECUTE_IF("BaseTablet::update_delete_bitmap.enable_spin_wait", {
^
```
**be/src/util/debug_points.h:38:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (dp) { \
^
```
**be/src/olap/base_tablet.cpp:1431:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
while (DebugPoints::instance()->is_enable("BaseTablet::update_delete_bitmap.block")) {
^
```
**be/src/olap/base_tablet.cpp:1434:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
if (block_dp) {
^
```
**be/src/olap/base_tablet.cpp:1436:** +5, including nesting penalty of 4, nesting level increased to 5
```cpp
if (wait_token != token) {
^
```
**be/src/olap/base_tablet.cpp:1444:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (!rowsets_skip_alignment.empty()) {
^
```
**be/src/olap/base_tablet.cpp:1447:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(calc_delete_bitmap(self, rowset, segments, rowsets_skip_alignment,
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1447:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(calc_delete_bitmap(self, rowset, segments, rowsets_skip_alignment,
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1449:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(token->wait());
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1449:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(token->wait());
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1454:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (segments.size() <= 1) {
^
```
**be/src/olap/base_tablet.cpp:1455:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(calc_delete_bitmap(self, rowset, segments, specified_rowsets, delete_bitmap,
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1455:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(calc_delete_bitmap(self, rowset, segments, specified_rowsets, delete_bitmap,
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1458:** +1, nesting level increased to 1
```cpp
} else {
^
```
**be/src/olap/base_tablet.cpp:1460:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(calc_delete_bitmap(self, rowset, segments, specified_rowsets, delete_bitmap,
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1460:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(calc_delete_bitmap(self, rowset, segments, specified_rowsets, delete_bitmap,
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1463:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(token->wait());
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1463:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(token->wait());
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1471:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (config::enable_merge_on_write_correctness_check && rowset->num_rows() != 0) {
^
```
**be/src/olap/base_tablet.cpp:1471:** +1
```cpp
if (config::enable_merge_on_write_correctness_check && rowset->num_rows() != 0) {
^
```
**be/src/olap/base_tablet.cpp:1476:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
if (!st.ok()) {
^
```
**be/src/olap/base_tablet.cpp:1481:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (transient_rs_writer) {
^
```
**be/src/olap/base_tablet.cpp:1483:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
DBUG_EXECUTE_IF("Tablet.update_delete_bitmap.partial_update_write_rowset_fail", {
^
```
**be/src/util/debug_points.h:36:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (UNLIKELY(config::enable_debug_points)) { \
^
```
**be/src/olap/base_tablet.cpp:1483:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
DBUG_EXECUTE_IF("Tablet.update_delete_bitmap.partial_update_write_rowset_fail", {
^
```
**be/src/util/debug_points.h:38:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (dp) { \
^
```
**be/src/olap/base_tablet.cpp:1484:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
if (rand() % 100 < (100 * dp->param("percent", 0.5))) {
^
```
**be/src/olap/base_tablet.cpp:1492:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(transient_rs_writer->flush());
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1492:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(transient_rs_writer->flush());
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1494:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(transient_rs_writer->build(transient_rowset));
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1494:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(transient_rs_writer->build(transient_rowset));
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1511:** nesting level increased to 1
```cpp
[](size_t sum, const segment_v2::SegmentSharedPtr& s) { return sum += s->num_rows(); });
^
```
**be/src/olap/base_tablet.cpp:1513:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(self->save_delete_bitmap(txn_info, txn_id, delete_bitmap,
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1513:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(self->save_delete_bitmap(txn_info, txn_id, delete_bitmap,
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2421382459
TeamCity be ut coverage result:
Function Coverage: 37.46% (9710/25921)
Line Coverage: 28.73% (80653/280707)
Region Coverage: 28.17% (41729/148132)
Branch Coverage: 24.74% (21213/85728)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4817fed4ac4af5df8146920e1dd944c5614bec77_4817fed4ac4af5df8146920e1dd944c5614bec77/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2425674791
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2425674907
run cloud_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2453817026
TeamCity be ut coverage result:
Function Coverage: 37.81% (9820/25970)
Line Coverage: 28.97% (81583/281657)
Region Coverage: 28.25% (42142/149194)
Branch Coverage: 24.82% (21375/86136)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b3243b0e0f54a40b4dd6342c017a37559284a669_b3243b0e0f54a40b4dd6342c017a37559284a669/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2478215655
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2416476064
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #41932:
URL: https://github.com/apache/doris/pull/41932#discussion_r1838178371
##########
be/src/olap/base_tablet.cpp:
##########
@@ -1341,7 +1354,10 @@ Status BaseTablet::check_delete_bitmap_correctness(DeleteBitmapPtr delete_bitmap
}
Status BaseTablet::update_delete_bitmap(const BaseTabletSPtr& self, TabletTxnInfo* txn_info,
Review Comment:
warning: function 'update_delete_bitmap' has cognitive complexity of 86 (threshold 50) [readability-function-cognitive-complexity]
```cpp
Status BaseTablet::update_delete_bitmap(const BaseTabletSPtr& self, TabletTxnInfo* txn_info,
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/base_tablet.cpp:1370:** +1
```cpp
txn_info->partial_update_info && txn_info->partial_update_info->is_partial_update();
^
```
**be/src/olap/base_tablet.cpp:1371:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (is_partial_update) {
^
```
**be/src/olap/base_tablet.cpp:1372:** nesting level increased to 2
```cpp
transient_rs_writer = DORIS_TRY(self->create_transient_rowset_writer(
^
```
**be/src/common/status.h:709:** expanded from macro 'DORIS_TRY'
```cpp
({ \
^
```
**be/src/olap/base_tablet.cpp:1372:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
transient_rs_writer = DORIS_TRY(self->create_transient_rowset_writer(
^
```
**be/src/common/status.h:712:** expanded from macro 'DORIS_TRY'
```cpp
if (!res.has_value()) [[unlikely]] { \
^
```
**be/src/olap/base_tablet.cpp:1384:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(std::dynamic_pointer_cast<BetaRowset>(rowset)->load_segments(&segments));
^
```
**be/src/common/status.h:630:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1384:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(std::dynamic_pointer_cast<BetaRowset>(rowset)->load_segments(&segments));
^
```
**be/src/common/status.h:632:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1390:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (self->tablet_state() == TABLET_NOTREADY) {
^
```
**be/src/olap/base_tablet.cpp:1395:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(self->get_all_rs_id_unlocked(next_visible_version - 1, &cur_rowset_ids));
^
```
**be/src/common/status.h:630:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1395:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(self->get_all_rs_id_unlocked(next_visible_version - 1, &cur_rowset_ids));
^
```
**be/src/common/status.h:632:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1410:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (invisible_rowsets != nullptr) {
^
```
**be/src/olap/base_tablet.cpp:1415:** nesting level increased to 2
```cpp
[](RowsetSharedPtr& lhs, RowsetSharedPtr& rhs) {
^
```
**be/src/olap/base_tablet.cpp:1426:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (is_partial_update) {
^
```
**be/src/olap/base_tablet.cpp:1439:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
if (!rowsets_skip_alignment.empty()) {
^
```
**be/src/olap/base_tablet.cpp:1444:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
DBUG_EXECUTE_IF("BaseTablet::update_delete_bitmap.enable_spin_wait", {
^
```
**be/src/util/debug_points.h:36:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (UNLIKELY(config::enable_debug_points)) { \
^
```
**be/src/olap/base_tablet.cpp:1444:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
DBUG_EXECUTE_IF("BaseTablet::update_delete_bitmap.enable_spin_wait", {
^
```
**be/src/util/debug_points.h:38:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (dp) { \
^
```
**be/src/olap/base_tablet.cpp:1446:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
while (DebugPoints::instance()->is_enable("BaseTablet::update_delete_bitmap.block")) {
^
```
**be/src/olap/base_tablet.cpp:1449:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
if (block_dp) {
^
```
**be/src/olap/base_tablet.cpp:1451:** +5, including nesting penalty of 4, nesting level increased to 5
```cpp
if (wait_token != token) {
^
```
**be/src/olap/base_tablet.cpp:1459:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (!rowsets_skip_alignment.empty()) {
^
```
**be/src/olap/base_tablet.cpp:1462:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(calc_delete_bitmap(self, rowset, segments, rowsets_skip_alignment,
^
```
**be/src/common/status.h:630:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1462:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(calc_delete_bitmap(self, rowset, segments, rowsets_skip_alignment,
^
```
**be/src/common/status.h:632:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1465:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(token->wait());
^
```
**be/src/common/status.h:630:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1465:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(token->wait());
^
```
**be/src/common/status.h:632:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1470:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (segments.size() <= 1) {
^
```
**be/src/olap/base_tablet.cpp:1471:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(calc_delete_bitmap(self, rowset, segments, specified_rowsets, delete_bitmap,
^
```
**be/src/common/status.h:630:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1471:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(calc_delete_bitmap(self, rowset, segments, specified_rowsets, delete_bitmap,
^
```
**be/src/common/status.h:632:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1475:** +1, nesting level increased to 1
```cpp
} else {
^
```
**be/src/olap/base_tablet.cpp:1477:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(calc_delete_bitmap(self, rowset, segments, specified_rowsets, delete_bitmap,
^
```
**be/src/common/status.h:630:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1477:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(calc_delete_bitmap(self, rowset, segments, specified_rowsets, delete_bitmap,
^
```
**be/src/common/status.h:632:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1480:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(token->wait());
^
```
**be/src/common/status.h:630:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1480:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(token->wait());
^
```
**be/src/common/status.h:632:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1488:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (config::enable_merge_on_write_correctness_check && rowset->num_rows() != 0) {
^
```
**be/src/olap/base_tablet.cpp:1488:** +1
```cpp
if (config::enable_merge_on_write_correctness_check && rowset->num_rows() != 0) {
^
```
**be/src/olap/base_tablet.cpp:1493:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
if (!st.ok()) {
^
```
**be/src/olap/base_tablet.cpp:1498:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (transient_rs_writer) {
^
```
**be/src/olap/base_tablet.cpp:1500:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
DBUG_EXECUTE_IF("Tablet.update_delete_bitmap.partial_update_write_rowset_fail", {
^
```
**be/src/util/debug_points.h:36:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (UNLIKELY(config::enable_debug_points)) { \
^
```
**be/src/olap/base_tablet.cpp:1500:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
DBUG_EXECUTE_IF("Tablet.update_delete_bitmap.partial_update_write_rowset_fail", {
^
```
**be/src/util/debug_points.h:38:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (dp) { \
^
```
**be/src/olap/base_tablet.cpp:1501:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
if (rand() % 100 < (100 * dp->param("percent", 0.5))) {
^
```
**be/src/olap/base_tablet.cpp:1509:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(transient_rs_writer->flush());
^
```
**be/src/common/status.h:630:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1509:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(transient_rs_writer->flush());
^
```
**be/src/common/status.h:632:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1511:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(transient_rs_writer->build(transient_rowset));
^
```
**be/src/common/status.h:630:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1511:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(transient_rs_writer->build(transient_rowset));
^
```
**be/src/common/status.h:632:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1528:** nesting level increased to 1
```cpp
[](size_t sum, const segment_v2::SegmentSharedPtr& s) { return sum += s->num_rows(); });
^
```
**be/src/olap/base_tablet.cpp:1530:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(self->save_delete_bitmap(txn_info, txn_id, delete_bitmap,
^
```
**be/src/common/status.h:630:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1530:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(self->save_delete_bitmap(txn_info, txn_id, delete_bitmap,
^
```
**be/src/common/status.h:632:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2470636006
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2448974821
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2449204129
run external
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2441720884
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "zhannngchen (via GitHub)" <gi...@apache.org>.
zhannngchen commented on code in PR #41932:
URL: https://github.com/apache/doris/pull/41932#discussion_r1853190083
##########
regression-test/suites/insert_p2/transaction/txn_insert_concurrent_insert_mow.groovy:
##########
@@ -85,8 +80,12 @@ suite("txn_insert_concurrent_insert_mow") {
}
}
sql """ sync """
+ def t2_row_count = 6001215
+ def result = sql """ select count() from ${tableName}_2 """
+ logger.info("${tableName}_2 row count: ${result}, expected: ${t2_row_count}")
+ assertEquals(t2_row_count, result[0][0] as int)
- def dbName = "regression_test_insert_p2"
+ def dbName = "regression_test_insert_p2_transaction"
Review Comment:
Do we have any cases test sequence column?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2441720979
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2453738110
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2453896579
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2449204518
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #41932:
URL: https://github.com/apache/doris/pull/41932#discussion_r1824374636
##########
be/src/olap/base_tablet.cpp:
##########
@@ -1344,7 +1356,10 @@ Status BaseTablet::check_delete_bitmap_correctness(DeleteBitmapPtr delete_bitmap
}
Status BaseTablet::update_delete_bitmap(const BaseTabletSPtr& self, TabletTxnInfo* txn_info,
Review Comment:
warning: function 'update_delete_bitmap' has cognitive complexity of 86 (threshold 50) [readability-function-cognitive-complexity]
```cpp
Status BaseTablet::update_delete_bitmap(const BaseTabletSPtr& self, TabletTxnInfo* txn_info,
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/base_tablet.cpp:1372:** +1
```cpp
txn_info->partial_update_info && txn_info->partial_update_info->is_partial_update();
^
```
**be/src/olap/base_tablet.cpp:1373:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (is_partial_update) {
^
```
**be/src/olap/base_tablet.cpp:1374:** nesting level increased to 2
```cpp
transient_rs_writer = DORIS_TRY(self->create_transient_rowset_writer(
^
```
**be/src/common/status.h:708:** expanded from macro 'DORIS_TRY'
```cpp
({ \
^
```
**be/src/olap/base_tablet.cpp:1374:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
transient_rs_writer = DORIS_TRY(self->create_transient_rowset_writer(
^
```
**be/src/common/status.h:711:** expanded from macro 'DORIS_TRY'
```cpp
if (!res.has_value()) [[unlikely]] { \
^
```
**be/src/olap/base_tablet.cpp:1386:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(std::dynamic_pointer_cast<BetaRowset>(rowset)->load_segments(&segments));
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1386:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(std::dynamic_pointer_cast<BetaRowset>(rowset)->load_segments(&segments));
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1392:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (self->tablet_state() == TABLET_NOTREADY) {
^
```
**be/src/olap/base_tablet.cpp:1397:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(self->get_all_rs_id_unlocked(next_visible_version - 1, &cur_rowset_ids));
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1397:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(self->get_all_rs_id_unlocked(next_visible_version - 1, &cur_rowset_ids));
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1412:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (invisible_rowsets != nullptr) {
^
```
**be/src/olap/base_tablet.cpp:1417:** nesting level increased to 2
```cpp
[](RowsetSharedPtr& lhs, RowsetSharedPtr& rhs) {
^
```
**be/src/olap/base_tablet.cpp:1428:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (is_partial_update) {
^
```
**be/src/olap/base_tablet.cpp:1441:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
if (!rowsets_skip_alignment.empty()) {
^
```
**be/src/olap/base_tablet.cpp:1446:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
DBUG_EXECUTE_IF("BaseTablet::update_delete_bitmap.enable_spin_wait", {
^
```
**be/src/util/debug_points.h:36:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (UNLIKELY(config::enable_debug_points)) { \
^
```
**be/src/olap/base_tablet.cpp:1446:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
DBUG_EXECUTE_IF("BaseTablet::update_delete_bitmap.enable_spin_wait", {
^
```
**be/src/util/debug_points.h:38:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (dp) { \
^
```
**be/src/olap/base_tablet.cpp:1448:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
while (DebugPoints::instance()->is_enable("BaseTablet::update_delete_bitmap.block")) {
^
```
**be/src/olap/base_tablet.cpp:1451:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
if (block_dp) {
^
```
**be/src/olap/base_tablet.cpp:1453:** +5, including nesting penalty of 4, nesting level increased to 5
```cpp
if (wait_token != token) {
^
```
**be/src/olap/base_tablet.cpp:1461:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (!rowsets_skip_alignment.empty()) {
^
```
**be/src/olap/base_tablet.cpp:1464:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(calc_delete_bitmap(self, rowset, segments, rowsets_skip_alignment,
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1464:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(calc_delete_bitmap(self, rowset, segments, rowsets_skip_alignment,
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1467:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(token->wait());
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1467:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(token->wait());
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1472:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (segments.size() <= 1) {
^
```
**be/src/olap/base_tablet.cpp:1473:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(calc_delete_bitmap(self, rowset, segments, specified_rowsets, delete_bitmap,
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1473:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(calc_delete_bitmap(self, rowset, segments, specified_rowsets, delete_bitmap,
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1477:** +1, nesting level increased to 1
```cpp
} else {
^
```
**be/src/olap/base_tablet.cpp:1479:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(calc_delete_bitmap(self, rowset, segments, specified_rowsets, delete_bitmap,
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1479:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(calc_delete_bitmap(self, rowset, segments, specified_rowsets, delete_bitmap,
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1482:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(token->wait());
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1482:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(token->wait());
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1490:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (config::enable_merge_on_write_correctness_check && rowset->num_rows() != 0) {
^
```
**be/src/olap/base_tablet.cpp:1490:** +1
```cpp
if (config::enable_merge_on_write_correctness_check && rowset->num_rows() != 0) {
^
```
**be/src/olap/base_tablet.cpp:1495:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
if (!st.ok()) {
^
```
**be/src/olap/base_tablet.cpp:1500:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (transient_rs_writer) {
^
```
**be/src/olap/base_tablet.cpp:1502:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
DBUG_EXECUTE_IF("Tablet.update_delete_bitmap.partial_update_write_rowset_fail", {
^
```
**be/src/util/debug_points.h:36:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (UNLIKELY(config::enable_debug_points)) { \
^
```
**be/src/olap/base_tablet.cpp:1502:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
DBUG_EXECUTE_IF("Tablet.update_delete_bitmap.partial_update_write_rowset_fail", {
^
```
**be/src/util/debug_points.h:38:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (dp) { \
^
```
**be/src/olap/base_tablet.cpp:1503:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
if (rand() % 100 < (100 * dp->param("percent", 0.5))) {
^
```
**be/src/olap/base_tablet.cpp:1511:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(transient_rs_writer->flush());
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1511:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(transient_rs_writer->flush());
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1513:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(transient_rs_writer->build(transient_rowset));
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1513:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(transient_rs_writer->build(transient_rowset));
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1530:** nesting level increased to 1
```cpp
[](size_t sum, const segment_v2::SegmentSharedPtr& s) { return sum += s->num_rows(); });
^
```
**be/src/olap/base_tablet.cpp:1532:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(self->save_delete_bitmap(txn_info, txn_id, delete_bitmap,
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1532:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(self->save_delete_bitmap(txn_info, txn_id, delete_bitmap,
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #41932:
URL: https://github.com/apache/doris/pull/41932#discussion_r1805784362
##########
be/src/olap/base_tablet.cpp:
##########
@@ -1344,7 +1356,10 @@ Status BaseTablet::check_delete_bitmap_correctness(DeleteBitmapPtr delete_bitmap
}
Status BaseTablet::update_delete_bitmap(const BaseTabletSPtr& self, TabletTxnInfo* txn_info,
Review Comment:
warning: function 'update_delete_bitmap' has cognitive complexity of 86 (threshold 50) [readability-function-cognitive-complexity]
```cpp
Status BaseTablet::update_delete_bitmap(const BaseTabletSPtr& self, TabletTxnInfo* txn_info,
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/base_tablet.cpp:1372:** +1
```cpp
txn_info->partial_update_info && txn_info->partial_update_info->is_partial_update();
^
```
**be/src/olap/base_tablet.cpp:1373:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (is_partial_update) {
^
```
**be/src/olap/base_tablet.cpp:1374:** nesting level increased to 2
```cpp
transient_rs_writer = DORIS_TRY(self->create_transient_rowset_writer(
^
```
**be/src/common/status.h:708:** expanded from macro 'DORIS_TRY'
```cpp
({ \
^
```
**be/src/olap/base_tablet.cpp:1374:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
transient_rs_writer = DORIS_TRY(self->create_transient_rowset_writer(
^
```
**be/src/common/status.h:711:** expanded from macro 'DORIS_TRY'
```cpp
if (!res.has_value()) [[unlikely]] { \
^
```
**be/src/olap/base_tablet.cpp:1386:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(std::dynamic_pointer_cast<BetaRowset>(rowset)->load_segments(&segments));
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1386:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(std::dynamic_pointer_cast<BetaRowset>(rowset)->load_segments(&segments));
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1392:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (self->tablet_state() == TABLET_NOTREADY) {
^
```
**be/src/olap/base_tablet.cpp:1397:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(self->get_all_rs_id_unlocked(next_visible_version - 1, &cur_rowset_ids));
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1397:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(self->get_all_rs_id_unlocked(next_visible_version - 1, &cur_rowset_ids));
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1412:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (non_visible_rowsets != nullptr) {
^
```
**be/src/olap/base_tablet.cpp:1424:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (is_partial_update) {
^
```
**be/src/olap/base_tablet.cpp:1437:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
if (!rowsets_skip_alignment.empty()) {
^
```
**be/src/olap/base_tablet.cpp:1442:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
DBUG_EXECUTE_IF("BaseTablet::update_delete_bitmap.enable_spin_wait", {
^
```
**be/src/util/debug_points.h:36:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (UNLIKELY(config::enable_debug_points)) { \
^
```
**be/src/olap/base_tablet.cpp:1442:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
DBUG_EXECUTE_IF("BaseTablet::update_delete_bitmap.enable_spin_wait", {
^
```
**be/src/util/debug_points.h:38:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (dp) { \
^
```
**be/src/olap/base_tablet.cpp:1444:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
while (DebugPoints::instance()->is_enable("BaseTablet::update_delete_bitmap.block")) {
^
```
**be/src/olap/base_tablet.cpp:1447:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
if (block_dp) {
^
```
**be/src/olap/base_tablet.cpp:1449:** +5, including nesting penalty of 4, nesting level increased to 5
```cpp
if (wait_token != token) {
^
```
**be/src/olap/base_tablet.cpp:1457:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (!rowsets_skip_alignment.empty()) {
^
```
**be/src/olap/base_tablet.cpp:1460:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(calc_delete_bitmap(self, rowset, segments, rowsets_skip_alignment,
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1460:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(calc_delete_bitmap(self, rowset, segments, rowsets_skip_alignment,
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1463:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(token->wait());
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1463:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(token->wait());
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1468:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (segments.size() <= 1) {
^
```
**be/src/olap/base_tablet.cpp:1469:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(calc_delete_bitmap(self, rowset, segments, specified_rowsets, delete_bitmap,
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1469:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(calc_delete_bitmap(self, rowset, segments, specified_rowsets, delete_bitmap,
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1473:** +1, nesting level increased to 1
```cpp
} else {
^
```
**be/src/olap/base_tablet.cpp:1475:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(calc_delete_bitmap(self, rowset, segments, specified_rowsets, delete_bitmap,
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1475:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(calc_delete_bitmap(self, rowset, segments, specified_rowsets, delete_bitmap,
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1478:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(token->wait());
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1478:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(token->wait());
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1486:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (config::enable_merge_on_write_correctness_check && rowset->num_rows() != 0) {
^
```
**be/src/olap/base_tablet.cpp:1486:** +1
```cpp
if (config::enable_merge_on_write_correctness_check && rowset->num_rows() != 0) {
^
```
**be/src/olap/base_tablet.cpp:1491:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
if (!st.ok()) {
^
```
**be/src/olap/base_tablet.cpp:1496:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (transient_rs_writer) {
^
```
**be/src/olap/base_tablet.cpp:1498:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
DBUG_EXECUTE_IF("Tablet.update_delete_bitmap.partial_update_write_rowset_fail", {
^
```
**be/src/util/debug_points.h:36:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (UNLIKELY(config::enable_debug_points)) { \
^
```
**be/src/olap/base_tablet.cpp:1498:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
DBUG_EXECUTE_IF("Tablet.update_delete_bitmap.partial_update_write_rowset_fail", {
^
```
**be/src/util/debug_points.h:38:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (dp) { \
^
```
**be/src/olap/base_tablet.cpp:1499:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
if (rand() % 100 < (100 * dp->param("percent", 0.5))) {
^
```
**be/src/olap/base_tablet.cpp:1507:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(transient_rs_writer->flush());
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1507:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(transient_rs_writer->flush());
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1509:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(transient_rs_writer->build(transient_rowset));
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1509:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(transient_rs_writer->build(transient_rowset));
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1526:** nesting level increased to 1
```cpp
[](size_t sum, const segment_v2::SegmentSharedPtr& s) { return sum += s->num_rows(); });
^
```
**be/src/olap/base_tablet.cpp:1528:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(self->save_delete_bitmap(txn_info, txn_id, delete_bitmap,
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1528:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(self->save_delete_bitmap(txn_info, txn_id, delete_bitmap,
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
</details>
##########
be/src/cloud/cloud_engine_calc_delete_bitmap_task.cpp:
##########
@@ -189,6 +190,60 @@ Status CloudTabletCalcDeleteBitmapTask::handle() const {
return error_st;
}
+ int64_t t3 = MonotonicMicros();
+ Status status;
+ if (_sub_txn_ids.empty()) {
+ status = _handle_rowset(tablet, _version);
+ } else {
+ std::stringstream ss;
+ for (const auto& sub_txn_id : _sub_txn_ids) {
+ ss << sub_txn_id << ", ";
+ }
+ LOG(INFO) << "start calc delete bitmap for txn_id=" << _transaction_id << ", sub_txn_ids=["
+ << ss.str() << "], table_id=" << tablet->table_id()
+ << ", partition_id=" << tablet->partition_id() << ", tablet_id=" << _tablet_id
+ << ", start_version=" << _version;
+ std::vector<RowsetSharedPtr> non_visible_rowsets;
+ DeleteBitmapPtr tablet_delete_bitmap =
+ std::make_shared<DeleteBitmap>(tablet->tablet_meta()->delete_bitmap());
+ for (int i = 0; i < _sub_txn_ids.size(); ++i) {
+ int64_t sub_txn_id = _sub_txn_ids[i];
+ int64_t version = _version + i;
+ LOG(INFO) << "start calc delete bitmap for txn_id=" << _transaction_id
+ << ", sub_txn_id=" << sub_txn_id << ", table_id=" << tablet->table_id()
+ << ", partition_id=" << tablet->partition_id() << ", tablet_id=" << _tablet_id
+ << ", start_version=" << _version << ", cur_version=" << version;
+ status = _handle_rowset(tablet, version, sub_txn_id, &non_visible_rowsets,
+ tablet_delete_bitmap);
+ if (!status.ok()) {
+ LOG(INFO) << "failed to calculate delete bitmap on tablet"
+ << ", table_id=" << tablet->table_id()
+ << ", transaction_id=" << _transaction_id << ", sub_txn_id=" << sub_txn_id
+ << ", tablet_id=" << tablet->tablet_id() << ", start version=" << _version
+ << ", cur_version=" << version << ", status=" << status;
+ return status;
+ }
+ DCHECK(non_visible_rowsets.size() == i + 1);
+ }
+ }
+ auto total_update_delete_bitmap_time_us = MonotonicMicros() - t3;
+ LOG(INFO) << "calculate delete bitmap successfully on tablet"
+ << ", table_id=" << tablet->table_id() << ", transaction_id=" << _transaction_id
+ << ", tablet_id=" << tablet->tablet_id()
+ << ", get_tablet_time_us=" << get_tablet_time_us
+ << ", sync_rowset_time_us=" << sync_rowset_time_us
+ << ", total_update_delete_bitmap_time_us=" << total_update_delete_bitmap_time_us
+ << ", res=" << status;
+ return status;
+}
+
+Status CloudTabletCalcDeleteBitmapTask::_handle_rowset(
Review Comment:
warning: function '_handle_rowset' exceeds recommended size/complexity thresholds [readability-function-size]
```cpp
Status CloudTabletCalcDeleteBitmapTask::_handle_rowset(
^
```
<details>
<summary>Additional context</summary>
**be/src/cloud/cloud_engine_calc_delete_bitmap_task.cpp:239:** 81 lines including whitespace and comments (threshold 80)
```cpp
Status CloudTabletCalcDeleteBitmapTask::_handle_rowset(
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #41932:
URL: https://github.com/apache/doris/pull/41932#discussion_r1837628683
##########
be/src/olap/base_tablet.cpp:
##########
@@ -1341,7 +1354,10 @@ Status BaseTablet::check_delete_bitmap_correctness(DeleteBitmapPtr delete_bitmap
}
Status BaseTablet::update_delete_bitmap(const BaseTabletSPtr& self, TabletTxnInfo* txn_info,
Review Comment:
warning: function 'update_delete_bitmap' has cognitive complexity of 86 (threshold 50) [readability-function-cognitive-complexity]
```cpp
Status BaseTablet::update_delete_bitmap(const BaseTabletSPtr& self, TabletTxnInfo* txn_info,
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/base_tablet.cpp:1370:** +1
```cpp
txn_info->partial_update_info && txn_info->partial_update_info->is_partial_update();
^
```
**be/src/olap/base_tablet.cpp:1371:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (is_partial_update) {
^
```
**be/src/olap/base_tablet.cpp:1372:** nesting level increased to 2
```cpp
transient_rs_writer = DORIS_TRY(self->create_transient_rowset_writer(
^
```
**be/src/common/status.h:708:** expanded from macro 'DORIS_TRY'
```cpp
({ \
^
```
**be/src/olap/base_tablet.cpp:1372:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
transient_rs_writer = DORIS_TRY(self->create_transient_rowset_writer(
^
```
**be/src/common/status.h:711:** expanded from macro 'DORIS_TRY'
```cpp
if (!res.has_value()) [[unlikely]] { \
^
```
**be/src/olap/base_tablet.cpp:1384:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(std::dynamic_pointer_cast<BetaRowset>(rowset)->load_segments(&segments));
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1384:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(std::dynamic_pointer_cast<BetaRowset>(rowset)->load_segments(&segments));
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1390:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (self->tablet_state() == TABLET_NOTREADY) {
^
```
**be/src/olap/base_tablet.cpp:1395:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(self->get_all_rs_id_unlocked(next_visible_version - 1, &cur_rowset_ids));
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1395:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(self->get_all_rs_id_unlocked(next_visible_version - 1, &cur_rowset_ids));
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1410:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (invisible_rowsets != nullptr) {
^
```
**be/src/olap/base_tablet.cpp:1415:** nesting level increased to 2
```cpp
[](RowsetSharedPtr& lhs, RowsetSharedPtr& rhs) {
^
```
**be/src/olap/base_tablet.cpp:1426:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (is_partial_update) {
^
```
**be/src/olap/base_tablet.cpp:1439:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
if (!rowsets_skip_alignment.empty()) {
^
```
**be/src/olap/base_tablet.cpp:1444:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
DBUG_EXECUTE_IF("BaseTablet::update_delete_bitmap.enable_spin_wait", {
^
```
**be/src/util/debug_points.h:36:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (UNLIKELY(config::enable_debug_points)) { \
^
```
**be/src/olap/base_tablet.cpp:1444:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
DBUG_EXECUTE_IF("BaseTablet::update_delete_bitmap.enable_spin_wait", {
^
```
**be/src/util/debug_points.h:38:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (dp) { \
^
```
**be/src/olap/base_tablet.cpp:1446:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
while (DebugPoints::instance()->is_enable("BaseTablet::update_delete_bitmap.block")) {
^
```
**be/src/olap/base_tablet.cpp:1449:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
if (block_dp) {
^
```
**be/src/olap/base_tablet.cpp:1451:** +5, including nesting penalty of 4, nesting level increased to 5
```cpp
if (wait_token != token) {
^
```
**be/src/olap/base_tablet.cpp:1459:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (!rowsets_skip_alignment.empty()) {
^
```
**be/src/olap/base_tablet.cpp:1462:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(calc_delete_bitmap(self, rowset, segments, rowsets_skip_alignment,
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1462:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(calc_delete_bitmap(self, rowset, segments, rowsets_skip_alignment,
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1465:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(token->wait());
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1465:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(token->wait());
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1470:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (segments.size() <= 1) {
^
```
**be/src/olap/base_tablet.cpp:1471:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(calc_delete_bitmap(self, rowset, segments, specified_rowsets, delete_bitmap,
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1471:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(calc_delete_bitmap(self, rowset, segments, specified_rowsets, delete_bitmap,
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1475:** +1, nesting level increased to 1
```cpp
} else {
^
```
**be/src/olap/base_tablet.cpp:1477:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(calc_delete_bitmap(self, rowset, segments, specified_rowsets, delete_bitmap,
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1477:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(calc_delete_bitmap(self, rowset, segments, specified_rowsets, delete_bitmap,
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1480:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(token->wait());
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1480:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(token->wait());
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1488:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (config::enable_merge_on_write_correctness_check && rowset->num_rows() != 0) {
^
```
**be/src/olap/base_tablet.cpp:1488:** +1
```cpp
if (config::enable_merge_on_write_correctness_check && rowset->num_rows() != 0) {
^
```
**be/src/olap/base_tablet.cpp:1493:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
if (!st.ok()) {
^
```
**be/src/olap/base_tablet.cpp:1498:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
if (transient_rs_writer) {
^
```
**be/src/olap/base_tablet.cpp:1500:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
DBUG_EXECUTE_IF("Tablet.update_delete_bitmap.partial_update_write_rowset_fail", {
^
```
**be/src/util/debug_points.h:36:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (UNLIKELY(config::enable_debug_points)) { \
^
```
**be/src/olap/base_tablet.cpp:1500:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
DBUG_EXECUTE_IF("Tablet.update_delete_bitmap.partial_update_write_rowset_fail", {
^
```
**be/src/util/debug_points.h:38:** expanded from macro 'DBUG_EXECUTE_IF'
```cpp
if (dp) { \
^
```
**be/src/olap/base_tablet.cpp:1501:** +4, including nesting penalty of 3, nesting level increased to 4
```cpp
if (rand() % 100 < (100 * dp->param("percent", 0.5))) {
^
```
**be/src/olap/base_tablet.cpp:1509:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(transient_rs_writer->flush());
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1509:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(transient_rs_writer->flush());
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1511:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(transient_rs_writer->build(transient_rowset));
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1511:** +3, including nesting penalty of 2, nesting level increased to 3
```cpp
RETURN_IF_ERROR(transient_rs_writer->build(transient_rowset));
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/olap/base_tablet.cpp:1528:** nesting level increased to 1
```cpp
[](size_t sum, const segment_v2::SegmentSharedPtr& s) { return sum += s->num_rows(); });
^
```
**be/src/olap/base_tablet.cpp:1530:** +1, including nesting penalty of 0, nesting level increased to 1
```cpp
RETURN_IF_ERROR(self->save_delete_bitmap(txn_info, txn_id, delete_bitmap,
^
```
**be/src/common/status.h:629:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/olap/base_tablet.cpp:1530:** +2, including nesting penalty of 1, nesting level increased to 2
```cpp
RETURN_IF_ERROR(self->save_delete_bitmap(txn_info, txn_id, delete_bitmap,
^
```
**be/src/common/status.h:631:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41932:
URL: https://github.com/apache/doris/pull/41932#issuecomment-2419044587
TeamCity be ut coverage result:
Function Coverage: 37.47% (9712/25921)
Line Coverage: 28.72% (80604/280677)
Region Coverage: 28.17% (41718/148115)
Branch Coverage: 24.74% (21205/85720)
Coverage Report: http://coverage.selectdb-in.cc/coverage/0fd68d4e836ea587e41e74ba290bc06b6d65c139_0fd68d4e836ea587e41e74ba290bc06b6d65c139/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #41932:
URL: https://github.com/apache/doris/pull/41932
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org