You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "vernedeng (via GitHub)" <gi...@apache.org> on 2023/03/20 04:33:48 UTC
[GitHub] [inlong] vernedeng opened a new pull request, #7649: [INLONG-7648][Manager] Support list streams by a specific group principal
vernedeng opened a new pull request, #7649:
URL: https://github.com/apache/inlong/pull/7649
### Prepare a Pull Request
*(Change the title refer to the following example)*
- Title Example: [INLONG-XYZ][Component] Title of the pull request
*(The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)*
- Fixes #7648
### Motivation
Support list streams by a specific group principal
### Modifications
Extense the condition dimension of stream list interface
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #7649: [INLONG-7648][Manager] Support list streams by a specific group principal
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #7649:
URL: https://github.com/apache/inlong/pull/7649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] vernedeng commented on a diff in pull request #7649: [INLONG-7648][Manager] Support list streams by a specific group principal
Posted by "vernedeng (via GitHub)" <gi...@apache.org>.
vernedeng commented on code in PR #7649:
URL: https://github.com/apache/inlong/pull/7649#discussion_r1141617697
##########
inlong-manager/manager-dao/src/main/resources/mappers/InlongStreamEntityMapper.xml:
##########
@@ -267,6 +267,9 @@
#{status}
</foreach>
</if>
+ <if test="request.inCharges != null and request.inCharges != ''">
+ and grp.in_charges like CONCAT('%', #{request.inCharges}, '%')
Review Comment:
fixed, thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] fuweng11 commented on a diff in pull request #7649: [INLONG-7648][Manager] Support list streams by a specific group principal
Posted by "fuweng11 (via GitHub)" <gi...@apache.org>.
fuweng11 commented on code in PR #7649:
URL: https://github.com/apache/inlong/pull/7649#discussion_r1141614027
##########
inlong-manager/manager-dao/src/main/resources/mappers/InlongStreamEntityMapper.xml:
##########
@@ -267,6 +267,9 @@
#{status}
</foreach>
</if>
+ <if test="request.inCharges != null and request.inCharges != ''">
+ and grp.in_charges like CONCAT('%', #{request.inCharges}, '%')
Review Comment:
use `find_in_set`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org