You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bval.apache.org by "Carlos Vara (JIRA)" <ji...@apache.org> on 2010/04/28 21:33:48 UTC
[jira] Created: (BVAL-29) Defer node creation in implementation of
ConstraintViolationBuilder API
Defer node creation in implementation of ConstraintViolationBuilder API
-----------------------------------------------------------------------
Key: BVAL-29
URL: https://issues.apache.org/jira/browse/BVAL-29
Project: BeanValidation
Issue Type: Bug
Components: jsr303
Affects Versions: 0.1-incubating
Reporter: Carlos Vara
Attachments: bval-jsr303.patch, ConstraintValidatorContextTest.java
Call to inIterable() should modify the previous sibling node instead of the "current" node, and in case a null named non iterable node is left in the leaf of the path, it should never be added.
This behavior is not documented in the JSR-303 spec document, but ConstraintValidatorContext Javadoc gives information on how it should work.
Patch includes some tests that serve also as examples of this API usage.
1 more test passes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BVAL-29) Defer node creation in implementation of
ConstraintViolationBuilder API
Posted by "Carlos Vara (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BVAL-29?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carlos Vara updated BVAL-29:
----------------------------
Attachment: bval-jsr303.patch
ConstraintValidatorContextTest.java
Patch and test.
> Defer node creation in implementation of ConstraintViolationBuilder API
> -----------------------------------------------------------------------
>
> Key: BVAL-29
> URL: https://issues.apache.org/jira/browse/BVAL-29
> Project: BeanValidation
> Issue Type: Bug
> Components: jsr303
> Affects Versions: 0.1-incubating
> Reporter: Carlos Vara
> Attachments: bval-jsr303.patch, ConstraintValidatorContextTest.java
>
>
> Call to inIterable() should modify the previous sibling node instead of the "current" node, and in case a null named non iterable node is left in the leaf of the path, it should never be added.
> This behavior is not documented in the JSR-303 spec document, but ConstraintValidatorContext Javadoc gives information on how it should work.
> Patch includes some tests that serve also as examples of this API usage.
> 1 more test passes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (BVAL-29) Defer node creation in implementation of
ConstraintViolationBuilder API
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BVAL-29?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Donald Woods reassigned BVAL-29:
--------------------------------
Assignee: Donald Woods
> Defer node creation in implementation of ConstraintViolationBuilder API
> -----------------------------------------------------------------------
>
> Key: BVAL-29
> URL: https://issues.apache.org/jira/browse/BVAL-29
> Project: BeanValidation
> Issue Type: Bug
> Components: jsr303
> Affects Versions: 0.1-incubating
> Reporter: Carlos Vara
> Assignee: Donald Woods
> Attachments: bval-jsr303.patch, ConstraintValidatorContextTest.java
>
>
> Call to inIterable() should modify the previous sibling node instead of the "current" node, and in case a null named non iterable node is left in the leaf of the path, it should never be added.
> This behavior is not documented in the JSR-303 spec document, but ConstraintValidatorContext Javadoc gives information on how it should work.
> Patch includes some tests that serve also as examples of this API usage.
> 1 more test passes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (BVAL-29) Defer node creation in implementation
of ConstraintViolationBuilder API
Posted by Roman Stumm <ro...@gmx.de>.
Carlos Vara (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/BVAL-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862369#action_12862369 ]
>
> Carlos Vara commented on BVAL-29:
> ---------------------------------
>
> Thanks for reviewing Donald. I will add the header and include new file additions in the patch in future fixes.
>
> Also, I usually separate the patches per project as I have them checked out individually. If you prefer them to be from the root of the svn just tell me.
>
>
>> Defer node creation in implementation of ConstraintViolationBuilder API
>> -----------------------------------------------------------------------
>>
>> Key: BVAL-29
>> URL: https://issues.apache.org/jira/browse/BVAL-29
>> Project: BeanValidation
>> Issue Type: Bug
>> Components: jsr303
>> Affects Versions: 0.1-incubating
>> Reporter: Carlos Vara
>> Assignee: Donald Woods
>> Fix For: 0.1-incubating
>>
>> Attachments: bval-jsr303.patch, ConstraintValidatorContextTest.java
>>
>>
>> Call to inIterable() should modify the previous sibling node instead of the "current" node, and in case a null named non iterable node is left in the leaf of the path, it should never be added.
>> This behavior is not documented in the JSR-303 spec document, but ConstraintValidatorContext Javadoc gives information on how it should work.
>> Patch includes some tests that serve also as examples of this API usage.
>> 1 more test passes.
>>
>
>
Hi Carlos,
I am satisfied with all of your patches in either form. I am glad, that
you have the motivation, time and understanding to submit those
high-quality patches. I always review them anyway and I, for my part,
have no problems with adding missing stuff.
So, what I wanted so say: Thanks for your work! Do you think, that
most/all the TCK tests, that fail can be fixed with minor changes like
those, that you have fixes so far? I am afraid, that especially those
about XML meta data, would cause more work before they pass....
Regards, Roman
Re: [jira] Commented: (BVAL-29) Defer node creation in implementation
of ConstraintViolationBuilder API
Posted by Carlos Vara <ba...@gmail.com>.
Thanks for the encouraging comments, to be honest I'm learning a lot while
doing the fixes so I should be the one being thankful.
Roman, about the XML meta data: that part and bootstrapping are the ones I
haven't looked into yet. Seeing as some XML tests are already passing, there
is the possibility that they can be fixed in a similar way, but I can't
foretell more now. Hopefully in a while we will know :-)
Regards,
Carlos
On Thu, Apr 29, 2010 at 9:03 PM, Donald Woods <dw...@apache.org> wrote:
> Patches per module is better if you're using Eclipse to generate the
> patches, as it strips off the module sub-dir.
>
> BTW - Thanks for all the great patches and keep up the good work! Just
> wanted to mention the header and svn add, as that will speed up applying
> patches and is one of the things we look for before voting someone in as
> a new committer... :-)
>
>
> -Donald
>
>
> On 4/29/10 3:40 PM, Carlos Vara (JIRA) wrote:
> >
> > [
> https://issues.apache.org/jira/browse/BVAL-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862369#action_12862369]
> >
> > Carlos Vara commented on BVAL-29:
> > ---------------------------------
> >
> > Thanks for reviewing Donald. I will add the header and include new file
> additions in the patch in future fixes.
> >
> > Also, I usually separate the patches per project as I have them checked
> out individually. If you prefer them to be from the root of the svn just
> tell me.
> >
> >> Defer node creation in implementation of ConstraintViolationBuilder API
> >> -----------------------------------------------------------------------
> >>
> >> Key: BVAL-29
> >> URL: https://issues.apache.org/jira/browse/BVAL-29
> >> Project: BeanValidation
> >> Issue Type: Bug
> >> Components: jsr303
> >> Affects Versions: 0.1-incubating
> >> Reporter: Carlos Vara
> >> Assignee: Donald Woods
> >> Fix For: 0.1-incubating
> >>
> >> Attachments: bval-jsr303.patch,
> ConstraintValidatorContextTest.java
> >>
> >>
> >> Call to inIterable() should modify the previous sibling node instead of
> the "current" node, and in case a null named non iterable node is left in
> the leaf of the path, it should never be added.
> >> This behavior is not documented in the JSR-303 spec document, but
> ConstraintValidatorContext Javadoc gives information on how it should work.
> >> Patch includes some tests that serve also as examples of this API usage.
> >> 1 more test passes.
> >
>
Re: [jira] Commented: (BVAL-29) Defer node creation in implementation
of ConstraintViolationBuilder API
Posted by Donald Woods <dw...@apache.org>.
Patches per module is better if you're using Eclipse to generate the
patches, as it strips off the module sub-dir.
BTW - Thanks for all the great patches and keep up the good work! Just
wanted to mention the header and svn add, as that will speed up applying
patches and is one of the things we look for before voting someone in as
a new committer... :-)
-Donald
On 4/29/10 3:40 PM, Carlos Vara (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/BVAL-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862369#action_12862369 ]
>
> Carlos Vara commented on BVAL-29:
> ---------------------------------
>
> Thanks for reviewing Donald. I will add the header and include new file additions in the patch in future fixes.
>
> Also, I usually separate the patches per project as I have them checked out individually. If you prefer them to be from the root of the svn just tell me.
>
>> Defer node creation in implementation of ConstraintViolationBuilder API
>> -----------------------------------------------------------------------
>>
>> Key: BVAL-29
>> URL: https://issues.apache.org/jira/browse/BVAL-29
>> Project: BeanValidation
>> Issue Type: Bug
>> Components: jsr303
>> Affects Versions: 0.1-incubating
>> Reporter: Carlos Vara
>> Assignee: Donald Woods
>> Fix For: 0.1-incubating
>>
>> Attachments: bval-jsr303.patch, ConstraintValidatorContextTest.java
>>
>>
>> Call to inIterable() should modify the previous sibling node instead of the "current" node, and in case a null named non iterable node is left in the leaf of the path, it should never be added.
>> This behavior is not documented in the JSR-303 spec document, but ConstraintValidatorContext Javadoc gives information on how it should work.
>> Patch includes some tests that serve also as examples of this API usage.
>> 1 more test passes.
>
[jira] Commented: (BVAL-29) Defer node creation in implementation
of ConstraintViolationBuilder API
Posted by "Carlos Vara (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BVAL-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862369#action_12862369 ]
Carlos Vara commented on BVAL-29:
---------------------------------
Thanks for reviewing Donald. I will add the header and include new file additions in the patch in future fixes.
Also, I usually separate the patches per project as I have them checked out individually. If you prefer them to be from the root of the svn just tell me.
> Defer node creation in implementation of ConstraintViolationBuilder API
> -----------------------------------------------------------------------
>
> Key: BVAL-29
> URL: https://issues.apache.org/jira/browse/BVAL-29
> Project: BeanValidation
> Issue Type: Bug
> Components: jsr303
> Affects Versions: 0.1-incubating
> Reporter: Carlos Vara
> Assignee: Donald Woods
> Fix For: 0.1-incubating
>
> Attachments: bval-jsr303.patch, ConstraintValidatorContextTest.java
>
>
> Call to inIterable() should modify the previous sibling node instead of the "current" node, and in case a null named non iterable node is left in the leaf of the path, it should never be added.
> This behavior is not documented in the JSR-303 spec document, but ConstraintValidatorContext Javadoc gives information on how it should work.
> Patch includes some tests that serve also as examples of this API usage.
> 1 more test passes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (BVAL-29) Defer node creation in implementation of
ConstraintViolationBuilder API
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BVAL-29?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Donald Woods resolved BVAL-29.
------------------------------
Fix Version/s: 0.1-incubating
Resolution: Fixed
Committed as r939404.
Carlos, don't forget to add the ASL 2.0 header on new files. Also, you can use "svn add" for new files (and Subclipse will allow you to do the same) and then the diff will contain the added files too.
> Defer node creation in implementation of ConstraintViolationBuilder API
> -----------------------------------------------------------------------
>
> Key: BVAL-29
> URL: https://issues.apache.org/jira/browse/BVAL-29
> Project: BeanValidation
> Issue Type: Bug
> Components: jsr303
> Affects Versions: 0.1-incubating
> Reporter: Carlos Vara
> Assignee: Donald Woods
> Fix For: 0.1-incubating
>
> Attachments: bval-jsr303.patch, ConstraintValidatorContextTest.java
>
>
> Call to inIterable() should modify the previous sibling node instead of the "current" node, and in case a null named non iterable node is left in the leaf of the path, it should never be added.
> This behavior is not documented in the JSR-303 spec document, but ConstraintValidatorContext Javadoc gives information on how it should work.
> Patch includes some tests that serve also as examples of this API usage.
> 1 more test passes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.