You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2020/04/22 05:44:41 UTC
Review Request 72413: Updated executor API docs to include the domain
socket.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72413/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Vinod Kone.
Repository: mesos
Description
-------
Updated executor API docs to include the domain socket.
Diffs
-----
docs/executor-http-api.md 4af4cd444dbeb29c115c46444dc01da0e86fd848
Diff: https://reviews.apache.org/r/72413/diff/1/
Testing
-------
Viewed with `site/mesos-website-dev.sh`.
Thanks,
Greg Mann
Re: Review Request 72413: Updated executor API docs to include the
domain socket.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72413/
-----------------------------------------------------------
(Updated April 28, 2020, 11:08 p.m.)
Review request for mesos, Benjamin Mahler and Vinod Kone.
Repository: mesos
Description
-------
Updated executor API docs to include the domain socket.
Diffs (updated)
-----
docs/executor-http-api.md 4af4cd444dbeb29c115c46444dc01da0e86fd848
Diff: https://reviews.apache.org/r/72413/diff/2/
Changes: https://reviews.apache.org/r/72413/diff/1-2/
Testing
-------
Viewed with `site/mesos-website-dev.sh`.
Thanks,
Greg Mann
Re: Review Request 72413: Updated executor API docs to include the
domain socket.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72413/#review220414
-----------------------------------------------------------
Patch looks great!
Reviews applied: [72413]
Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh
- Mesos Reviewbot
On April 22, 2020, 1:44 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72413/
> -----------------------------------------------------------
>
> (Updated April 22, 2020, 1:44 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated executor API docs to include the domain socket.
>
>
> Diffs
> -----
>
> docs/executor-http-api.md 4af4cd444dbeb29c115c46444dc01da0e86fd848
>
>
> Diff: https://reviews.apache.org/r/72413/diff/1/
>
>
> Testing
> -------
>
> Viewed with `site/mesos-website-dev.sh`.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72413: Updated executor API docs to include the
domain socket.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72413/#review220425
-----------------------------------------------------------
Fix it, then Ship it!
docs/executor-http-api.md
Lines 76 (patched)
<https://reviews.apache.org/r/72413/#comment308812>
Is the location also sent to the executor via an environment variable? If yes, we should specify the name of it. If not, I think that would make it hard to write a domain socket communicating executor?
- Vinod Kone
On April 22, 2020, 5:44 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72413/
> -----------------------------------------------------------
>
> (Updated April 22, 2020, 5:44 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated executor API docs to include the domain socket.
>
>
> Diffs
> -----
>
> docs/executor-http-api.md 4af4cd444dbeb29c115c46444dc01da0e86fd848
>
>
> Diff: https://reviews.apache.org/r/72413/diff/1/
>
>
> Testing
> -------
>
> Viewed with `site/mesos-website-dev.sh`.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72413: Updated executor API docs to include the
domain socket.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72413/#review220432
-----------------------------------------------------------
Fix it, then Ship it!
docs/executor-http-api.md
Lines 11-16 (original), 19-25 (patched)
<https://reviews.apache.org/r/72413/#comment308817>
Perhaps we should clarify that this is "legacy", or "deprecated" in favor of the HTTP API?
Importantly for users to know: we may or may not put new features into the driver, but we'll always include new features in the HTTP API
docs/executor-http-api.md
Line 51 (original), 72-78 (patched)
<https://reviews.apache.org/r/72413/#comment308819>
Kind of seems like this should be up in the overview where the agent endpoint is mentioned?
docs/executor-http-api.md
Lines 76 (patched)
<https://reviews.apache.org/r/72413/#comment308818>
This is an agent flag for how the operator configures the location, but to vinod's point, what the executor needs to care about is the MESOS_DOMAIN_SOCKET environment variable, right?
(FWICT, that's how the default executor determines what to do: https://github.com/apache/mesos/blob/00466fe6138138ead1ca676df37c3af69104956d/src/executor/executor.cpp#L240 )
- Benjamin Mahler
On April 22, 2020, 5:44 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72413/
> -----------------------------------------------------------
>
> (Updated April 22, 2020, 5:44 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated executor API docs to include the domain socket.
>
>
> Diffs
> -----
>
> docs/executor-http-api.md 4af4cd444dbeb29c115c46444dc01da0e86fd848
>
>
> Diff: https://reviews.apache.org/r/72413/diff/1/
>
>
> Testing
> -------
>
> Viewed with `site/mesos-website-dev.sh`.
>
>
> Thanks,
>
> Greg Mann
>
>