You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by xiaojian zhou <zh...@gmail.com> on 2016/02/01 04:20:30 UTC
Re: Review Request 43016: GEODE-869 / 883
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43016/#review117175
-----------------------------------------------------------
Ship it!
Others look good. I only have one question: In your diff, you did not remove "testOutput {...}" section from open/build.gradle. We still need it?
- xiaojian zhou
On Jan. 30, 2016, 5:45 p.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43016/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2016, 5:45 p.m.)
>
>
> Review request for geode, Dick Cavender, Kirk Lund, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-883: Reorganize code in gemfire-junit
>
> Move the code from src/test to src/main so that dependenct projects
> can use the junit annotations and rules. Update build dependencies
> from provided 'testOutput' to testCompile.
>
>
> GEODE-869: Include the source NOTICE in jar artifacts
>
>
> Diffs
> -----
>
> gemfire-assembly/build.gradle 3b2594c2d7207e1d741c3f7eb4671b88576688a2
> gemfire-common/build.gradle e28ba445104f3ca337756236a6ad6c4264c753de
> gemfire-core/build.gradle 719435017aaa24168bb70e1a2e329cd4987a473f
> gemfire-cq/build.gradle 35ee0fa543751a4d412c2b35fa675bbbece4187a
> gemfire-junit/build.gradle PRE-CREATION
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/ConditionalIgnore.java
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/IgnoreCondition.java
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/IgnoreUntil.java
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/Repeat.java
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/Retry.java
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/categories/ContainerTest.java
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/categories/DistributedTest.java
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/categories/DistributedTransactionsTest.java
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/categories/HydraTest.java
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/categories/IntegrationTest.java
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/categories/PerformanceTest.java
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/categories/UITest.java
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/categories/UnitTest.java
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/categories/WanTest.java
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/ConditionalIgnoreRule.java
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/ExpectedTimeout.java
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/ExpectedTimeoutRule.java
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/IgnoreUntilRule.java
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/RepeatRule.java
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/RetryRule.java
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/SerializableExternalResource.java
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/SerializableRuleChain.java
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/SerializableTemporaryFolder.java
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/SerializableTestName.java
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/SerializableTestRule.java
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/SerializableTestWatcher.java
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/rules/SerializableTimeout.java
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/support/DefaultIgnoreCondition.java
> gemfire-junit/src/test/java/com/gemstone/gemfire/test/junit/support/IgnoreConditionEvaluationException.java
> gemfire-lucene/build.gradle 6218e55c73f771a46a74ae31606ce1ace5b2008f
> gemfire-pulse/build.gradle 3d694e580c49961ae94e4db086d0f50c9bd81a50
> gemfire-rebalancer/build.gradle 1f9bff8d7d37700627ca1b6e8aa74827d59b76d4
> gemfire-wan/build.gradle 35ee0fa543751a4d412c2b35fa675bbbece4187a
> gemfire-web/build.gradle 596590b1c96e016e2dd927a21dc50d2e373b62b2
> gradle/java.gradle 3ec105d7a37fd036527ea6f78c61f7dbcca3244d
>
> Diff: https://reviews.apache.org/r/43016/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>