You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by mb...@apache.org on 2020/02/25 19:32:12 UTC

[ofbiz-framework] branch trunk updated: Improved: Performance optimization for entities in xml data export.

This is an automated email from the ASF dual-hosted git repository.

mbrohl pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 74db8bd  Improved: Performance optimization for entities in xml data export.
74db8bd is described below

commit 74db8bde12ef853882b3fb5941d812dfd52f3d9f
Author: Michael Brohl <mb...@apache.org>
AuthorDate: Tue Feb 25 20:31:53 2020 +0100

    Improved: Performance optimization for entities in xml data export.
    
    (OFBIZ-10157)
    
    Thanks Kyra Pritzel-Hentley for reporting and providing the patch.
---
 framework/webtools/groovyScripts/entity/XmlDsDump.groovy | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/framework/webtools/groovyScripts/entity/XmlDsDump.groovy b/framework/webtools/groovyScripts/entity/XmlDsDump.groovy
index 3fe4ebb..54844a8 100644
--- a/framework/webtools/groovyScripts/entity/XmlDsDump.groovy
+++ b/framework/webtools/groovyScripts/entity/XmlDsDump.groovy
@@ -180,7 +180,7 @@ if (passedEntityNames) {
         session.setAttribute("xmlrawdump_entitylist", passedEntityNames)
         session.setAttribute("entityDateCond", entityDateCond)
     } else {
-        efo = new EntityFindOptions(true, EntityFindOptions.TYPE_SCROLL_INSENSITIVE, EntityFindOptions.CONCUR_READ_ONLY, true)
+        efo = new EntityFindOptions(true, EntityFindOptions.TYPE_SCROLL_INSENSITIVE, EntityFindOptions.CONCUR_READ_ONLY, false)
         numberOfEntities = passedEntityNames?.size() ?: 0
         context.numberOfEntities = numberOfEntities
         numberWritten = 0
@@ -206,9 +206,9 @@ if (passedEntityNames) {
                 try {
                     me = reader.getModelEntity(curEntityName)
                     if (me.getNoAutoStamp() || me instanceof ModelViewEntity) {
-                        values = delegator.find(curEntityName, null, null, null, me.getPkFieldNames(), efo)
+                        values = delegator.find(curEntityName, null, null, null, null, efo)
                     } else {
-                        values = delegator.find(curEntityName, entityDateCond, null, null, UtilMisc.toList("-createdTxStamp"), efo)
+                        values = delegator.find(curEntityName, entityDateCond, null, null, null, efo)
                     }
     
                     curNumberWritten = 0
@@ -261,9 +261,9 @@ if (passedEntityNames) {
                             return
                         }
                         if (me.getNoAutoStamp() || me instanceof ModelViewEntity) {
-                            values = delegator.find(curEntityName, null, null, null, me.getPkFieldNames(), efo)
+                            values = delegator.find(curEntityName, null, null, null, null, efo)
                         } else {
-                            values = delegator.find(curEntityName, entityDateCond, null, null, me.getPkFieldNames(), efo)
+                            values = delegator.find(curEntityName, entityDateCond, null, null, null, efo)
                         }
                         isFirst = true
                         writer = null