[GitHub] [arrow-datafusion] mrob95 commented on pull request #2812: Allow setting of config options via environment variables

[GitBox <gi...@apache.org>]

mrob95 commented on PR #2812:
URL: https://github.com/apache/arrow-datafusion/pull/2812#issuecomment-1171062961

   > Since DataFusion can be used in various contexts inside other systems, I would like to be able to disable the "take configs from the environment" behavior to allow people to turn off potential "back doors" -- for example, I do not want to allow users of IOx, my project, to override internal datafusion settings via the environment.
   > So perhaps we could add a ConfigOptions::from_env() function rather than parsing environment from new()
   
   Good point. Is the intention of this feature to mainly be used for `datafusion-cli` and similar programs where the user doesn't have direct access to the session?
   
   If so I think your suggestion (or maybe a flag passed to `new`?) would work fine - `datafusion-cli` could use the env version and everyone else could use the normal version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org