[jira] [Reopened] (HBASE-24788) Fix the connection leaks on getting hbase admin from unclosed connection

["Sean Busbey (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-24788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sean Busbey reopened HBASE-24788:
---------------------------------

this change broke source compatibility by removing the throws for {{InterruptedException}} from the {{getRecordWriter}} and {{checkOutputSpecs}} methods of {{TableOutputFormat}}.

I don't see any discussion of doing so, so I am guessing it was an oversight. Normally we don't allow these kinds of changes in maintenance or minor releases.

[~tedyu@apache.org], [~vjasani], and [~bharathv]: please fix for at least branch-1, branch-2, branch-2.3, and branch-2.2. If you want to keep the removal for master please flag the change as incompatible and release note it apparently.

> Fix the connection leaks on getting hbase admin from unclosed connection
> ------------------------------------------------------------------------
>
>                 Key: HBASE-24788
>                 URL: https://issues.apache.org/jira/browse/HBASE-24788
>             Project: HBase
>          Issue Type: Bug
>          Components: mapreduce
>    Affects Versions: 3.0.0-alpha-1, 2.3.0, 1.6.0
>            Reporter: Sandeep Pal
>            Assignee: Sandeep Pal
>            Priority: Major
>             Fix For: 3.0.0-alpha-1, 2.3.1, 1.7.0, 2.4.0, 2.2.7
>
>
> Observed the significant increase in ZK connection on performance testing on map reduce jobs. Turns out the [TableOutputFormat.checkOutputSpecs()|https://github.com/apache/hbase/blob/master/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/TableOutputFormat.java#L182]  is not closing the connection it uses to get the hbase admin. It closes the hbase admin but never close the connection to get the admin.  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)