[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #14440: fix: add timeout when delete topic

[GitBox <gi...@apache.org>]

michaeljmarshall commented on a change in pull request #14440:
URL: https://github.com/apache/pulsar/pull/14440#discussion_r814503273



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -309,7 +309,8 @@ protected void internalDeleteTopicForcefully(boolean authoritative, boolean dele
         validateNamespaceOperation(topicName.getNamespaceObject(), NamespaceOperation.DELETE_TOPIC);
 
         try {
-            pulsar().getBrokerService().deleteTopic(topicName.toString(), true, deleteSchema).get();

Review comment:
       There are several places in these "Base" classes that we call `.get()`. I think it's worth looking a bit closer to see why this is no longer working. I assume that it worked at one point.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org