[jira] [Commented] (TINKERPOP3-765) Better Enforce Semantics of a Listener per Transaction

["stephen mallette (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP3-765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14649136#comment-14649136 ] 

stephen mallette commented on TINKERPOP3-765:
---------------------------------------------

I think {{AbstractTransaction}} is bound too tightly to the {{ThreadLocal}} concept.  That doesn't work too well for graphs implementing threaded transaction and that then want to use that class.  I think the better approach is to remove the implementation of the "listener" methods from {{AbstractTransaction}} and re-implement them in two sub-classes: one for {{ThreadLocal}} implementations as it is now and one that assumes concurrent access.  Implementers can then choose which is right for them to base their implementation on.  Another reason to bump this to 3.1.0 given some API change.

> Better Enforce Semantics of a Listener per Transaction
> ------------------------------------------------------
>
>                 Key: TINKERPOP3-765
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP3-765
>             Project: TinkerPop 3
>          Issue Type: Improvement
>          Components: process, structure
>    Affects Versions: 3.0.0-incubating
>            Reporter: stephen mallette
>            Assignee: stephen mallette
>             Fix For: 3.1.0-incubating
>
>
> {{EventStrategy}} uses the listeners available on {{Transaction}} implementations to know when events should be fired (i.e. per transaction).  Validate that there are no listener leaks in this model and consider methods for improvement if possible.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)