[GitHub] [activemq-artemis] brusdev commented on a diff in pull request #4460: ARTEMIS-4265 make more web console tabs conditional on permission

["brusdev (via GitHub)" <gi...@apache.org>]

brusdev commented on code in PR #4460:
URL: https://github.com/apache/activemq-artemis/pull/4460#discussion_r1185840593


##########
tests/smoke-tests/src/test/java/org/apache/activemq/artemis/tests/smoke/console/QueuesTest.java:
##########
@@ -60,6 +62,89 @@ public void testDefaultQueues() throws Exception {
       assertEquals(0, queuesPage.getMessagesCount("ExpiryQueue"));
    }
 
+   @Test
+   public void testConnectionsTab() {

Review Comment:
   Nice tests but they don't seem related to queues, could you move them to a new test class, i.e. `TabsTest` or any other names?



##########
tests/smoke-tests/src/test/java/org/apache/activemq/artemis/tests/smoke/console/QueuesTest.java:
##########
@@ -60,6 +62,89 @@ public void testDefaultQueues() throws Exception {
       assertEquals(0, queuesPage.getMessagesCount("ExpiryQueue"));
    }
 
+   @Test
+   public void testConnectionsTab() {

Review Comment:
   Nice tests but they don't seem related to queues, could you move them to a new test class, i.e. `TabsTest` or any other names?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org