You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "deepujain (via GitHub)" <gi...@apache.org> on 2026/09/07 17:55:40 UTC

[PR] Avoid reserializing the whole bundle in DAG.test (#72513) [airflow]

deepujain opened a new pull request, #72658:
URL: https://github.com/apache/airflow/pull/72658

   ## What changed
   
   - re-sync only the owning DAG source file when it is available
   - retain sibling DAG synchronization for same-file TriggerDagRun targets
   - fall back to the complete bundle for packaged or unavailable source files
   
   ## Validation
   
   - `git diff --check`
   - Added a regression assertion that `DAG.test()` parses the parent source file rather than its whole bundle.
   
   AI-assisted implementation; reviewed and validated by the contributor.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Avoid reserializing the whole bundle in DAG.test (#72513) [airflow]

Posted by "deepujain (via GitHub)" <gi...@apache.org>.
deepujain commented on PR #72658:
URL: https://github.com/apache/airflow/pull/72658#issuecomment-5789212798

   Updated the source-file parsing fix to main at b6538c32. The 10 focused Dag.test tests pass in Breeze; Ruff lint and formatting checks also pass. Fresh hosted CI is starting on the updated head.
   
   ---
   Drafted-by: OpenAI Codex (no human review before posting)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Avoid reserializing the whole bundle in DAG.test (#72513) [airflow]

Posted by "deepujain (via GitHub)" <gi...@apache.org>.
deepujain commented on PR #72658:
URL: https://github.com/apache/airflow/pull/72658#issuecomment-5748220366

   The lowest-deps CI failure (`test_form_parser_error_keeps_its_own_detail`, 422 vs 400) traces to the starlette floor on this branch. With `starlette>=1.0.1`, the urlencoded form parser does not bound the field count, so the 2000-field test body parses cleanly and then fails pydantic validation (422) instead of raising starlette's own 400. Upstream addressed this in #73302 by raising the floor to `starlette>=1.3.1`, whose `FormParser` enforces `max_fields` and reports a 400.
   
   I have cherry-picked #73302 onto this branch so the lowest-deps job resolves the bounded parser. No changes to the PR's own code; CI should go green on the rerun.
   
   ---
   Drafted-by: Muse Spark (Meta) (no human review before posting)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Avoid reserializing the whole bundle in DAG.test [airflow]

Posted by "deepujain (via GitHub)" <gi...@apache.org>.
deepujain closed pull request #72658: Avoid reserializing the whole bundle in DAG.test
URL: https://github.com/apache/airflow/pull/72658


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Avoid reserializing the whole bundle in DAG.test [airflow]

Posted by "deepujain (via GitHub)" <gi...@apache.org>.
deepujain commented on PR #72658:
URL: https://github.com/apache/airflow/pull/72658#issuecomment-6113686993

   Thanks for maintaining this project. I've kept this PR rebased and up to date, but it hasn't found a reviewer yet, so I'm closing it to keep your queue tidy. Happy to reopen and rebase anytime if it's still useful.
   
   Effort: open since Sep 7, 2026, 4 updates posted, 4 commits, +20 −7 across 2 files, checks green on the latest commit, fixes #72513.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Avoid reserializing the whole bundle in DAG.test (#72513) [airflow]

Posted by "deepujain (via GitHub)" <gi...@apache.org>.
deepujain commented on PR #72658:
URL: https://github.com/apache/airflow/pull/72658#issuecomment-5779976577

   Updated this branch to current main and retained the source-file parsing change and its bundle fallback. The focused Dag.test tests pass in Breeze, and Ruff checks pass. The PR body now includes the explicit Gen-AI disclosure; hosted CI is running again.
   
   ---
   Drafted-by: OpenAI Codex (no human review before posting)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Avoid reserializing the whole bundle in DAG.test [airflow]

Posted by "deepujain (via GitHub)" <gi...@apache.org>.
deepujain commented on PR #72658:
URL: https://github.com/apache/airflow/pull/72658#issuecomment-6104939501

   @ashb @kaxil @amoghrajesh Checks are green on the latest commit. Could you review this when you have a chance?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org