You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2017/07/06 18:39:57 UTC
Review Request 60689: Upgrade Infra Solr version from 5.5.2 to 6.6.x
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60689/
-----------------------------------------------------------
Review request for Ambari, Miklos Gergely and Robert Nettleton.
Bugs: AMBARI-21400
https://issues.apache.org/jira/browse/AMBARI-21400
Repository: ambari
Description
-------
- upgrade solr version to 6.6.0
- update custom solr start script (add 6.6.0 custom changes)
- add new solr client command (--remove-admin-handlers) -> its required for solr 6, using AdminHandlers class was deprecated in Solr 5, in Solr 6, it does not exists, so throws runtime expection in solr node. This command will run before solr starts.
- handle ambari upgrade scenario
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py 1c5432b
ambari-infra/ambari-infra-assembly/src/main/resources/solr bf504d9
ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudCLI.java e3a1e79
ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudClient.java 9479679
ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/RemoveAdminHandlersCommand.java PRE-CREATION
ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/SetClusterPropertyZkCommand.java 34597c6
ambari-infra/ambari-infra-solr-plugin/src/test/java/org/apache/ambari/infra/security/InfraRuleBasedAuthorizationPluginTest.java ee84969
ambari-infra/pom.xml 4f5c29c
ambari-logsearch/ambari-logsearch-server/src/main/configsets/audit_logs/conf/solrconfig.xml 7af91df
ambari-logsearch/ambari-logsearch-server/src/main/configsets/hadoop_logs/conf/solrconfig.xml 59f778f
ambari-logsearch/ambari-logsearch-server/src/main/configsets/history/conf/solrconfig.xml 8244a08
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/SolrSchemaFieldDao.java d99694b
ambari-logsearch/docker/Dockerfile 2b8fd5d
ambari-logsearch/docker/bin/start.sh 28ebf65
ambari-logsearch/pom.xml 82943e4
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java 5fdc885
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py 5f547f3
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/setup_infra_solr.py f3dbcf3
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/audit_logs-solrconfig.xml.j2 63879e7
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/service_logs-solrconfig.xml.j2 b6a4d1d
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java a342baa
ambari-server/src/test/python/stacks/2.4/AMBARI_INFRA/test_infra_solr.py 87304cd
Diff: https://reviews.apache.org/r/60689/diff/1/
Testing
-------
unit tests done. + manual testing, there are some more use cases ...
Thanks,
Oliver Szabo
Re: Review Request 60689: Upgrade Infra Solr version from 5.5.2 to
6.6.x
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60689/#review179860
-----------------------------------------------------------
Ship it!
Ship It!
- Miklos Gergely
On July 6, 2017, 6:41 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60689/
> -----------------------------------------------------------
>
> (Updated July 6, 2017, 6:41 p.m.)
>
>
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
>
>
> Bugs: AMBARI-21400
> https://issues.apache.org/jira/browse/AMBARI-21400
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - upgrade solr version to 6.6.0
> - update custom solr start script (add 6.6.0 custom changes)
> - add new solr client command (--remove-admin-handlers) -> its required for solr 6, using AdminHandlers class was deprecated in Solr 5, in Solr 6, it does not exists, so throws runtime expection in solr node. This command will run before solr starts.
> - handle ambari upgrade scenario
>
> (note: this change does not contain index migration changes, there will be a command for that as well, but that should be some manual step)
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py 1c5432b
> ambari-infra/ambari-infra-assembly/src/main/resources/solr bf504d9
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudCLI.java e3a1e79
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudClient.java 9479679
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/RemoveAdminHandlersCommand.java PRE-CREATION
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/SetClusterPropertyZkCommand.java 34597c6
> ambari-infra/ambari-infra-solr-plugin/src/test/java/org/apache/ambari/infra/security/InfraRuleBasedAuthorizationPluginTest.java ee84969
> ambari-infra/pom.xml 4f5c29c
> ambari-logsearch/ambari-logsearch-server/src/main/configsets/audit_logs/conf/solrconfig.xml 7af91df
> ambari-logsearch/ambari-logsearch-server/src/main/configsets/hadoop_logs/conf/solrconfig.xml 59f778f
> ambari-logsearch/ambari-logsearch-server/src/main/configsets/history/conf/solrconfig.xml 8244a08
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/SolrSchemaFieldDao.java d99694b
> ambari-logsearch/docker/Dockerfile 2b8fd5d
> ambari-logsearch/docker/bin/start.sh 28ebf65
> ambari-logsearch/pom.xml 82943e4
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java 5fdc885
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py 5f547f3
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/setup_infra_solr.py f3dbcf3
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/audit_logs-solrconfig.xml.j2 63879e7
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/service_logs-solrconfig.xml.j2 b6a4d1d
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java a342baa
> ambari-server/src/test/python/stacks/2.4/AMBARI_INFRA/test_infra_solr.py 87304cd
>
>
> Diff: https://reviews.apache.org/r/60689/diff/1/
>
>
> Testing
> -------
>
> unit tests done. + manual testing, there are some more use cases ...
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 60689: Upgrade Infra Solr version from 5.5.2 to
6.6.x
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60689/#review179820
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On July 6, 2017, 6:41 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60689/
> -----------------------------------------------------------
>
> (Updated July 6, 2017, 6:41 p.m.)
>
>
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
>
>
> Bugs: AMBARI-21400
> https://issues.apache.org/jira/browse/AMBARI-21400
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - upgrade solr version to 6.6.0
> - update custom solr start script (add 6.6.0 custom changes)
> - add new solr client command (--remove-admin-handlers) -> its required for solr 6, using AdminHandlers class was deprecated in Solr 5, in Solr 6, it does not exists, so throws runtime expection in solr node. This command will run before solr starts.
> - handle ambari upgrade scenario
>
> (note: this change does not contain index migration changes, there will be a command for that as well, but that should be some manual step)
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py 1c5432b
> ambari-infra/ambari-infra-assembly/src/main/resources/solr bf504d9
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudCLI.java e3a1e79
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudClient.java 9479679
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/RemoveAdminHandlersCommand.java PRE-CREATION
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/SetClusterPropertyZkCommand.java 34597c6
> ambari-infra/ambari-infra-solr-plugin/src/test/java/org/apache/ambari/infra/security/InfraRuleBasedAuthorizationPluginTest.java ee84969
> ambari-infra/pom.xml 4f5c29c
> ambari-logsearch/ambari-logsearch-server/src/main/configsets/audit_logs/conf/solrconfig.xml 7af91df
> ambari-logsearch/ambari-logsearch-server/src/main/configsets/hadoop_logs/conf/solrconfig.xml 59f778f
> ambari-logsearch/ambari-logsearch-server/src/main/configsets/history/conf/solrconfig.xml 8244a08
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/SolrSchemaFieldDao.java d99694b
> ambari-logsearch/docker/Dockerfile 2b8fd5d
> ambari-logsearch/docker/bin/start.sh 28ebf65
> ambari-logsearch/pom.xml 82943e4
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java 5fdc885
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py 5f547f3
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/setup_infra_solr.py f3dbcf3
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/audit_logs-solrconfig.xml.j2 63879e7
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/service_logs-solrconfig.xml.j2 b6a4d1d
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java a342baa
> ambari-server/src/test/python/stacks/2.4/AMBARI_INFRA/test_infra_solr.py 87304cd
>
>
> Diff: https://reviews.apache.org/r/60689/diff/1/
>
>
> Testing
> -------
>
> unit tests done. + manual testing, there are some more use cases ...
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 60689: Upgrade Infra Solr version from 5.5.2 to
6.6.x
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60689/
-----------------------------------------------------------
(Updated July 6, 2017, 6:41 p.m.)
Review request for Ambari, Miklos Gergely and Robert Nettleton.
Changes
-------
add note
Bugs: AMBARI-21400
https://issues.apache.org/jira/browse/AMBARI-21400
Repository: ambari
Description (updated)
-------
- upgrade solr version to 6.6.0
- update custom solr start script (add 6.6.0 custom changes)
- add new solr client command (--remove-admin-handlers) -> its required for solr 6, using AdminHandlers class was deprecated in Solr 5, in Solr 6, it does not exists, so throws runtime expection in solr node. This command will run before solr starts.
- handle ambari upgrade scenario
(note: this change does not contain index migration changes, there will be a command for that as well, but that should be some manual step)
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py 1c5432b
ambari-infra/ambari-infra-assembly/src/main/resources/solr bf504d9
ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudCLI.java e3a1e79
ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudClient.java 9479679
ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/RemoveAdminHandlersCommand.java PRE-CREATION
ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/SetClusterPropertyZkCommand.java 34597c6
ambari-infra/ambari-infra-solr-plugin/src/test/java/org/apache/ambari/infra/security/InfraRuleBasedAuthorizationPluginTest.java ee84969
ambari-infra/pom.xml 4f5c29c
ambari-logsearch/ambari-logsearch-server/src/main/configsets/audit_logs/conf/solrconfig.xml 7af91df
ambari-logsearch/ambari-logsearch-server/src/main/configsets/hadoop_logs/conf/solrconfig.xml 59f778f
ambari-logsearch/ambari-logsearch-server/src/main/configsets/history/conf/solrconfig.xml 8244a08
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/SolrSchemaFieldDao.java d99694b
ambari-logsearch/docker/Dockerfile 2b8fd5d
ambari-logsearch/docker/bin/start.sh 28ebf65
ambari-logsearch/pom.xml 82943e4
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java 5fdc885
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py 5f547f3
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/setup_infra_solr.py f3dbcf3
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/audit_logs-solrconfig.xml.j2 63879e7
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/service_logs-solrconfig.xml.j2 b6a4d1d
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java a342baa
ambari-server/src/test/python/stacks/2.4/AMBARI_INFRA/test_infra_solr.py 87304cd
Diff: https://reviews.apache.org/r/60689/diff/1/
Testing
-------
unit tests done. + manual testing, there are some more use cases ...
Thanks,
Oliver Szabo