You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@sedona.apache.org by "jiayuasu (via GitHub)" <gi...@apache.org> on 2026/10/20 19:27:27 UTC

[PR] ci: run pre-commit on Python 3.14 [sedona-db]

jiayuasu opened a new pull request, #1471:
URL: https://github.com/apache/sedona-db/pull/1471

   ## What changes
   
   The `pre-commit` job in `dev.yml` sets up Python `'3.x'`, which now resolves to 3.15.0. On 3.15 the `cmake-format` hook fails on every CMake file: cmakelang (last released in 2021) passes capturing groups to `re.Scanner`, which Python 3.15 rejects:
   
   ```
   ValueError: Cannot use capturing groups in re.Scanner
   ```
   
   This fails `pre-commit` on PRs that touch no CMake file (e.g. #1466, #1469, #1470), and only on some runs: the cache key (`pre-commit-<hash of .pre-commit-config.yaml>`) doesn't include the Python version, so a run restores hook environments built for whichever Python populated the cache.
   
   This pins the job to Python 3.14 and adds the resolved Python version to the cache key, so hook environments are only reused with the Python they were built for.
   
   ## Testing
   
   `cmake-format --check` (cmakelang 0.6.13) passes on Python 3.14 locally; the failure is from the CI log of the 3.15 runs. This PR's own `pre-commit` run checks the pinned setup.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci: run pre-commit on Python 3.14 [sedona-db]

Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu merged PR #1471:
URL: https://github.com/apache/sedona-db/pull/1471


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org