You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2018/05/16 17:56:57 UTC
Review Request 67153: Enforced that `allowed_devices` entries must
have a path.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67153/
-----------------------------------------------------------
Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
Bugs: MESOS-8792
https://issues.apache.org/jira/browse/MESOS-8792
Repository: mesos
Description
-------
If the operator omitted the `path` field from the
`allowed_devices` entry, the `cgroups/devices` isolator would
silently ignore the entry. Change this to an error to make
the behavior consistent with `linux/devices` and to make it
clear to operators that the configuration is incomplete.
Diffs
-----
src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.cpp 5d44b14ef2604e81f1e6d80c5d4aaa6b240cdee0
Diff: https://reviews.apache.org/r/67153/diff/1/
Testing
-------
make check (Fedora 27)
Thanks,
James Peach
Re: Review Request 67153: Enforced that `allowed_devices` entries
must have a path.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67153/#review203350
-----------------------------------------------------------
PASS: Mesos patch 67153 was successfully built and tested.
Reviews applied: `['67094', '67095', '67096', '67097', '67098', '67145', '67153']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67153
- Mesos Reviewbot Windows
On May 16, 2018, 5:56 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67153/
> -----------------------------------------------------------
>
> (Updated May 16, 2018, 5:56 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
>
>
> Bugs: MESOS-8792
> https://issues.apache.org/jira/browse/MESOS-8792
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If the operator omitted the `path` field from the
> `allowed_devices` entry, the `cgroups/devices` isolator would
> silently ignore the entry. Change this to an error to make
> the behavior consistent with `linux/devices` and to make it
> clear to operators that the configuration is incomplete.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.cpp 5d44b14ef2604e81f1e6d80c5d4aaa6b240cdee0
>
>
> Diff: https://reviews.apache.org/r/67153/diff/2/
>
>
> Testing
> -------
>
> make check (Fedora 27)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 67153: Enforced that `allowed_devices` entries
must have a path.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67153/#review203270
-----------------------------------------------------------
PASS: Mesos patch 67153 was successfully built and tested.
Reviews applied: `['67094', '67095', '67096', '67097', '67098', '67145', '67153']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67153
- Mesos Reviewbot Windows
On May 16, 2018, 5:56 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67153/
> -----------------------------------------------------------
>
> (Updated May 16, 2018, 5:56 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
>
>
> Bugs: MESOS-8792
> https://issues.apache.org/jira/browse/MESOS-8792
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If the operator omitted the `path` field from the
> `allowed_devices` entry, the `cgroups/devices` isolator would
> silently ignore the entry. Change this to an error to make
> the behavior consistent with `linux/devices` and to make it
> clear to operators that the configuration is incomplete.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.cpp 5d44b14ef2604e81f1e6d80c5d4aaa6b240cdee0
>
>
> Diff: https://reviews.apache.org/r/67153/diff/1/
>
>
> Testing
> -------
>
> make check (Fedora 27)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 67153: Enforced that `allowed_devices` entries
must have a path.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67153/#review203679
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On May 16, 2018, 5:56 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67153/
> -----------------------------------------------------------
>
> (Updated May 16, 2018, 5:56 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
>
>
> Bugs: MESOS-8792
> https://issues.apache.org/jira/browse/MESOS-8792
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If the operator omitted the `path` field from the `allowed_devices`
> entry, the `cgroups/devices` isolator would silently ignore the
> entry. Change this to an error to make the behavior consistent
> with `linux/devices` and to make it clear to operators that the
> configuration is incomplete.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.cpp 5d44b14ef2604e81f1e6d80c5d4aaa6b240cdee0
> src/slave/containerizer/mesos/isolators/linux/devices.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/67153/diff/3/
>
>
> Testing
> -------
>
> make check (Fedora 27)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 67153: Enforced that `allowed_devices` entries
must have a path.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67153/#review203667
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['67094', '67095', '67096', '67097', '67098', '67145', '67153']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67153
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67153/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (110 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1022 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (36 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (42 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (81 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (750 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (773 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (732 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (757 ms total)
[----------] Global test environment tear-down
[==========] 981 tests from 95 test cases ran. (436982 ms total)
[ PASSED ] 980 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] DockerContainerizerHealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange
1 FAILED TEST
YOU HAVE 220 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67153/logs/mesos-tests-stderr.log):
```
I0523 16:35:58.974903 16972 master.cpp:10843] Updating the state of task f279099f-65e9-4080-9225-e3e48dc09412 of framework 2dd4c8e7-e60b-429b-aabe-7a9bb4c1e32a-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0523 16:35:58.974903 11692 slave.cpp:3935] Shutting down framework 2dd4c8e7-e60b-429b-aabe-7a9bb4c1e32a-0000
I0523 16:35:58.974903 11692 slave.cpp:6656] Shutting down executor 'f279099f-65e9-4080-9225-e3e48dc09412' of framework 2dd4c8e7-e60b-429b-aabe-7a9bb4c1e32a-0000 at executor(1)@192.10.1.6:53143
I0523 16:35:58.976881 I0523 16:35:58.806865 8724 exec.cpp:162] Version: 1.7.0
I0523 16:35:58.833901 14820 exec.cpp:236] Executor registered on agent 2dd4c8e7-e60b-429b-aabe-7a9bb4c1e32a-S0
I0523 16:35:58.837903 13384 executor.cpp:178] Received SUBSCRIBED event
I0523 16:35:58.842900 13384 executor.cpp:182] Subscribed executor on windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net
I0523 16:35:58.842900 13384 executor.cpp:178] Received LAUNCH event
I0523 16:35:58.848882 13384 executor.cpp:665] Starting task f279099f-65e9-4080-9225-e3e48dc09412
I0523 16:35:58.933892 13384 executor.cpp:485] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0523 16:35:58.949884 13384 executor.cpp:678] Forked command at 17596
I0523 16:35:58.976881 12836 exec.cpp:445] Executor asked to shutdown
I0523 16:35:58.976881 14492 executor.cpp:178] Received SHUTDOWN event
I0523 16:35:58.976881 14492 executor.cpp:781] Shutting down
I0523 16:35:58.976881 14492 executor.cpp:894] Sending SIGTERM to process tree at pid 1711692 slave.cpp:929] Agent terminating
W0523 16:35:58.976881 11692 slave.cpp:3931] Ignoring shutdown framework 2dd4c8e7-e60b-429b-aabe-7a9bb4c1e32a-0000 because it is terminating
I0523 16:35:58.976881 16972 master.cpp:10942] Removing task f279099f-65e9-4080-9225-e3e48dc09412 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 2dd4c8e7-e60b-429b-aabe-7a9bb4c1e32a-0000 on agent 2dd4c8e7-e60b-429b-aabe-7a9bb4c1e32a-S0 at slave(448)@192.10.1.6:53122 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0523 16:35:58.980872 16972 master.cpp:1293] Agent 2dd4c8e7-e60b-429b-aabe-7a9bb4c1e32a-S0 at slave(448)@192.10.1.6:53122 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected
I0523 16:35:58.980872 16972 master.cpp:3303] Disconnecting agent 2dd4c8e7-e60b-429b-aabe-7a9bb4c1e32a-S0 at slave(448)@192.10.1.6:53122 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0523 16:35:58.980872 16972 master.cpp:3322] Deactivating agent 2dd4c8e7-e60b-429b-aabe-7a9bb4c1e32a-S0 at slave(448)@192.10.1.6:53122 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0523 16:35:58.980872 10848 hierarchical.cpp:344] Removed framework 2dd4c8e7-e60b-429b-aabe-7a9bb4c1e32a-0000
I0523 16:35:58.981889 10848 hierarchical.cpp:766] Agent 2dd4c8e7-e60b-429b-aabe-7a9bb4c1e32a-S0 deactivated
I0523 16:35:58.981889 19732 containerizer.cpp:2384] Destroying container c774c521-63d9-44c8-a069-cf934b8d9d46 in RUNNING state
I0523 16:35:58.981889 19732 containerizer.cpp:2998] Transitioning the state of container c774c521-63d9-44c8-a069-cf934b8d9d46 from RUNNING to DESTROYING
I0523 16:35:58.982885 19732 launcher.cpp:156] Asked to destroy container c774c521-63d9-44c8-a069-cf934b8d9d46
I0523 16:35:59.039212 19640 containerizer.cpp:2837] Container c774c521-63d9-44c8-a069-cf934b8d9d46 has exited
I0523 16:35:59.069211 12960 master.cpp:1135] Master terminating
I0523 16:35:59.071208 16972 hierarchical.cpp:609] Removed agent 2dd4c8e7-e60b-429b-aabe-7a9bb4c1e32a-S0
I0523 16:35:59.456192 16164 process.cpp:940] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On May 16, 2018, 5:56 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67153/
> -----------------------------------------------------------
>
> (Updated May 16, 2018, 5:56 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
>
>
> Bugs: MESOS-8792
> https://issues.apache.org/jira/browse/MESOS-8792
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If the operator omitted the `path` field from the `allowed_devices`
> entry, the `cgroups/devices` isolator would silently ignore the
> entry. Change this to an error to make the behavior consistent
> with `linux/devices` and to make it clear to operators that the
> configuration is incomplete.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.cpp 5d44b14ef2604e81f1e6d80c5d4aaa6b240cdee0
> src/slave/containerizer/mesos/isolators/linux/devices.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/67153/diff/3/
>
>
> Testing
> -------
>
> make check (Fedora 27)
>
>
> Thanks,
>
> James Peach
>
>