Re: cvs commit: xml-axis/java/src/org/apache/axis/wsdl/toJava Emi tter.java

[Russell Butek <bu...@us.ibm.com>]

Hey Tom/Simon,

I think we're overengineering this thing.  We're trying to parse a context
for the uri we have.  This context eventually makes it to a call to "new
URL(context, url)".  It's perfectly legitimate, in this call, to pass the
url itself as the context:  "new URL(url, url)".  I tried this and the
tests pass.  Unless you folks have reservations about doing this I'll
commit it.

Russell Butek
butek@us.ibm.com


Simon Fell <so...@zaks.demon.co.uk> on 01/24/2002 03:57:11 PM

Please respond to axis-dev@xml.apache.org

To:    axis-dev@xml.apache.org
cc:
Subject:    Re: cvs commit: xml-axis/java/src/org/apache/axis/wsdl/toJava
       Emi  tter.java



On Thu, 24 Jan 2002 16:45:26 -0500, in soap you wrote:

>
>It breaks.
>
>I knew this fix was bad 2 minutes after I checked it in.
>But the way the code was broke url's like this on Windows:
>   file:///d:\foo\bar\baz.wsdl
>
>We have to take in to account the both forward and backward slashes
>are legal in file URLs on Windows.
>
>Suggestions on a correct fix are welcome. :-)

The attached diff seems reasonable to me, although it doesn't actually
appear to work for file URL's :(  I end up with an
unknownHostException.

If i have time later, i'll dig a bit deeper.

Cheers
Simon