You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/05/29 11:06:14 UTC
[GitHub] [dolphinscheduler] 106umao opened a new pull request, #10281: [Fix&Feature] Fix the OSUtilsTest.loadAverage test case in windows, a…
106umao opened a new pull request, #10281:
URL: https://github.com/apache/dolphinscheduler/pull/10281
…nd support os windows to get loadAverage in OSUtils.loadAverage
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
## Purpose of the pull request
In this pull request, I fixed the problem that the OSUtils.loadAverage method could not get the CPU information under Windows. In addition, I found that many test cases cannot run on the Windows system, and it seems that it is not a good way to fix bugs one by one. Do we support developing on windows? If not, I think we should give some tips to developers in the official website documentation
## Brief change log
Use com.sun.management.OperatingSystemMXBean#getProcessCpuLoad(); instead of java.lang.management.OperatingSystemMXBean#.getSystemLoadAverage(); to get cpu load information on windows
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] 106umao commented on pull request #10281: [Fix&Feature] Fix the OSUtilsTest.loadAverage test case in windows, and support os windows to get loadAverage in OSUtils.loadAverage #10280
Posted by GitBox <gi...@apache.org>.
106umao commented on PR #10281:
URL: https://github.com/apache/dolphinscheduler/pull/10281#issuecomment-1140426893
Hi @zhuangchong
PTAL,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #10281: [Fix&Feature] Fix the OSUtilsTest.loadAverage test case in windows, and support os windows to get loadAverage in OSUtils.loadAverage #10280
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #10281:
URL: https://github.com/apache/dolphinscheduler/pull/10281#issuecomment-1140427572
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10281?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10281](https://codecov.io/gh/apache/dolphinscheduler/pull/10281?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (158b33b) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/7ac8ea493cf6f458097c695baa500dd0c22b3bb8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7ac8ea4) will **decrease** coverage by `0.00%`.
> The diff coverage is `16.66%`.
```diff
@@ Coverage Diff @@
## dev #10281 +/- ##
============================================
- Coverage 41.14% 41.14% -0.01%
Complexity 4759 4759
============================================
Files 855 855
Lines 34618 34621 +3
Branches 3826 3827 +1
============================================
- Hits 14245 14244 -1
- Misses 18998 19001 +3
- Partials 1375 1376 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/10281?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/dolphinscheduler/common/utils/OSUtils.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL09TVXRpbHMuamF2YQ==) | `30.43% <16.66%> (-1.22%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10281?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10281?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7ac8ea4...158b33b](https://codecov.io/gh/apache/dolphinscheduler/pull/10281?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10281: [Fix&Feature] Fix the OSUtilsTest.loadAverage test case in windows, and support os windows to get loadAverage in OSUtils.loadAverage #10280
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10281:
URL: https://github.com/apache/dolphinscheduler/pull/10281#issuecomment-1140428416
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10281)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10281&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10281&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10281&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10281&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10281&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10281&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10281&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10281&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10281&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10281&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10281&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10281&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10281&metric=new_coverage&view=list) [33.3% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10281&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10281&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10281&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] 106umao commented on pull request #10281: [Fix&Feature] Fix the OSUtilsTest.loadAverage test case in windows, and support os windows to get loadAverage in OSUtils.loadAverage #10280
Posted by GitBox <gi...@apache.org>.
106umao commented on PR #10281:
URL: https://github.com/apache/dolphinscheduler/pull/10281#issuecomment-1142218036
> yes, it has license issues By the way, DS doesn't support running on Windows, so these codes are not necessary
>
> > I understand that there is no com.sun.* package in openJDK, and I'm not sure if oracle JDK has lineces issues. @zhongjiajie Please help confirm.
Ok, since there is a certificate problem, I will close this pr. I have another question. I found that the system has been adapted to windows in many places. Maybe because some people develop on windows, is it necessary to make a special judgment in this test case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhuangchong commented on pull request #10281: [Fix&Feature] Fix the OSUtilsTest.loadAverage test case in windows, and support os windows to get loadAverage in OSUtils.loadAverage #10280
Posted by GitBox <gi...@apache.org>.
zhuangchong commented on PR #10281:
URL: https://github.com/apache/dolphinscheduler/pull/10281#issuecomment-1140454058
I understand that there is no com.sun.* package in openJDK, and I'm not sure if oracle JDK has lineces issues.
@zhongjiajie Please help confirm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] dailidong commented on pull request #10281: [Fix&Feature] Fix the OSUtilsTest.loadAverage test case in windows, and support os windows to get loadAverage in OSUtils.loadAverage #10280
Posted by GitBox <gi...@apache.org>.
dailidong commented on PR #10281:
URL: https://github.com/apache/dolphinscheduler/pull/10281#issuecomment-1142188969
yes, it has license issues
By the way, DS doesn't support running on Windows, so these codes are not necessary
> I understand that there is no com.sun.* package in openJDK, and I'm not sure if oracle JDK has lineces issues. @zhongjiajie Please help confirm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] 106umao closed pull request #10281: [Fix&Feature] Fix the OSUtilsTest.loadAverage test case in windows, and support os windows to get loadAverage in OSUtils.loadAverage #10280
Posted by GitBox <gi...@apache.org>.
106umao closed pull request #10281: [Fix&Feature] Fix the OSUtilsTest.loadAverage test case in windows, and support os windows to get loadAverage in OSUtils.loadAverage #10280
URL: https://github.com/apache/dolphinscheduler/pull/10281
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS closed pull request #10281: [Fix&Feature] Fix the OSUtilsTest.loadAverage test case in windows, and support os windows to get loadAverage in OSUtils.loadAverage #10280
Posted by GitBox <gi...@apache.org>.
SbloodyS closed pull request #10281: [Fix&Feature] Fix the OSUtilsTest.loadAverage test case in windows, and support os windows to get loadAverage in OSUtils.loadAverage #10280
URL: https://github.com/apache/dolphinscheduler/pull/10281
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org