You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/10/05 23:06:25 UTC
[GitHub] [zeppelin] llamasoft opened a new pull request #4244: [ZEPPELIN-5548] Startup scripts should consistently load Hadoop classpaths
llamasoft opened a new pull request #4244:
URL: https://github.com/apache/zeppelin/pull/4244
### What is this PR for?
The `bin/zeppelin.sh` startup script doesn't fully load the Hadoop classpaths in the same way that `bin/zeppelin-daemon.sh` does. As a result, anything that depends on the Hadoop classpaths being loaded (e.g. Shiro's KnoxJwtRealm) will fail.
### What type of PR is it?
Bug Fix/Improvement
### How should this be tested?
* Verify that `hadoop classpath` values are added to Zeppelin's java process's classpath.
* Verify that Shiro's KnoxJwtRealm loads correctly when running `USE_HADOOP=true HADOOP_CONF_DIR=/path/to/conf bin/zeppelin.sh`
* Verify that the Zeppelin Docker image still works as expected.
### Notes:
* The classpath loading logic was copied directly from `bin/zeppelin-daemon.sh`.
* The Zeppelin Docker image uses `bin/zeppelin.sh` as its startup script. This PR will make it easier for users to extend the Docker image by adding Hadoop to it. Currently, adding Hadoop requires extensive modifications to get the classpath to load correctly.
### Questions:
* `bin/zeppelin-daemon.sh` makes loading `HADOOP_CONF_DIR` conditional on `USE_HADOOP` but `bin/zeppelin.sh` previously didn't. Should `zeppelin.sh` be made to work the same as `zeppelin-daemon.sh` or should it retain loading `HADOOP_CONF_DIR` without checking `USE_HADOOP` for backwards compatibility?
* If this PR looks good, could you kindly apply the 'hacktoberfest-accepted' label? 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4244: [ZEPPELIN-5548] Startup scripts should consistently load Hadoop classpaths
Posted by GitBox <gi...@apache.org>.
jongyoul commented on pull request #4244:
URL: https://github.com/apache/zeppelin/pull/4244#issuecomment-937566087
@llamasoft Could you please let me know your jira id?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] jongyoul closed pull request #4244: [ZEPPELIN-5548] Startup scripts should consistently load Hadoop classpaths
Posted by GitBox <gi...@apache.org>.
jongyoul closed pull request #4244:
URL: https://github.com/apache/zeppelin/pull/4244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] llamasoft commented on pull request #4244: [ZEPPELIN-5548] Startup scripts should consistently load Hadoop classpaths
Posted by GitBox <gi...@apache.org>.
llamasoft commented on pull request #4244:
URL: https://github.com/apache/zeppelin/pull/4244#issuecomment-938000696
If it's not too much a bother, can I have a contributor add the `hacktoberfest-accepted` label to this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4244: [ZEPPELIN-5548] Startup scripts should consistently load Hadoop classpaths
Posted by GitBox <gi...@apache.org>.
jongyoul commented on pull request #4244:
URL: https://github.com/apache/zeppelin/pull/4244#issuecomment-937566087
@llamasoft Could you please let me know your jira id?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4244: [ZEPPELIN-5548] Startup scripts should consistently load Hadoop classpaths
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4244:
URL: https://github.com/apache/zeppelin/pull/4244#issuecomment-937442799
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4244: [ZEPPELIN-5548] Startup scripts should consistently load Hadoop classpaths
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4244:
URL: https://github.com/apache/zeppelin/pull/4244#issuecomment-937442799
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] llamasoft commented on pull request #4244: [ZEPPELIN-5548] Startup scripts should consistently load Hadoop classpaths
Posted by GitBox <gi...@apache.org>.
llamasoft commented on pull request #4244:
URL: https://github.com/apache/zeppelin/pull/4244#issuecomment-937875185
I was the one that opened the Jira ticket for this. The contribution guide mentioned making a Jira ticket before submitting a PR, so I went ahead and did that. The name is Marcus Truscello.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] jongyoul closed pull request #4244: [ZEPPELIN-5548] Startup scripts should consistently load Hadoop classpaths
Posted by GitBox <gi...@apache.org>.
jongyoul closed pull request #4244:
URL: https://github.com/apache/zeppelin/pull/4244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] llamasoft commented on pull request #4244: [ZEPPELIN-5548] Startup scripts should consistently load Hadoop classpaths
Posted by GitBox <gi...@apache.org>.
llamasoft commented on pull request #4244:
URL: https://github.com/apache/zeppelin/pull/4244#issuecomment-937875185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org