You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@plc4x.apache.org by Álvaro Del Castillo <ad...@ThingsO2.com> on 2019/12/16 07:14:43 UTC

Request for Review: Add float support to Modbus protocol

Dear all,

I ask for a reviewer to the PR:

https://github.com/apache/plc4x/pull/109

It is related to the issue:

https://issues.apache.org/jira/projects/PLC4X/issues/PLC4X-45

and it implements the reading of float data from Modbus.

Thank you!

-- Alvaro

Re: Request for Review: Add float support to Modbus protocol

Posted by Julian Feinauer <j....@pragmaticminds.de>.

I'm doing it currently.
If nobody else objects I will merge it today.

Julian

Am 16.12.19, 08:15 schrieb "Álvaro Del Castillo" <ad...@ThingsO2.com>:

    Dear all,
    
    I ask for a reviewer to the PR:
    
    https://github.com/apache/plc4x/pull/109
    
    It is related to the issue:
    
    https://issues.apache.org/jira/projects/PLC4X/issues/PLC4X-45
    
    and it implements the reading of float data from Modbus.
    
    Thank you!
    
    -- Alvaro