You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/26 06:11:34 UTC

[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #2118: boards: sim: Update smp/defconfig

masayuki2009 opened a new pull request #2118:
URL: https://github.com/apache/incubator-nuttx/pull/2118


   ## Summary
   
   - Add CONFIG_DRIVER_NOTE=y
   - Add CONFIG_NSH_READLINE=y
   - Add CONFIG_READLINE_CMD_HISTORY=y
   - Add CONFIG_SCHED_INSTRUMENTATION=y
   
   ## Impact
   
   - Affects sim:smp only
   
   ## Testing
   
   - Tested with uname/ps/free/hello/smp/ostest
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] sebastianene07 edited a comment on pull request #2118: boards: sim: Update smp/defconfig

Posted by GitBox <gi...@apache.org>.
sebastianene07 edited a comment on pull request #2118:
URL: https://github.com/apache/incubator-nuttx/pull/2118#issuecomment-716351716


   > > Do we want `CONFIG_SCHED_INSTRUMENTATION ` enabled by default ? I guess that we should keep it turned off and only during an investigation to activate it.
   > 
   > @sebastianene07
   > Once the NuttX smp feature becomes mature and stable, it should be removed by default.
   > However, I recommend enabling the feature.
   
   Right, I agree with you. I am also looking into increasing the SMP stability for the sim target.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2118: boards: sim: Update smp/defconfig

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2118:
URL: https://github.com/apache/incubator-nuttx/pull/2118


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] sebastianene07 commented on pull request #2118: boards: sim: Update smp/defconfig

Posted by GitBox <gi...@apache.org>.
sebastianene07 commented on pull request #2118:
URL: https://github.com/apache/incubator-nuttx/pull/2118#issuecomment-716328801


   Do we want `CONFIG_SCHED_INSTRUMENTATION ` enabled by default ? I guess that we should keep it turned off and only during an investigation to activate it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton commented on pull request #2118: boards: sim: Update smp/defconfig

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2118:
URL: https://github.com/apache/incubator-nuttx/pull/2118#issuecomment-716332592


   It would also be nice from a CI standpoint at least for SIM to have fewer configs that are feature heavy than lots of configs for each feature.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #2118: boards: sim: Update smp/defconfig

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #2118:
URL: https://github.com/apache/incubator-nuttx/pull/2118#issuecomment-716330882


   > Do we want `CONFIG_SCHED_INSTRUMENTATION ` enabled by default ? I guess that we should keep it turned off and only during an investigation to activate it.
   
   @sebastianene07 
   Once the NuttX smp feature becomes mature and stable, it should be removed by default.
   However, I recommend to enable the feature.
    


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] masayuki2009 edited a comment on pull request #2118: boards: sim: Update smp/defconfig

Posted by GitBox <gi...@apache.org>.
masayuki2009 edited a comment on pull request #2118:
URL: https://github.com/apache/incubator-nuttx/pull/2118#issuecomment-716330882


   > Do we want `CONFIG_SCHED_INSTRUMENTATION ` enabled by default ? I guess that we should keep it turned off and only during an investigation to activate it.
   
   @sebastianene07 
   Once the NuttX smp feature becomes mature and stable, it should be removed by default.
   However, I recommend enabling the feature.
    


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] sebastianene07 commented on pull request #2118: boards: sim: Update smp/defconfig

Posted by GitBox <gi...@apache.org>.
sebastianene07 commented on pull request #2118:
URL: https://github.com/apache/incubator-nuttx/pull/2118#issuecomment-716351716


   > > Do we want `CONFIG_SCHED_INSTRUMENTATION ` enabled by default ? I guess that we should keep it turned off and only during an investigation to activate it.
   > 
   > @sebastianene07
   > Once the NuttX smp feature becomes mature and stable, it should be removed by default.
   > However, I recommend enabling the feature.
   
   Right, I agree with you. I am also looking into increasing the SMP stability for sim target.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton edited a comment on pull request #2118: boards: sim: Update smp/defconfig

Posted by GitBox <gi...@apache.org>.
btashton edited a comment on pull request #2118:
URL: https://github.com/apache/incubator-nuttx/pull/2118#issuecomment-716332592


   It is also be nice from a CI standpoint at least for SIM to have fewer configs that are feature heavy than lots of configs for each feature.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org