[jira] Commented: (HADOOP-2461) Configuration should trim property names and accept decimal, hexadecimal, and octal numbers

["Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12592281#action_12592281 ] 

Amareshwari Sriramadasu commented on HADOOP-2461:
-------------------------------------------------

I think Nicholas's patch here suffices the requirements. 
It does trimming of configuration names. And accepts decimal, hexadecimal, and octal numbers, the representation followed in Java.
Do we need to do anything more here? 

If not, Nicholas could you please submit patch in sync with the trunk? And in the latest patch the testcase was missing, could you include testcase also in the patch?

> Configuration should trim property names and accept decimal, hexadecimal, and octal numbers
> -------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-2461
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2461
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>         Attachments: 2461_20071218.patch, 2461_20080208.patch
>
>
> I suggest two improvements in reading configuration:
> - Suppose we have the following property in a conf file.
> {code}
> <property>
> <name>
> testing.property</name>
> <value>something</value>
> </property>
> {code}
> Try to get it by
> {code}
> Configuration conf = new Configuration();
> String value = conf.get("testing.property"); //value == null here
> {code}
> We will get null since there is an eol in 
> {code}
> <name>
> testing.property</name>
> {code}
> I suggest to trim all property names.
> - I also suggest configuration to accept decimal, hexadecimal, and octal numbers (e.g. 011 is 9, 0xA is 10)
> It can be easily done by replacing Integer.parseInt(...) with Integer.decode(...) in Configuration.getInt(...), similarly, in Configuration.getLong(...).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.