You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/15 09:43:15 UTC
[GitHub] [flink] pnowojski commented on a change in pull request #13642: [task][hotfix] Remove PipelinedSubpartition.addBufferConsumer method
pnowojski commented on a change in pull request #13642:
URL: https://github.com/apache/flink/pull/13642#discussion_r505405128
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/RecoveredChannelStateHandler.java
##########
@@ -101,7 +101,10 @@ private RecoveredInputChannel getChannel(InputChannelInfo info) {
public void recover(ResultSubpartitionInfo subpartitionInfo, Tuple2<BufferBuilder, BufferConsumer> bufferBuilderAndConsumer) {
bufferBuilderAndConsumer.f0.finish();
if (bufferBuilderAndConsumer.f1.isDataAvailable()) {
- getSubpartition(subpartitionInfo).addBufferConsumer(bufferBuilderAndConsumer.f1);
+ boolean added = getSubpartition(subpartitionInfo).add(bufferBuilderAndConsumer.f1);
+ if (!added) {
+ throw new RuntimeException("Buffer consumer couldn't be added to ResultSubpartition");
Review comment:
`IOException`? (`org.apache.flink.runtime.checkpoint.channel.ChannelStateChunkReader#readChunk` already can handle `IOException`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org