You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2021/02/08 18:28:10 UTC
[GitHub] [qpid-dispatch] kgiusti opened a new pull request #1022: DISPATCH-1941: fix http1 parser to detect null characters
kgiusti opened a new pull request #1022:
URL: https://github.com/apache/qpid-dispatch/pull/1022
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-io commented on pull request #1022: DISPATCH-1941: fix http1 parser to detect null characters
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1022:
URL: https://github.com/apache/qpid-dispatch/pull/1022#issuecomment-775367687
# [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1022?src=pr&el=h1) Report
> Merging [#1022](https://codecov.io/gh/apache/qpid-dispatch/pull/1022?src=pr&el=desc) (474244c) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/044092aafaaaf20190fdeac720e1e27d5d1d6806?el=desc) (044092a) will **decrease** coverage by `0.07%`.
> The diff coverage is `100.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/qpid-dispatch/pull/1022/graphs/tree.svg?width=650&height=150&src=pr&token=rk2Cgd27pP)](https://codecov.io/gh/apache/qpid-dispatch/pull/1022?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1022 +/- ##
==========================================
- Coverage 82.50% 82.43% -0.08%
==========================================
Files 111 111
Lines 27308 27311 +3
==========================================
- Hits 22530 22513 -17
- Misses 4778 4798 +20
```
| [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1022?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/adaptors/http1/http1\_codec.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1022/diff?src=pr&el=tree#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX2NvZGVjLmM=) | `85.15% <100.00%> (+0.07%)` | :arrow_up: |
| [src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1022/diff?src=pr&el=tree#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j) | `84.27% <100.00%> (ø)` | |
| [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1022/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.29% <0.00%> (-3.88%)` | :arrow_down: |
| [...re/modules/edge\_addr\_tracking/edge\_addr\_tracking.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1022/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9hZGRyX3RyYWNraW5nL2VkZ2VfYWRkcl90cmFja2luZy5j) | `90.32% <0.00%> (-1.08%)` | :arrow_down: |
| [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1022/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `92.64% <0.00%> (-0.40%)` | :arrow_down: |
| [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1022/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==) | `86.68% <0.00%> (-0.02%)` | :arrow_down: |
| [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1022/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.12% <0.00%> (+0.19%)` | :arrow_up: |
| [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1022/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `88.81% <0.00%> (+0.19%)` | :arrow_up: |
| [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1022/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j) | `80.69% <0.00%> (+0.57%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1022?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1022?src=pr&el=footer). Last update [044092a...474244c](https://codecov.io/gh/apache/qpid-dispatch/pull/1022?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on pull request #1022: DISPATCH-1941: fix http1 parser to detect null characters
Posted by GitBox <gi...@apache.org>.
kgiusti commented on pull request #1022:
URL: https://github.com/apache/qpid-dispatch/pull/1022#issuecomment-778465975
Merged
https://github.com/apache/qpid-dispatch/commit/ce7c5a0cddb89fb32c80ebf7e3773d9a9e6ac973
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti closed pull request #1022: DISPATCH-1941: fix http1 parser to detect null characters
Posted by GitBox <gi...@apache.org>.
kgiusti closed pull request #1022:
URL: https://github.com/apache/qpid-dispatch/pull/1022
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org