You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org> on 2013/12/13 10:14:08 UTC
[jira] [Commented] (HDFS-5665) Remove the unnecessary writeLock
while initializing CacheManager in FsNameSystem Ctor
[ https://issues.apache.org/jira/browse/HDFS-5665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13847317#comment-13847317 ]
Uma Maheswara Rao G commented on HDFS-5665:
-------------------------------------------
Feel free to close this JIRA if you have a valid reason.
> Remove the unnecessary writeLock while initializing CacheManager in FsNameSystem Ctor
> -------------------------------------------------------------------------------------
>
> Key: HDFS-5665
> URL: https://issues.apache.org/jira/browse/HDFS-5665
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Affects Versions: 3.0.0, 2.2.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
>
> I just saw the below piece of code in Fsnamesystem ctor.
> {code}
> writeLock();
> try {
> this.cacheManager = new CacheManager(this, conf, blockManager);
> } finally {
> writeUnlock();
> }
> {code}
> It seems unnecessary to keep writeLock here. I am not sure if there is a clear reason to keep the lock.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)