You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/10/12 14:28:18 UTC
[GitHub] [superset] artemonsh opened a new issue, #21784: js words delimited by a dollar sign do not go into messages.pot
artemonsh opened a new issue, #21784:
URL: https://github.com/apache/superset/issues/21784
It seems that all variables that are delimited by a dollar sign like this: ```{`${t('Start (Longitude, Latitude)')}: `}``` are not being transferred to the messages.pot and messages.po files, hence no translation could be made.
#### How to reproduce the bug
1. Go to any file that contains template literals that contain dollar sign, e.g. [superset/superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Arc/Arc.jsx](https://github.com/apache/superset/blob/8f74e46d45ca94f5656f7b881f1096c16657c829/superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Arc/Arc.jsx#L40) or [superset/superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/TableRenderers.jsx](https://github.com/apache/superset/blob/8f74e46d45ca94f5656f7b881f1096c16657c829/superset-frontend/plugins/plugin-chart-echarts/src/Pie/controlPanel.tsx#L127)
2. Open [messages.pot](https://github.com/apache/superset/blob/master/superset/translations/messages.pot) and find out that these words/phrases are absent.
### Expected results
I expect to see all words/phrases wrapped in `t()` function inside messages.pot.
### Actual results
Words that are located inside [template literals](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals) do not go into messages.pot file.
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] artemonsh closed issue #21784: translated words delimited by a dollar sign (`${t('word')}`) don't go into messages.pot
Posted by GitBox <gi...@apache.org>.
artemonsh closed issue #21784: translated words delimited by a dollar sign (`${t('word')}`) don't go into messages.pot
URL: https://github.com/apache/superset/issues/21784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org