You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Evelina Dumitrescu <ev...@gmail.com> on 2014/12/04 21:14:10 UTC

Review Request 28718: Introduced getIP and created initialization wrappers for sockaddr_in and addrinfo

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28718/
-----------------------------------------------------------

Review request for mesos and Dominic Hamon.


Repository: mesos-git


Description
-------

Replaced obsolete functions gethostbyname2_r and gethostbyname2 with getaddrinfo and introduced getIP.
Created initialization wrappers for sockaddr_in and addrinfo


Diffs
-----

  src/sched/sched.cpp 0b08512d1b33857be89246d197184b0cc98e0540 
  src/tests/allocator_tests.cpp 65f05fd3a7c7ed6a667e278edecc234cfa99f517 
  src/tests/master_tests.cpp 4be48156a0c73eb76505ab88afb181fb56a8ebd3 

Diff: https://reviews.apache.org/r/28718/diff/


Testing
-------

make check


Thanks,

Evelina Dumitrescu


Re: Review Request 28718: Introduced getIP and created initialization wrappers for sockaddr_in and addrinfo

Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28718/
-----------------------------------------------------------

(Updated Dec. 5, 2014, 9:26 p.m.)


Review request for mesos and Dominic Hamon.


Bugs: MESOS-2178
    https://issues.apache.org/jira/browse/MESOS-2178


Repository: mesos-git


Description
-------

Replaced obsolete functions gethostbyname2_r and gethostbyname2 with getaddrinfo and introduced getIP.
Created initialization wrappers for sockaddr_in and addrinfo


Diffs (updated)
-----

  src/sched/sched.cpp 0b08512d1b33857be89246d197184b0cc98e0540 
  src/tests/allocator_tests.cpp 65f05fd3a7c7ed6a667e278edecc234cfa99f517 
  src/tests/master_tests.cpp 4be48156a0c73eb76505ab88afb181fb56a8ebd3 

Diff: https://reviews.apache.org/r/28718/diff/


Testing
-------

make check


Thanks,

Evelina Dumitrescu


Re: Review Request 28718: Introduced getIP and created initialization wrappers for sockaddr_in and addrinfo

Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28718/
-----------------------------------------------------------

(Updated Dec. 5, 2014, 9:23 p.m.)


Review request for mesos and Dominic Hamon.


Bugs: MESOS-2178
    https://issues.apache.org/jira/browse/MESOS-2178


Repository: mesos-git


Description
-------

Replaced obsolete functions gethostbyname2_r and gethostbyname2 with getaddrinfo and introduced getIP.
Created initialization wrappers for sockaddr_in and addrinfo


Diffs
-----

  src/sched/sched.cpp 0b08512d1b33857be89246d197184b0cc98e0540 
  src/tests/allocator_tests.cpp 65f05fd3a7c7ed6a667e278edecc234cfa99f517 
  src/tests/master_tests.cpp 4be48156a0c73eb76505ab88afb181fb56a8ebd3 

Diff: https://reviews.apache.org/r/28718/diff/


Testing
-------

make check


Thanks,

Evelina Dumitrescu


Re: Review Request 28718: Introduced getIP and created initialization wrappers for sockaddr_in and addrinfo

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28718/#review63904
-----------------------------------------------------------

Ship it!


Ship It!

- Dominic Hamon


On Dec. 4, 2014, 12:14 p.m., Evelina Dumitrescu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28718/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2014, 12:14 p.m.)
> 
> 
> Review request for mesos and Dominic Hamon.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Replaced obsolete functions gethostbyname2_r and gethostbyname2 with getaddrinfo and introduced getIP.
> Created initialization wrappers for sockaddr_in and addrinfo
> 
> 
> Diffs
> -----
> 
>   src/sched/sched.cpp 0b08512d1b33857be89246d197184b0cc98e0540 
>   src/tests/allocator_tests.cpp 65f05fd3a7c7ed6a667e278edecc234cfa99f517 
>   src/tests/master_tests.cpp 4be48156a0c73eb76505ab88afb181fb56a8ebd3 
> 
> Diff: https://reviews.apache.org/r/28718/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Evelina Dumitrescu
> 
>