You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "claudio4j (via GitHub)" <gi...@apache.org> on 2024/01/08 18:53:12 UTC

[PR] WIP - Use camel-kamelet-main to discover camel dependencies [camel-k]

claudio4j opened a new pull request, #5039:
URL: https://github.com/apache/camel-k/pull/5039

   <!-- Description -->
   
   Fix #527 #2600 #4027
   
   Invoking this small program adds 2s to the integration initialization task.
   
   Notes:
   1. TODO: On the camel-deps java project, add support for proxy and maven settings.
   2. I tried to use `camel dependency list` but it is a bit complex to have it running in an offlline mode, it was 2s slower too, as it creates a maven project, then export it.
   3. camel-deps is using Camel 4.4.0-SNAPSHOT since there are some important fixes in camel-kamelet-main since 4.3.0 final.
   4. Later this approach can be added to the camel-k run jbang command.
   
   <!--
   Enter your extended release note in the below block. If the PR requires
   additional action from users switching to the new release, include the string
   "action required". If no release note is required, write "NONE". 
   
   You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
   the text is added to the right section of the release notes. 
   -->
   
   **Release Note**
   ```release-note
   Fix: Enhance discovery of camel dependencies
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] WIP - Use camel-kamelet-main to discover camel dependencies [camel-k]

Posted by "claudio4j (via GitHub)" <gi...@apache.org>.
claudio4j closed pull request #5039: WIP - Use camel-kamelet-main to discover camel dependencies
URL: https://github.com/apache/camel-k/pull/5039


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] WIP - Use camel-kamelet-main to discover camel dependencies [camel-k]

Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #5039:
URL: https://github.com/apache/camel-k/pull/5039#issuecomment-1882662420

   Thanks for putting this experiment together. I think an effort like this makes sense only if integrated in other Camel tooling, ie, Camel JBang. It makes sense both from a design and maintenance point of view. We have already a `camel dependency list` command which we should leverage/enhance instead of reinventing the wheel. What I suggest is to have that command reliable enough and possible also work independently from the runtime chosen. Ideally, the same should be able to expose `capabilities` besides dependencies which I think this draft work does not cover.
   
   > I tried to use camel dependency list but it is a bit complex to have it running in an offlline mode, it was 2s slower too, as it creates a maven project, then export it.
   
   What we maybe need then is a development that makes that command to just list the project dependencies required on a generated project. Once that is ready, then, the operator can just use it to calculate the dependencies and capabilities of a source or, more in general, a project.
   
   I wonder if some of the development you've done here can be already reused on Camel JBang.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] WIP - Use camel-kamelet-main to discover camel dependencies [camel-k]

Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on PR #5039:
URL: https://github.com/apache/camel-k/pull/5039#issuecomment-1881702219

   I think that instead of being a process that is spawned every time, this could be an optional sidecar service as the same feature could also be re-used by other tools in the camel ecosystem
   
   @squakez @christophd @gansheer what do you think ? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] WIP - Use camel-kamelet-main to discover camel dependencies [camel-k]

Posted by "claudio4j (via GitHub)" <gi...@apache.org>.
claudio4j commented on PR #5039:
URL: https://github.com/apache/camel-k/pull/5039#issuecomment-1884764192

   `camel dependency list` uses camel-kamelet-main under the hood, I can propose some optimization to remove the exporting functionality and just list the dependencies.
   I will add this functionality to `camel k run` and see how it progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org