DO NOT REPLY [Bug 10228] New: - JDBC3 bug introduced

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10228>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10228

JDBC3 bug introduced

           Summary: JDBC3 bug introduced
           Product: Cocoon 2
           Version: 2.0.2
          Platform: Other
        OS/Version: Other
            Status: NEW
          Severity: Major
          Priority: Other
         Component: core
        AssignedTo: cocoon-dev@xml.apache.org
        ReportedBy: ser@germane-software.com


Hi!

Somebody, at some point, messed up the code that handles enabling/disabling the
JDBC3 methods in EsqlConnection.java.  That is, the @JDBC3_START@ and
@JDBC3_END@ were replaced with /* and */ respectively, in the source file that
gets filtered upon build.  This was probably due to somebody copying from the
build directory back into the source directory after the file had been filtered,
without paying attention to the filter tags.

In any case, this bug is still present in CVS.  In CVS, the filter tags have
been re-introduced, but comments have been added which nullify the fix.  IE,
what should be:

  @JDBC3_START@
  // ...
  @JDBC3_END@

is now:

  /* @JDBC3_START@
  // ...
  @JDBC3_END@ */

In case this isn't clear enough:  the ant build process replaces JDBC3_START
with /* and JDBC3_END with */ in case JDBC3 isn't present, and replaces both
with an empty string in case it is present.  2.0.2 is missing the JDBC3_START
and JDBC3_END tags, and the CVS version of the same file has the whole block
commented out so that the filtering is rendered irrelevant.  Neither 2.0.2 nor
the CVS version will build with the JDK1.4.

I'm attaching a patch for 2.0.2 (NOT against the CVS version); it is all of two
lines plus context, so you can easily make the change by hand.

---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org