You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/05/27 09:22:47 UTC
[GitHub] [dolphinscheduler] caoes opened a new issue, #10270: [Bug] [dolphinscheduler-api] datasource update input error password , still update success.
caoes opened a new issue, #10270:
URL: https://github.com/apache/dolphinscheduler/issues/10270
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
First, enter the correct data source account password for connection test, wait for the message that the link is successful, save the data source. Then edit the data source, enter the wrong password for editing, editing success.
### What you expected to happen
org.apache.dolphinscheduler.plugin.datasource.api.datasourceAbstractDatasourceProcessor##getDatasourceUniqueId method
Generate a unique key based only on the type data source user and link information, and skip authentication if the password is incorrect.
It is currently found that the mysql data source occasionally requires additional information to connect successfully.{"serverTimezone":"Asia/Shanghai"}
Other information must be configured for Hive data type ZK cluster connection mode. If other information is modified, the database cannot be connected .{"serviceDiscoveryMode":"zooKeeper","zooKeeperNamespace":"hiveserver2_zk"}
` public Connection getConnection(DbType dbType, ConnectionParam connectionParam) {
BaseConnectionParam baseConnectionParam = (BaseConnectionParam) connectionParam;
**_String datasourceUniqueId = DatasourceUtil.getDatasourceUniqueId(baseConnectionParam, dbType);_**
logger.info("getConnection datasourceUniqueId {}", datasourceUniqueId);
DataSourceClient dataSourceClient = uniqueId2dataSourceClientMap.computeIfAbsent(datasourceUniqueId, $ -> {
Map<String, DataSourceChannel> dataSourceChannelMap = dataSourcePluginManager.getDataSourceChannelMap();
DataSourceChannel dataSourceChannel = dataSourceChannelMap.get(dbType.getDescp());
if (null == dataSourceChannel) {
throw new RuntimeException(String.format("datasource plugin '%s' is not found", dbType.getDescp()));
}
return dataSourceChannel.createDataSourceClient(baseConnectionParam, dbType);
});
return dataSourceClient.getConnection();
}`
`**public String getDatasourceUniqueId(ConnectionParam connectionParam, DbType dbType) {
BaseConnectionParam baseConnectionParam = (BaseConnectionParam) connectionParam;
return MessageFormat.format("{0}@{1}@{2}@{3}", dbType.getDescp(), baseConnectionParam.getUser(), baseConnectionParam.getPassword(), baseConnectionParam.getJdbcUrl());
}**`
### How to reproduce
First, enter the correct data source account password for connection test, wait for the message that the link is successful, save the data source. Then edit the data source, enter the wrong password for editing, editing success.
### Anything else
_No response_
### Version
2.0.5
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #10270: [Bug] [dolphinscheduler-api] datasource update input error password , still update success.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #10270:
URL: https://github.com/apache/dolphinscheduler/issues/10270#issuecomment-1139441540
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://join.slack.com/t/asf-dolphinscheduler/shared_invite/zt-omtdhuio-_JISsxYhiVsltmC5h38yfw) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #10270: [Bug] [dolphinscheduler-api] datasource update input error password , still update success.
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #10270:
URL: https://github.com/apache/dolphinscheduler/issues/10270#issuecomment-1139444948
Hi @caoes , could you please check if this exists in ```dev``` branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] closed issue #10270: [Bug] [dolphinscheduler-api] datasource update input error password , still update success.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed issue #10270: [Bug] [dolphinscheduler-api] datasource update input error password , still update success.
URL: https://github.com/apache/dolphinscheduler/issues/10270
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #10270: [Bug] [dolphinscheduler-api] datasource update input error password , still update success.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #10270:
URL: https://github.com/apache/dolphinscheduler/issues/10270#issuecomment-1179834388
This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #10270: [Bug] [dolphinscheduler-api] datasource update input error password , still update success.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #10270:
URL: https://github.com/apache/dolphinscheduler/issues/10270#issuecomment-1170617035
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org