You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/04/12 17:58:05 UTC
[GitHub] [maven] gnodet opened a new pull request, #716: [MNG-7455] Another attempt to fix the concurrency issue
gnodet opened a new pull request, #716:
URL: https://github.com/apache/maven/pull/716
This is another attempt to fix the concurrency issue with minimal changes and without introducing back a thread local storage.
The downside of this proposal is that components annotated with `@SessionScoped` will always be injected the root session, which imho, is not really a problem as all derived sessions are cloned from the root one, except for the value of the `MavenSession#getCurrentProject()` which changes from one session to another.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet closed pull request #716: [MNG-7455] Another attempt to fix the concurrency issue
Posted by GitBox <gi...@apache.org>.
gnodet closed pull request #716: [MNG-7455] Another attempt to fix the concurrency issue
URL: https://github.com/apache/maven/pull/716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] laeubi commented on pull request #716: [MNG-7455] Another attempt to fix the concurrency issue
Posted by GitBox <gi...@apache.org>.
laeubi commented on PR #716:
URL: https://github.com/apache/maven/pull/716#issuecomment-1128630393
> is not really a problem as all derived sessions are cloned from the root one, except for the value of the `MavenSession#getCurrentProject()` which changes from one session to another.
I found especially this rather annoying, as one has to use the Legacy Support to get the "current" session.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet commented on pull request #716: [MNG-7455] Another attempt to fix the concurrency issue
Posted by GitBox <gi...@apache.org>.
gnodet commented on PR #716:
URL: https://github.com/apache/maven/pull/716#issuecomment-1128656332
> > is not really a problem as all derived sessions are cloned from the root one, except for the value of the `MavenSession#getCurrentProject()` which changes from one session to another.
>
> I found especially this rather annoying, as one has to use the Legacy Support to get the "current" session.
I think https://github.com/apache/maven/pull/743 should solve MNG-7455 too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org